Missing string format in deploy_chrome error path
Reported by
tbrindus@chromium.org,
May 31 2018
|
||
Issue description
If running deploy_chrome incorrectly (outside of a chromium src dir), the actual error will be masked out by a TypeError raised during the formatting of the real error message.
Traceback (most recent call last):
File "/mnt/host/source/chromite/lib/parallel.py", line 442, in _Run
self._task(*self._task_args, **self._task_kwargs)
File "/mnt/host/source/chromite/lib/parallel.py", line 654, in ReturnWrapper
queue.put(fn())
File "/mnt/host/source/chromite/scripts/deploy_chrome.py", line 325, in _PrepareStagingDir
self.copy_paths, self.chrome_dir)
File "/mnt/host/source/chromite/scripts/deploy_chrome.py", line 630, in _PrepareStagingDir
with _StripBinContext(options) as strip_bin:
File "/usr/lib64/python2.7/contextlib.py", line 17, in __enter__
return self.gen.next()
File "/mnt/host/source/chromite/scripts/deploy_chrome.py", line 610, in _StripBinContext
toolchain_url=options.toolchain_url) as ctx:
File "/usr/lib64/python2.7/contextlib.py", line 17, in __enter__
return self.gen.next()
File "/mnt/host/source/chromite/cli/cros/cros_chrome_sdk.py", line 402, in Prepare
version, _ = self.UpdateDefaultVersion()
File "/mnt/host/source/chromite/cli/cros/cros_chrome_sdk.py", line 316, in UpdateDefaultVersion
raise NoChromiumSrcDir(checkout_dir)
File "/mnt/host/source/chromite/cli/cros/cros_chrome_sdk.py", line 52, in __init__
Exception.__init__(self, 'No chromium src dir found in: ' % (path))
TypeError: not all arguments converted during string formatting
,
Jun 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e30abe6e3c20b2ee8eba0903eb2a0993cfa48ce commit 5e30abe6e3c20b2ee8eba0903eb2a0993cfa48ce Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat Jun 02 02:10:40 2018 Roll src/third_party/chromite d606e64..c4db222 (6 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/d606e64..c4db222 git log d606e64..c4db222 --date=short --no-merges --format='%ad %ae %s' 2018-06-02 tbrindus@chromium.org deploy_chrome: add missing string format in NoChromiumSrcDir exception 2018-06-02 achuith@chromium.org cros_run_vm_test: stream long running commands. 2018-06-02 ayatane@chromium.org infra_stages: Build skylab-inventory 2018-06-02 dgarrett@google.com config_lib: Remove dead site specific code. 2018-06-02 dgarrett@google.com config_lib: Have tests use config_lib not cbuildbot_config. 2018-06-02 mortonm@chromium.org Adjust tester for shill group. Created with: gclient setdep -r src/third_party/chromite@c4db222 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:848437 , chromium:829481 ,chromium:845337, chromium:848020 , chromium:848020 ,chromium:649417 TBR=chrome-os-gardeners@chromium.org Change-Id: If746ebf051296d3c05ede530501656a4339c8f10 Reviewed-on: https://chromium-review.googlesource.com/1083944 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#563915} [modify] https://crrev.com/5e30abe6e3c20b2ee8eba0903eb2a0993cfa48ce/DEPS
,
Jun 6 2018
Please, feel free to mark this as fixed if you believe all fixes are already landed.
,
Jun 6 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 2 2018