zoom into the focused editable doesn't work when use-zoom-for-dsf enabled |
||||
Issue descriptionOS: Android What steps will reproduce the problem? (1) enable use-zoom-for dsf (2) On a page with input box without viewport meta (http://output.jsbin.com/ciqucom/11/quiet) (3) tap on the input box What is the expected result? page should zoom to legible scale What happens instead? no zoom
,
Jun 1 2018
I came across what I think may cause this bug in an unrelated change. Hold off on this one until I land my patch and we'll see if that fixes it.
,
Jun 1 2018
,
Jun 1 2018
I've reduced the scope of my change so it wont affect this issue. My unconfirmed suspicion was that the Element bounds in WebViewImpl::ComputeScaleAndScrollForEditableElementRects are in CSS pixels but visual_viewport.VisibleRect() is in |physical pixels / page scale| (the latter I know for sure).
,
Jun 1 2018
I think Element bounds are in physical_pixel, but minReadableCaretHeight seems to be hard-coded css pixel value, so the calculated new scale is wrong :D See: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/exported/web_view_impl.cc?gsn=GetWebView&g=0&l=205
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b65e16f8cdabf8ea35a06d7ddf8db1c02330a918 commit b65e16f8cdabf8ea35a06d7ddf8db1c02330a918 Author: Ella Ge <eirage@chromium.org> Date: Tue Jun 19 17:30:46 2018 Fix zoom into focused editable when enable zoom-for-dsf When zoom-for-dsf enabled, element_bound_in_document is in physical pixel; however, minReadableCaretHeight is hard-coded css pixel value. So we need to applied page zoom factor to the min caret height before calculate the new page scale. Bug: 848434 Change-Id: I3fe529032fbc380f4dc90a42a0fef532b79ba38b Reviewed-on: https://chromium-review.googlesource.com/1085559 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568510} [modify] https://crrev.com/b65e16f8cdabf8ea35a06d7ddf8db1c02330a918/third_party/blink/renderer/core/exported/web_frame_test.cc [modify] https://crrev.com/b65e16f8cdabf8ea35a06d7ddf8db1c02330a918/third_party/blink/renderer/core/exported/web_view_impl.cc [modify] https://crrev.com/b65e16f8cdabf8ea35a06d7ddf8db1c02330a918/third_party/blink/renderer/core/exported/web_view_impl.h
,
Jun 21 2018
,
Jun 28 2018
Bug is fixed on Chrome Dev 69.0.3475.0 |
||||
►
Sign in to add a comment |
||||
Comment 1 by eirage@chromium.org
, May 31 2018Cc: bokan@chromium.org