New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848428 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 8
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-10-09
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

security_x86Registers failed on fizz

Project Member Reported by yunlian@chromium.org, May 31 2018

Issue description

This test failed on fizz release build.
http://cautotest/afe/#tab_id=view_job&object_id=204416515
 
Cc: llozano@chromium.org yunlian@chromium.org cmt...@chromium.org laszio@chromium.org jorgelo@chromium.org manojgupta@chromium.org
Components: Tests Infra>Security Infra>Client>ChromeOS>Test
Labels: -Pri-3 Pri-1
This test also consistently fails for snappy:

https://stainless.corp.google.com/search?exclude_cts=true&exclude_non_release=true&board=%5Esnappy%24&suite=%5Esecurity%24&view=matrix&col=build&row=test&first_date=2018-06-29&last_date=2018-07-26

This should be investigated/fixed.
Components: Security
ping for owner for this bug.
Any
Components: -Infra>Client>ChromeOS>Test
This continues to fail, and there is no owner.
Owner: puthik@chromium.org
Status: Assigned (was: Untriaged)
assigning to Puthik since he is one of the people that have modified this test.
Please re-assign or fix.
and what is the appropriate component for this bug.
Cc: drewry@google.com
drewry@

Will, can you help find an owner for this issue. Thanks
I'm happy to take a look, though I don't know whether I have a fizz device handy to test things locally. Can someone plug in a fizz device and paste the IP address here?
If it's easier for you to find one, it also fails pretty consistently on snappy, caroline, pyro, relm, terra and ultima.
I do have a caroline.
(not sure if this is the cause for all errors)

it looks like this logic needs updating for some newer CPUs? (like cave?)

https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/client/cros/power/power_utils.py?type=cs&q=power_utils+get_x86_cpu_arch&g=0&l=29

an example of not recognized CPU for cave

https://cmtice.users.x20web.corp.google.com/www/tt_cave_x86Registers.v2.out


I can def repro the failures, looking at the best short-term workaround for this.
Oh, and I should say: TestNA should not be considered an error -- on this test, for example, TestNA makes sense for ARM devices.

soraka, and caroline, on the other hand, are proper failures.
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f0ea56d4f6c8f439b047159694e890a40ce89fef

commit f0ea56d4f6c8f439b047159694e890a40ce89fef
Author: Jorge Lucangeli Obes <jorgelo@google.com>
Date: Fri Oct 05 14:21:50 2018

security_x86Registers: Fix VMX-related failures.

This test might not be long for this world. It tests VMX state in the
corresponding MSR, and the BILD bit in firmware. Well, it turns out VMX
is being set in all the boards supporting Crostini, so that check is
not very useful anymore.

Remove the VMX check on Intel for now, but keep the BILD check, which
is still useful.

BUG= chromium:848428 
TEST=Passes on soraka, caroline.

Change-Id: Icecba7b237dd7de99c4b1b590060e7e2752719af
Reviewed-on: https://chromium-review.googlesource.com/c/1259564
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/f0ea56d4f6c8f439b047159694e890a40ce89fef/client/site_tests/security_x86Registers/security_x86Registers.py

NextAction: 2018-10-09
Owner: jorgelo@chromium.org
Give it a couple of days to attempt some runs.
Status: Fixed (was: Assigned)
The NextAction date has arrived: 2018-10-09

Sign in to add a comment