Issue metadata
Sign in to add a comment
|
Regression: Omnibox divider is 1px too far left and no longer centered between Chip and URL |
||||||||||||||||||||
Issue descriptionChrome Version: Canary 69.0.3446.0 OS: macOS 10.13.4 but probably OS=All What steps will reproduce the problem? (1) Enable MacViews-Browser (2) Visit google.com (3) Take a look at the divider between Chip and URL in the Omnibox What is the expected result? The divider is 1px too far left. What happens instead? The divider should be shifted 1px to the right and be centered again between Chip and URL. This is a recent regression under MacViews and MD-Refesh on macOS. But maybe OS=All. This is the regression range: https://chromium.googlesource.com/chromium/src/+log/73fd1774fc6f2eab61651b2dba09f935b6df62af..c4b043ce14336b70e4859d2e80cdaba6d1049685 But not sure, which CL could have caused this. Maybe one of you in CC have an idea? Thanks Mehmet
,
Jun 1 2018
+cc tommycli@ just in case anything sticks out.
,
Jun 19 2018
,
Jun 21 2018
,
Jun 21 2018
,
Jul 30
I'm confused by this MacView / non-Proj-MacViews issue. But I know tommycli@ knows probably more than he wants to about divider logic, to assign to him to triage. (Please clarify the issue as appropriate.)
,
Jul 30
I don't think this is related to MacViews specifically, dropping that prefix.
,
Jul 30
In (Mac)Views (or MdRefresh) you will notice that the divider between Chip and URL-Text has been moved by 1px to the left, so that is no longer 100% centered between both. It started with the mentioned regression range in c#0, but it is hard to tell which CL could be the culprit. If you hover over the Chip so that its hover button appears, you'll see that the right edge of the hover button will no longer line up with the divider. The hover button overlaps the divider by 1px now, because the devider has been moved by 1px to the left. (It is not a bug in Cocoa-Browser.) I hope it is clearer now :) Thanks.
,
Aug 7
Indeed in some cases it's not perfectly aligned - and we do want it to get perfectly aligned. Here's my thoughts: - We need to finally settle the textfield jog vs. no-jog question before fixing this. - This will be an M70 or later polish task. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by skare@chromium.org
, May 31 2018