New Tab Button: Add Finch control for position |
|||
Issue descriptionThe new tab button position should be Finch-controllable. We already have an enum for this and an oracle function that returns it, so the Chrome side of the engineering ought not to be too hard; but marking as 2 days because I've never done anything with Finch, so there's a learning curve. P2 because we should not ship without this but we can make it to initial testing.
,
Jun 1 2018
Load-balancing this to Bret since IIRC he's actually touched Finch before, and he was looking for P1s :)
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51f113eca6a27edab877d6a5b81f20d648d4bae6 commit 51f113eca6a27edab877d6a5b81f20d648d4bae6 Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Jun 22 17:05:33 2018 Add finch control for the new tab button position in Refresh. We need to be able to change this later without a merge. Bug: 848420 Change-Id: Ie4f50f6a919e5e4e761c364776c702d40513637d Reviewed-on: https://chromium-review.googlesource.com/1111209 Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#569667} [modify] https://crrev.com/51f113eca6a27edab877d6a5b81f20d648d4bae6/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
,
Jun 22 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by robliao@chromium.org
, May 31 2018