Tabs: Inactive multiselected tabs should be close to active tab state |
||||||
Issue descriptionIn refresh, I think we should tweak kSelectedTabOpacity in tab.cc to be higher. bettes@ suggested using 1. I'm not sure we need to go that high, but something like 0.75 might be good.
,
Jun 7 2018
Let's start with an extreme: 1, and we can throttle back from there https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g3232c09376_6_1194
,
Jun 12 2018
,
Jun 12 2018
Okay, I took captures at 0.75, 0.875, and 1.0 using the classic theme so a designer can see and choose. I think any of these would be an improvement over the almost-unnoticeable 0.3 that it was.
,
Jun 14 2018
+monicagv, bettes (UX designers) to weigh in on which option looks best, or if they'd like to try another option.
,
Jun 14 2018
I just checked it out with Alan, in general we are more inclined towards .75. Can you mock up .6? Thank you
,
Jun 18 2018
Personally, I like 0.75 best of all the above shots.
,
Jun 21 2018
to bettes@ to close on decision
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcdd42dd3445ead273ec357ef2fc286e657a0273 commit dcdd42dd3445ead273ec357ef2fc286e657a0273 Author: Orin Jaworski <orinj@chromium.org> Date: Fri Jun 22 20:52:07 2018 Increase selected tab opacity When multiple tabs are selected, tabs other than the active selected tab are made more opaque to mark selection, but the old opacity of 0.3 was virtually unnoticeable so is here increased. Bug: 848416 Change-Id: I3b833808a77a11b29c00f69f3827c1a60d3f0eb9 Reviewed-on: https://chromium-review.googlesource.com/1112433 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#569763} [modify] https://crrev.com/dcdd42dd3445ead273ec357ef2fc286e657a0273/chrome/browser/ui/views/tabs/tab.cc
,
Jun 25 2018
Able to reproduce the issue on Mac 10.13.3 using chrome build without fix. Verified the fix on Mac 10.13.3, Win-10 and Ubuntu 17.10 using Chrome version #69.0.3472.0 as per the comment #0 and #4. Attaching screen shot for reference. Observed that when multiple tabs are selected, tabs other than the active selected tab are made more opaque to mark selection. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Jun 25 2018
bettes: Is there additional work required here?
,
Jun 25 2018
Since I filed this on my own initiative, I'm gonna say "good enough for now", let's open a new bug if we want to tweak further. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by markchang@chromium.org
, Jun 7 2018