Tabs: Hovered tab should be closer to active state |
|||||||||||||||||||||||||||||||||||||||||||||||||
Issue descriptionIn refresh, I think we should tweak kHoverOpacity in tab.cc to make hovered tabs more like active tabs. Complicating factors: * Increasing this value may make some themes look worse * How much you want this to increase depends on the width of the tab: wide tabs don't need a boost nearly the way narrow ones do Wild guess: try a linear function that scales between the current value (0.33) and about 0.85 as the tab layout width goes between the standard width and the minimum width. I'm going to set this as P2 because it feels like a significant usability issue at narrow widths, but it might slip to P3.
,
Jun 7 2018
,
Jun 12 2018
,
Jun 12 2018
The wild guess linear function is implemented, but 0.33 was too subtle even for wide tabs, so the opacity boost ranges from 0.44 at standard width up to 0.85 at minimum width. A few screen captures are attached, and I will upload a candidate CL now.
,
Jun 12 2018
Here are some screenshots with the upcoming-ui-features flag enabled. The opacity lerp is even more clear, and seems to have the intended effect of making hovered tabs pop.
,
Jun 14 2018
+monicagv, bettes (UX designers) to weigh in on which option looks best, or if they'd like to try another option.
,
Jun 14 2018
Thanks orinj@! C5 looks pretty good. One thing to note: the highlight color has a warm tone to it, compared to the cooler-grey tabstrip color. We've recently changed the tabstrip color from GG200 to a darker #DEE1E6 ( crbug.com/850981 ). Maybe that has yet to be reflected in the hover highlight color? In either case, I have a proposal in the attachment. The goal is to make the highlight a cool tone, rather than warm tone. LMK what you think.
,
Jun 14 2018
Sure :) This change is only affecting the opacity of hovered tabs. There is an additional hover highlight effect that moves immediately with the mouse pointer, not considered here. If we want to adjust color as well, to warm or cool the effects, I see the logic to be modified, but it will be a break from the status quo of fixed colors with varying opacity. It may make good sense to drive color too, but I expect pkasting@ will want to weigh in on this before changing color/opacity logic. For now my scope is narrow, aiming to give tabs some visual weight with higher opacity instead of remaining ghosts in the background as they were.
,
Jun 18 2018
pkasting: can you comment on the question raised in #7 and #9?
,
Jun 19 2018
Regarding comment 4/5, I think the 0.85 opacity for narrow tabs is too strong. I would reduce to maybe 0.7. The 0.44 bottom end seems about right. Regarding comment 7/9, as comment 9 notes, there are actually two different things going on when hovering a background tab: a blend of the active/inactive tab appearances (see https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab.cc?rcl=7cfbafc79b90602c341ee6a7e4ef8e9723341284&l=1469 ), plus an overlaid radial gradient (see https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab.cc?rcl=7cfbafc79b90602c341ee6a7e4ef8e9723341284&l=138 ). The original proposal on this bug deals only with the former and aims to shift the blend values. I don't really understand comment 7, but I think it's maybe talking about replacing either the former, or both aspects, with some kind of an overlaid highlight color across the whole tab. I think maybe Alan should split this out to a separate discussion/bug to clarify.
,
Jun 20 2018
New classic & mist screens with linear range from 0.44 to 0.7 (reduced from 0.85). This is running the current patch set 3 on https://chromium-review.googlesource.com/c/chromium/src/+/1097744
,
Jun 20 2018
Cool, those look better to me. I might even make the range 0.5 <-> 0.65, but what you have is already a win over trunk.
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c992b41502ac404bf719d79f89b3c9bc12953584 commit c992b41502ac404bf719d79f89b3c9bc12953584 Author: Orin Jaworski <orinj@chromium.org> Date: Wed Jun 20 18:41:39 2018 Increase tab hover opacity boost Tab hover opacity is boosted using a linear function ranging from minimum boost on max-width tabs to maximum boost on min-width tabs. The idea here is that wide tabs need less boost than narrow tabs, and the single constant boost of 0.33 was not enough to make tabs stand out. The new range intends to help tabs stand out more on various themes. Bug: 848415 Change-Id: I335035c2cc1760c314eeff71a59a727c321dcc57 Reviewed-on: https://chromium-review.googlesource.com/1097744 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#568945} [modify] https://crrev.com/c992b41502ac404bf719d79f89b3c9bc12953584/chrome/browser/ui/views/tabs/tab.cc
,
Jun 21 2018
Triage: everyone@ is this ready to be closed out? Thanks!
,
Jun 21 2018
I think so. I haven't tested in practice but let's assume we're good enough. |
|||||||||||||||||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||||||||||||||||||||
Comment 1 by pkasting@chromium.org
, Jun 1 2018