New issue
Advanced search Search tips

Issue 848413 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[autofill] Heuristics for search term field prediction is in address_field.cc

Project Member Reported by rogerm@chromium.org, May 31 2018

Issue description

The heuristics to parse and predict search term fields is mixed into the address field parser/predictor. The rest of the address field parser/predictor isnt aware of this relationsihip.

As currently implemented, search term fields can on be predicted if they're adjacent to an address field in the same (possibly implicit) form.
 
Components: UI>Browser>Autofill>Predictions
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5dcc18a2fd59efcb793b4c7cb5cf65d86bb42c8

commit d5dcc18a2fd59efcb793b4c7cb5cf65d86bb42c8
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Mon Jun 11 15:34:29 2018

[Autofill] Independent Heuristics for Search Fields

Search term fields can now only be predicted if they're adjacent to
an address field. By moving them to an independent parser, this will
not be the case anymore.

Bug:  848413 
Change-Id: I5a35e363314b58d75fefddb65b410ddcc840df9a
Reviewed-on: https://chromium-review.googlesource.com/1089371
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#566010}
[modify] https://crrev.com/d5dcc18a2fd59efcb793b4c7cb5cf65d86bb42c8/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/d5dcc18a2fd59efcb793b4c7cb5cf65d86bb42c8/components/autofill/core/browser/address_field.cc
[modify] https://crrev.com/d5dcc18a2fd59efcb793b4c7cb5cf65d86bb42c8/components/autofill/core/browser/address_field.h
[modify] https://crrev.com/d5dcc18a2fd59efcb793b4c7cb5cf65d86bb42c8/components/autofill/core/browser/address_field_unittest.cc
[modify] https://crrev.com/d5dcc18a2fd59efcb793b4c7cb5cf65d86bb42c8/components/autofill/core/browser/form_field.cc
[modify] https://crrev.com/d5dcc18a2fd59efcb793b4c7cb5cf65d86bb42c8/components/autofill/core/browser/form_field.h
[add] https://crrev.com/d5dcc18a2fd59efcb793b4c7cb5cf65d86bb42c8/components/autofill/core/browser/search_field.cc
[add] https://crrev.com/d5dcc18a2fd59efcb793b4c7cb5cf65d86bb42c8/components/autofill/core/browser/search_field.h
[add] https://crrev.com/d5dcc18a2fd59efcb793b4c7cb5cf65d86bb42c8/components/autofill/core/browser/search_field_unittest.cc
[modify] https://crrev.com/d5dcc18a2fd59efcb793b4c7cb5cf65d86bb42c8/components/autofill/core/common/autofill_regex_constants.cc

Status: Fixed (was: Started)

Sign in to add a comment