Tabs: Set the Min Width Per Spec |
||||||||||||||||
Issue descriptionAllow refresh tabs to shrink smaller; determine appropriate min width. The engineering here is basically done, estimated days is all about how much time is needed to split this into pieces, get it reviewed, etc.
,
May 31 2018
I think you meant to write "40", but I'm ignoring the spec on this one. My current value is 7.
,
Jun 1 2018
,
Jun 25 2018
bettes: Please refer to #2.
,
Jun 25 2018
#2 is referring to the default tab width for multi-tab appearances which is a bit different here. I went ahead and created crbug.com/856342 to separate this out. Monicagv@ to follow up here with the proper recommendation for min-width.
,
Jun 25 2018
re: 856342, Thanks Peter :)
,
Jun 26 2018
Min Tab Width Details For Pointer: - The minimum tab width shall be 24px. - Left padding starts at 12px when tabs are at their default width, it gradually minimizes to 4px at the smallest min width. For Touch: - The minimum tab width shall be 48dp. - Left padding is preserved at 12px even at the min width. Detailed spec attached and also available on: go/chrome-ux-gm2
,
Jun 28 2018
,
Jul 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/786c0a95664681ab1780d67a4bd2b5e4a27a21a6 commit 786c0a95664681ab1780d67a4bd2b5e4a27a21a6 Author: Peter Kasting <pkasting@chromium.org> Date: Mon Jul 02 23:51:06 2018 Allow refresh tabs to get much smaller. Bug: 848412 Test: Open lots of tabs and shrink the window width. Tabs should be able to get narrow enough that only a center strip of the favicon is visible. Change-Id: Iccfe31adb06b9c922c619ae5436b611a876b82e0 Reviewed-on: https://chromium-review.googlesource.com/1121819 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#572049} [modify] https://crrev.com/786c0a95664681ab1780d67a4bd2b5e4a27a21a6/chrome/browser/ui/views/tabs/tab.cc
,
Jul 2
For now I'm marking this fixed -- we can adjust min width as needed based on feedback
,
Jul 12
,
Jul 19
Reopening because it's convenient. * For M69 let's ship 16 DIP min width (unchanged from M68) -- this is a value everyone can live with for now * Try more than 1 DIP padding near favicon, e.g. 2 or 3 DIP (doesn't have to be a whole number) * Try shrinking the corner radii sooner than "when they touch" to make sure the tab shape always feels round-rect-y.
,
Jul 26
,
Jul 27
Screenshot of what I've done locally: * 16 DIP min width * 2.5 DIP favicon padding * Tab corner radii are clamped to 1/3 of the top width (so 5.333 DIP at min width) CL is at https://chromium-review.googlesource.com/c/chromium/src/+/1152546
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb0fecc3d8292b227ae607a42bbaf4b6eb4c8964 commit eb0fecc3d8292b227ae607a42bbaf4b6eb4c8964 Author: Peter Kasting <pkasting@chromium.org> Date: Fri Jul 27 20:56:41 2018 Update the tab min width and shape per initial UX feedback: * 16 DIP min width * 2.5 DIP minimum padding around favicons * Clamp radius to no more than 1/3 the width of the top of the tab The second and third bullets are subject to change pending further feedback. Bug: 848412 Change-Id: I5d800eb183b6ec2d3cd4933207f51f92b954fc9d Reviewed-on: https://chromium-review.googlesource.com/1152546 Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#578772} [modify] https://crrev.com/eb0fecc3d8292b227ae607a42bbaf4b6eb4c8964/chrome/browser/ui/views/tabs/tab.cc
,
Jul 31
,
Aug 3
I have an explicit LG from ainslie@ and monicagv@ for the behavior of comment 15, so requesting merge for that.
,
Aug 3
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 3
Approving merge to M69 branch 3497 based on comment #17. Please merge ASAP. Thank you.
,
Aug 3
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c15585b048d8b460b77169db7f1aac75223c1f0 commit 3c15585b048d8b460b77169db7f1aac75223c1f0 Author: Peter Kasting <pkasting@chromium.org> Date: Fri Aug 03 18:15:17 2018 Update the tab min width and shape per initial UX feedback: * 16 DIP min width * 2.5 DIP minimum padding around favicons * Clamp radius to no more than 1/3 the width of the top of the tab The second and third bullets are subject to change pending further feedback. Bug: 848412 Change-Id: I5d800eb183b6ec2d3cd4933207f51f92b954fc9d Reviewed-on: https://chromium-review.googlesource.com/1152546 Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578772}(cherry picked from commit eb0fecc3d8292b227ae607a42bbaf4b6eb4c8964) Reviewed-on: https://chromium-review.googlesource.com/1162561 Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#388} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/3c15585b048d8b460b77169db7f1aac75223c1f0/chrome/browser/ui/views/tabs/tab.cc
,
Aug 14
+abdulsyed@ fyi, M69 merges taken for Proj-MdRefresh . |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by bettes@chromium.org
, May 31 2018