New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848394 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 832309



Sign in to add a comment

"atest server create --skylab" creates servers with status "invalid"

Reported by jrbarnette@chromium.org, May 31 2018

Issue description

If you create a host using `atest server create --skylab`,
the initial host status will be "invalid", like this:

$ atest server list cros-full-0039.mtv.corp.google.com
Hostname     : cros-full-0039.mtv.corp.google.com
Status       : invalid
Roles        : shard
Attributes   : {}
Date Created : None
Date Modified: 2018-05-31 12:05:16
Note         : None

There's no option in the command to specify an initial status,
and the command doesn't create an initial status for the server,
either.

 
Labels: -Pri-3 Pri-2

Comment 2 by nxia@chromium.org, May 31 2018

Owner: nxia@chromium.org
I can add primary as the default status. to be consistent with the old atest tool, "atest server create --skylab" will still not allow a designated status. people need to use "atest server modify --skylab" to change the status.

Comment 3 by nxia@chromium.org, May 31 2018

Summary: "atest server create --skylab" creates servers with status "invalid" (was: "atest server create --skylab" creates hosts with status "invalid")

Comment 4 by nxia@chromium.org, Jun 1 2018

Blocking: 832309
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/skylab_inventory/+/f90676d9ae20373dc6513812e90bd203c37c391c

commit f90676d9ae20373dc6513812e90bd203c37c391c
Author: Ningning Xia <nxia@google.com>
Date: Fri Jun 01 21:45:42 2018

Create servers with default status "primary".

Support "atest server create" to create servers with STATUS_PRIMARY.

BUG= chromium:848394 
TEST="atest server create"

Change-Id: I094f5089b9c677c3848465827dc3f3c0a64f4b3e
Reviewed-on: https://chromium-review.googlesource.com/1081179
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/f90676d9ae20373dc6513812e90bd203c37c391c/venv/skylab_inventory/lib/server.py

Comment 6 by nxia@chromium.org, Jun 4 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment