Creating multiple servers at once doesn't work
Reported by
jrbarnette@chromium.org,
May 31 2018
|
|||||
Issue descriptionBecause of bug 828133 , I needed to add two shards to our shard list. My first attempt gave me this: ==== $ atest server create --skylab cros-full-0039.mtv.corp.google.com cros-full-0040.mtv.corp.google.com `server` topic can only manipulate 1 server. Use -h to see available options. usage: atest server [list|create|delete|modify] [options] <server> ==== That's obnoxious: I shouldn't have to run the command twice; the command should allow multiple servers on the command line. However, the follow-on result only aggravated the problem: ==== : jrbarnette ~; atest server create --skylab --role shard cros-full-0039.mtv.corp.google.com Server cros-full-0039.mtv.corp.google.com is added. hostname: "cros-full-0039.mtv.corp.google.com" environment: ENVIRONMENT_PROD roles: ROLE_SHARD Please submit the CL at https://chrome-internal-review.googlesource.com/634067 to make the change effective. : jrbarnette ~; atest server create --skylab --role shard cros-full-0040.mtv.corp.google.com Server cros-full-0040.mtv.corp.google.com is added. hostname: "cros-full-0040.mtv.corp.google.com" environment: ENVIRONMENT_PROD roles: ROLE_SHARD Please submit the CL at https://chrome-internal-review.googlesource.com/634068 to make the change effective. ==== So, now I had both of the CLs. I went and submitted the first. The second couldn't be submitted, because it triggered a merge error. The process is far too error prone, and needs to be simplified somehow.
,
May 31 2018
> `server` topic can only manipulate 1 server. Use -h to see available options. This is not specific to "--skylab", "atest server create" only allows one server at a time. >The second couldn't be submitted, because it triggered a merge error. 2 ways to create 2 servers in a row: 1) use "--submit" to submit CLs directly. 2) submit the previous CL before run "atest server create" again.
,
May 31 2018
> > `server` topic can only manipulate 1 server. Use -h to see available options.
>
> This is not specific to "--skylab", "atest server create" only allows one server at a time.
Yeah, I discovered that. It's wrong wherever it happens.
> 2 ways to create 2 servers in a row:
>
> 1) use "--submit" to submit CLs directly.
> 2) submit the previous CL before run "atest server create" again.
These are viable workarounds, but they don't really fix the problem.
What's needed is a command that doesn't require that level of mollycoddling
in order for it to work right.
In practice, I'd like to see two things:
1) The various `atest server` commands should accept more than server on
the command line.
2) If you run multiple `atest server` commands in a row that submit a CL,
somehow, that needs to be well-behaved, even if the CLs aren't submitted
in series.
For item 2), it would probably be all right if it worked right without extra
options. In other words, if we fix bug 848396, I could live with it.
,
Jun 8 2018
,
Jul 24
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9e0cfaaa2ed3a16c4e310d39ea579ffee5ea9180 commit 9e0cfaaa2ed3a16c4e310d39ea579ffee5ea9180 Author: Xixuan Wu <xixuan@chromium.org> Date: Fri Jul 27 06:59:49 2018 autotest: Support to create multiple servers in skylab inventory. BUG= chromium:848391 TEST=https://chrome-internal-review.googlesource.com/c/chromeos/infra_internal/skylab_inventory/+/655905 Change-Id: Ie400e2db900f3e29b3c2a4236275e124836ad315 Reviewed-on: https://chromium-review.googlesource.com/1150848 Commit-Ready: Xixuan Wu <xixuan@chromium.org> Tested-by: Xixuan Wu <xixuan@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/9e0cfaaa2ed3a16c4e310d39ea579ffee5ea9180/cli/server.py
,
Aug 3
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jrbarnette@chromium.org
, May 31 2018