Disable single-tab mode for inactive windows |
||||||||
Issue descriptionSingle-tab windows can't distinguish active/inactive frames, since they're drawn with the whole frame using the toolbar color/image. We can test single-tab mode without addressing this, but if possible we should fix before shipping it; so P2. My proposal for this was to draw inactive windows as normal inactive rather than single-tab windows. But this could result in weird transitions, e.g. if you have a pinned tab with a long title, so the title completely disappears/reappears when changing the window activation. We could alleviate this by only changing the frame color, but not tabstrip layout, in inactive windows. In this case, though, we'd either have a "big active tab" (which might look weird) or we'd need to draw this tab using the background tab logic that matches the tab color to the frame color (so such windows would appear not to have an "active tab shape" in the strip at all). This latter sounds best to me.
,
May 31 2018
I was just going to disable single-tab mode if your single tab is pinned. It's probably not going to remain a single tab window.
,
May 31 2018
I don't have a strong opinion on that (there are pros and cons; I suggest filing a standalone bug to track the idea), but even if you do that, I think all the issues in comment 0 are still present, it's just that the transition between the two states is a little less harsh.
,
Jun 1 2018
,
Jun 7 2018
bettes@ to make the call on pinning
,
Jun 11 2018
Triage call on pinned tab: Allow single tab to be pinned -> changes to regular pinned tab appearance. bettes@ to continue thinking on inactive window state
,
Jun 19 2018
I suggest filing comment 6 as a separate bug.
,
Jun 28 2018
We made single tab mode disabled when there's a single pinned tab. Given that the current proposal for single tab mode is to use the standard tab width, there are now no weird transitions we'll encounter. Accordingly, the solution we agreed on in https://docs.google.com/document/d/1Am3ac8fMKpCrqlRtOP4vgcTBIzJPLsbPW3m4rtM57GY/edit#heading=h.y0gcjlz9o9mb (single tab appearance only for active windows) makes sense. ->bsep to implement
,
Jun 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f06b8215fecae3d2c5d8bb74d93bdf353aeee939 commit f06b8215fecae3d2c5d8bb74d93bdf353aeee939 Author: Bret Sepulveda <bsep@chromium.org> Date: Sat Jun 30 00:44:16 2018 Disable single-tab mode when the window is inactive, per the spec. Bug: 848379 Change-Id: I49106f2a7ebd5c39ad7508d8385d9b0babb6aa3b Reviewed-on: https://chromium-review.googlesource.com/1121385 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#571725} [modify] https://crrev.com/f06b8215fecae3d2c5d8bb74d93bdf353aeee939/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
,
Jun 30 2018
,
Jul 2
@Bret Sepulveda: As we are not very sure about the expected and actual behaviour, Could you please mention the steps in order to verify it manually from our end. Thanks!
,
Jul 2
1. Open a new window with a single tab 2. Focus something else 3. The single tab should be visible against a gray background, rather than entirely being white
,
Jul 12
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by pkasting@chromium.org
, May 31 2018