Integration of query_parser and tokenized_string_match |
|||
Issue descriptionsky@, would you please provide a suggestion. Thanks! In bug 842951, it requests that Keyboard Shortcut Viewer to provide a "fuzzy search" to search content. E.g. We have a string "move active window". Using TokenizedStringMatch [1], we can query "move window", "move active window". But the limitation is that we can not search by "window move". I can think of a way to separate the "query" to single word, and do the single world query one by one. QueryParser [2] does this one by one search: "matches at least one of the words in |words|." To make TokenizedStringMatch be available to different UI/apps, xiyuan@ suggested: 1. Move TokenizedStringMatch from src/ash/public/cpp/app_list to some folder under src/components, similar to src/components/query_parser. 2. Maybe integrate TokenizedStringMatch with QueryParser. [1] https://cs.chromium.org/chromium/src/ash/public/cpp/app_list/tokenized_string_match.h?l=25&rcl=e95eb8be81e343847b5f34325fdfae1f1de786a0 [2] https://cs.chromium.org/chromium/src/components/query_parser/query_parser.h?l=75&rcl=5e7123e8b4cfdb05b16b8b0498ac49286716b709
,
May 31 2018
I'm not familiar with TokenizedStringSearch. My recommendation is put the shared code in ash/components/parser and use from app_list and ksv.
,
May 31 2018
Thanks sky@.
,
Jun 1 2018
#2, the app_list needs to use TokenizedStringMatch in: 1. chrome/browser/ui/app_list/search/* 2. chrome/browser/chromeos/launcher_search_provider/* Seems ash/components/parser is not an idea place to put it.
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
,
Oct 5
We may not need this. close the bug. |
|||
►
Sign in to add a comment |
|||
Comment 1 by wutao@chromium.org
, May 31 2018