New issue
Advanced search Search tips

Issue 848371 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 848368



Sign in to add a comment

RPC Explorer: add support for field masks

Project Member Reported by no...@chromium.org, May 31 2018

Issue description

FieldMask has a special JSON encoding
https://github.com/google/protobuf/blob/cf242503ec157a7dda8a6eda48712dd26c81d2e6/src/google/protobuf/field_mask.proto#L187

RPC Explorer doesn't know that and thinks it should be encoded as string.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/a2bb957457f01c38a854c402f81178841cac7c6f

commit a2bb957457f01c38a854c402f81178841cac7c6f
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Jun 01 18:14:22 2018

[rpcexplorer] Add support for field masks

Field masks are JSON-encoded as a single string, not a message.
Take that into account in code completer.

This CL does not update tests because rpcexplorer development is currently
completely broken: crbug.com/848368

Bug:  848371 
Change-Id: Ia874144930324c5fd9dcf7f7d3b2e5f62b2e4af5
Reviewed-on: https://chromium-review.googlesource.com/1082653
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/a2bb957457f01c38a854c402f81178841cac7c6f/web/inc/rpcexplorer/rpc-completer.html

Comment 3 by no...@chromium.org, Jun 1 2018

Status: Fixed (was: Started)

Sign in to add a comment