New issue
Advanced search Search tips

Issue 848361 link

Starred by 2 users
Status: Duplicate
Merged: issue 789644
Owner:
cduvall@chromium.org
Closed: Jun 2018
Cc:
dougt@chromium.org
jam@chromium.org
mmenke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Enabling or Disabling network service flag sign's me out of gmail.

Project Member Reported by pbomm...@chromium.org, May 31 2018 
Chrome Version: 69.0.3446.0
OS: Win10


What steps will reproduce the problem?
1. Install and launch Chrome Canary 
2. Visit "https://www.gmail.com" and signin.
3. Enable "Enable network service" flag from "About://flags"
4. Relaunch Chrome

What is the expected result?
Should be still signed in to gmail.com


What happens instead?
Kicked me out of gmail and need to signin back again

Comment 1 by dougt@chromium.org, May 31 2018

Labels: Proj-Servicification-Canary

Comment 2 by dxie@chromium.org, May 31 2018

Cc: dougt@chromium.org
Owner: jam@chromium.org
jam@, is this because we are opening a new https connection to gmail and reseting the old connection?

I'm not sure if this needs to be a canary blocker.

Comment 3 by mmenke@chromium.org, Jun 5 2018

Labels: -Pri-3 Pri-1
dxie:  This needs to block Canary.  There's some issue with recovering the cookie store, so presumably all cookies are being lost (which is a pretty big deal), unless this is a token binding issue.

Comment 4 by jam@chromium.org, Jun 18 2018

Cc: jam@chromium.org mmenke@chromium.org
Owner: cduvall@chromium.org
I believe this is because of the encryption we do for cookies on disk; looks like Clark is already planning on looking at it per https://bugs.chromium.org/p/chromium/issues/detail?id=789644#c10 so I'll assign it to him.

Comment 5 by cduvall@chromium.org, Jun 27 2018

Mergedinto: 789644
Status: Duplicate (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87135a31e034842e4e2030b309276e8851008cc4

commit 87135a31e034842e4e2030b309276e8851008cc4
Author: Clark DuVall <cduvall@chromium.org>
Date: Wed Jul 04 01:49:54 2018

Network Service: Enable encrypted cookies

Cookies will now be stored encrypted by default in the network service.
Tested that  crbug.com/848361  is fixed with this change.

Bug:  789632 ,  848361 ,  789644 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ic627501ddf1c5030bbf2a203f005f5ebca92dfd8
Reviewed-on: https://chromium-review.googlesource.com/1104791
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572444}
[modify] https://crrev.com/87135a31e034842e4e2030b309276e8851008cc4/chrome/browser/chrome_browser_main_linux.cc
[add] https://crrev.com/87135a31e034842e4e2030b309276e8851008cc4/chrome/browser/chrome_network_service_browsertest.cc
[modify] https://crrev.com/87135a31e034842e4e2030b309276e8851008cc4/chrome/browser/net/system_network_context_manager.cc
[modify] https://crrev.com/87135a31e034842e4e2030b309276e8851008cc4/chrome/test/BUILD.gn
[modify] https://crrev.com/87135a31e034842e4e2030b309276e8851008cc4/components/safe_browsing/browser/safe_browsing_network_context.cc
[modify] https://crrev.com/87135a31e034842e4e2030b309276e8851008cc4/services/network/BUILD.gn
[modify] https://crrev.com/87135a31e034842e4e2030b309276e8851008cc4/services/network/DEPS
[modify] https://crrev.com/87135a31e034842e4e2030b309276e8851008cc4/services/network/network_context.cc
[modify] https://crrev.com/87135a31e034842e4e2030b309276e8851008cc4/services/network/network_service.cc
[modify] https://crrev.com/87135a31e034842e4e2030b309276e8851008cc4/services/network/network_service.h
[modify] https://crrev.com/87135a31e034842e4e2030b309276e8851008cc4/services/network/network_service_unittest.cc
[modify] https://crrev.com/87135a31e034842e4e2030b309276e8851008cc4/services/network/public/mojom/BUILD.gn
[modify] https://crrev.com/87135a31e034842e4e2030b309276e8851008cc4/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/87135a31e034842e4e2030b309276e8851008cc4/services/network/public/mojom/network_service.mojom
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea0521dd24669f34f0d64927eef0fa847b677eb0

commit ea0521dd24669f34f0d64927eef0fa847b677eb0
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Wed Jul 04 06:04:00 2018

Revert "Network Service: Enable encrypted cookies"

This reverts commit 87135a31e034842e4e2030b309276e8851008cc4.

Reason for revert: ChromeNetworkServiceBrowserTest.EncryptedCookies
keeps failing on Mac10.11 bot.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/27835

Original change's description:
> Network Service: Enable encrypted cookies
> 
> Cookies will now be stored encrypted by default in the network service.
> Tested that  crbug.com/848361  is fixed with this change.
> 
> Bug:  789632 ,  848361 ,  789644 
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: Ic627501ddf1c5030bbf2a203f005f5ebca92dfd8
> Reviewed-on: https://chromium-review.googlesource.com/1104791
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572444}

TBR=dcheng@chromium.org,jam@chromium.org,mmenke@chromium.org,cfroussios@chromium.org,morlovich@chromium.org,cduvall@chromium.org

Change-Id: I192a10c6d28a102dcf5ae247cdbda4c602872eb9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  789632 ,  848361 ,  789644 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1125460
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572490}
[modify] https://crrev.com/ea0521dd24669f34f0d64927eef0fa847b677eb0/chrome/browser/chrome_browser_main_linux.cc
[delete] https://crrev.com/2de92717271b3a0bd9eaf260bed975b6e9c0e76a/chrome/browser/chrome_network_service_browsertest.cc
[modify] https://crrev.com/ea0521dd24669f34f0d64927eef0fa847b677eb0/chrome/browser/net/system_network_context_manager.cc
[modify] https://crrev.com/ea0521dd24669f34f0d64927eef0fa847b677eb0/chrome/test/BUILD.gn
[modify] https://crrev.com/ea0521dd24669f34f0d64927eef0fa847b677eb0/components/safe_browsing/browser/safe_browsing_network_context.cc
[modify] https://crrev.com/ea0521dd24669f34f0d64927eef0fa847b677eb0/services/network/BUILD.gn
[modify] https://crrev.com/ea0521dd24669f34f0d64927eef0fa847b677eb0/services/network/DEPS
[modify] https://crrev.com/ea0521dd24669f34f0d64927eef0fa847b677eb0/services/network/network_context.cc
[modify] https://crrev.com/ea0521dd24669f34f0d64927eef0fa847b677eb0/services/network/network_service.cc
[modify] https://crrev.com/ea0521dd24669f34f0d64927eef0fa847b677eb0/services/network/network_service.h
[modify] https://crrev.com/ea0521dd24669f34f0d64927eef0fa847b677eb0/services/network/network_service_unittest.cc
[modify] https://crrev.com/ea0521dd24669f34f0d64927eef0fa847b677eb0/services/network/public/mojom/BUILD.gn
[modify] https://crrev.com/ea0521dd24669f34f0d64927eef0fa847b677eb0/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/ea0521dd24669f34f0d64927eef0fa847b677eb0/services/network/public/mojom/network_service.mojom
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c6f0e1c732f129237c96e7e01622da7d54bdd7a

commit 1c6f0e1c732f129237c96e7e01622da7d54bdd7a
Author: Clark DuVall <cduvall@chromium.org>
Date: Fri Jul 06 17:31:34 2018

Reland "Network Service: Enable encrypted cookies"

This is a reland of 87135a31e034842e4e2030b309276e8851008cc4

Original change's description:
> Network Service: Enable encrypted cookies
>
> Cookies will now be stored encrypted by default in the network service.
> Tested that  crbug.com/848361  is fixed with this change.
>
> Bug:  789632 ,  848361 ,  789644 
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: Ic627501ddf1c5030bbf2a203f005f5ebca92dfd8
> Reviewed-on: https://chromium-review.googlesource.com/1104791
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572444}

TBR=jam@chromium.org,dcheng@chromium.org,mmenke@chromium.org,cfroussios@chromium.org,morlovich@chromium.org

Bug:  789632 ,  848361 ,  789644 
Change-Id: I68ec0249a0f8fba8563c4a24abb6482da33d4ebc
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1127960
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573003}
[modify] https://crrev.com/1c6f0e1c732f129237c96e7e01622da7d54bdd7a/chrome/browser/chrome_browser_main_linux.cc
[add] https://crrev.com/1c6f0e1c732f129237c96e7e01622da7d54bdd7a/chrome/browser/chrome_network_service_browsertest.cc
[modify] https://crrev.com/1c6f0e1c732f129237c96e7e01622da7d54bdd7a/chrome/browser/net/system_network_context_manager.cc
[modify] https://crrev.com/1c6f0e1c732f129237c96e7e01622da7d54bdd7a/chrome/test/BUILD.gn
[modify] https://crrev.com/1c6f0e1c732f129237c96e7e01622da7d54bdd7a/components/safe_browsing/browser/safe_browsing_network_context.cc
[modify] https://crrev.com/1c6f0e1c732f129237c96e7e01622da7d54bdd7a/services/network/BUILD.gn
[modify] https://crrev.com/1c6f0e1c732f129237c96e7e01622da7d54bdd7a/services/network/DEPS
[modify] https://crrev.com/1c6f0e1c732f129237c96e7e01622da7d54bdd7a/services/network/network_context.cc
[modify] https://crrev.com/1c6f0e1c732f129237c96e7e01622da7d54bdd7a/services/network/network_service.cc
[modify] https://crrev.com/1c6f0e1c732f129237c96e7e01622da7d54bdd7a/services/network/network_service.h
[modify] https://crrev.com/1c6f0e1c732f129237c96e7e01622da7d54bdd7a/services/network/network_service_unittest.cc
[modify] https://crrev.com/1c6f0e1c732f129237c96e7e01622da7d54bdd7a/services/network/public/mojom/BUILD.gn
[modify] https://crrev.com/1c6f0e1c732f129237c96e7e01622da7d54bdd7a/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/1c6f0e1c732f129237c96e7e01622da7d54bdd7a/services/network/public/mojom/network_service.mojom

Comment 9 by jmukthavaram@chromium.org, Jul 16

Labels: TE-Verified-69.0.3493.0 TE-Verified-M69
Tested this issue on Windows 10 using chrome latest canary-69.0.3493.0 as per C#0.

User gmail account is still signed in even network-services flag is either enabled/disabled.Seems it is working as intended, adding TE verified labels.

Please find the attached screencast for reference .
Thanks..!
848361-Fixed on Win-69.0.3493.0.mp4
3.7 MB View Download

Comment 10 by pbomm...@chromium.org, Jul 18 

I see that we still have this issue and below are steps which reproduces the issue :


Steps to reproduce :
1. Install and launch Chrome Canary 
2. From Chrome://flags -->Enable "Enable network service" flag from "About://flags"
3. Relaunch Chrome
4. Visit "https://www.gmail.com" and signin.
5. Make sure you are signed in and also verify that "chrome://settings/content/cookies --> Keep local data only until you quit your browser" isn't enabled.
6. From Chrome://flags -->Disable "Enable network service" flag from "About://flags"

What is the expected result?
Should still be signed in to gmail.com 

What happens instead?
Kicked me out of gmail.
►

Sign in to add a comment