New issue
Advanced search Search tips

Issue 848348 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 20
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 785986



Sign in to add a comment

SitePerProcessHitTestBrowserTest.CrossProcessMouseEnterAndLeaveTest fails on Viz

Project Member Reported by jonr...@chromium.org, May 31 2018

Issue description

OS: Linux
Test suite: content_browsertests
TEST: SitePerProcessHitTestBrowserTest.CrossProcessMouseEnterAndLeaveTest.*

I'm working on a patch which provides a hit testing api, so that this test can be ran in Viz (--enable-features=VizDisplayCompositor)

However with this api the test uncovers an error in both /1 and /2 variants, where the test times out on the first call to RouteMouseEventAndWaitUntilDispatch. The InputEventAckWaiter never receives the event.
 
Also happening with: CrossProcessMouseCapture

In both cases the hit test data for the expected_target has arrived in the browser process.

Comment 2 by sadrul@chromium.org, May 31 2018

Cc: kenrb@chromium.org
Also SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF*
Reproduced today ahead of triage

Comment 5 by kenrb@chromium.org, Jun 21 2018

I expect to land a CL today that includes a rewrite of  SitePerProcessHitTestBrowserTest.CrossProcessMouseCapture, I don't know if it will help or not.
Labels: -Pri-3 Pri-1
Owner: kenrb@chromium.org
Status: Assigned (was: Untriaged)
Since you are re-working this test, could you re-run them under Viz to ensure that the input events are being acked?

Thanks
SitePerProcessHitTestBrowserTest.CrossProcessMouseEnterAndLeaveTest /1 and /2 both still fail under Viz
SitePerProcessHitTestBrowserTest.CrossProcessMouseCapture           /1 and /2 both still fail under Viz

All time out in InputEventAckWaiter::Wait for the first call to RouteMouseEventAndWaitUntilDispatch. Meaning the events are not arriving at the expected target.

It looks like the rewrite did not resolve the issue. Could you take a look?


Project Member

Comment 8 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a57a12587f7ace3b15480262c181ced968346ea4

commit a57a12587f7ace3b15480262c181ced968346ea4
Author: Jonathan Ross <jonross@chromium.org>
Date: Wed Jul 11 20:15:50 2018

Updating Viz Content BrowserTests Filter

A few tests have been fixed. This updates the filter accordingly to re-enable them.

TEST=SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest
SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF
Bug:  848825 ,  848348 

Change-Id: If05696e57dfee18cc6ae06c21f7d968982c31219
Reviewed-on: https://chromium-review.googlesource.com/1133863
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574302}
[modify] https://crrev.com/a57a12587f7ace3b15480262c181ced968346ea4/testing/buildbot/filters/viz.android.content_browsertests.filter
[modify] https://crrev.com/a57a12587f7ace3b15480262c181ced968346ea4/testing/buildbot/filters/viz.content_browsertests.filter

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1aa80280d36b8411d252286601369145224f684

commit e1aa80280d36b8411d252286601369145224f684
Author: kylechar <kylechar@chromium.org>
Date: Thu Jul 12 00:50:02 2018

Revert "Updating Viz Content BrowserTests Filter"

This reverts commit a57a12587f7ace3b15480262c181ced968346ea4.

Reason for revert: SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest is failing.

Original change's description:
> Updating Viz Content BrowserTests Filter
> 
> A few tests have been fixed. This updates the filter accordingly to re-enable them.
> 
> TEST=SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest
> SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF
> Bug:  848825 ,  848348 
> 
> Change-Id: If05696e57dfee18cc6ae06c21f7d968982c31219
> Reviewed-on: https://chromium-review.googlesource.com/1133863
> Reviewed-by: Jonathan Ross <jonross@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574302}

TBR=jonross@chromium.org,kylechar@chromium.org

Change-Id: Ic6de880ae04a3535c00bfab1cf39e61a335fe43e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  848825 ,  848348 
Reviewed-on: https://chromium-review.googlesource.com/1134144
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574434}
[modify] https://crrev.com/e1aa80280d36b8411d252286601369145224f684/testing/buildbot/filters/viz.android.content_browsertests.filter
[modify] https://crrev.com/e1aa80280d36b8411d252286601369145224f684/testing/buildbot/filters/viz.content_browsertests.filter

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e0d4f50a43ad0ec12342ccbd16bf63f571651a7

commit 9e0d4f50a43ad0ec12342ccbd16bf63f571651a7
Author: kylechar <kylechar@chromium.org>
Date: Thu Jul 12 15:43:27 2018

Update viz_content_browsertests filter.

Undo revert in https://crrev.com/c/1134144 which didn't end up being
needed. Revert was in response to FindIt and failures in
SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest but that problem
had already been addressed.

TBR: jonross@chromium.org
Bug:  848825 ,  848348 
Change-Id: Ie00ce45db8b380847dddf4fb099a120ce7ada987
Reviewed-on: https://chromium-review.googlesource.com/1135146
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574572}
[modify] https://crrev.com/9e0d4f50a43ad0ec12342ccbd16bf63f571651a7/testing/buildbot/filters/viz.android.content_browsertests.filter
[modify] https://crrev.com/9e0d4f50a43ad0ec12342ccbd16bf63f571651a7/testing/buildbot/filters/viz.content_browsertests.filter

Owner: riajiang@chromium.org
These tests are failing for the same reason as SitePerProcessHitTestBrowserTest.RootConsumesScrollDuringOverscrollGesture, I have a CL that can fix both
Status: Fixed (was: Assigned)
This was fixed in: https://chromium-review.googlesource.com/c/chromium/src/+/1139088

Sign in to add a comment