New issue
Advanced search Search tips

Issue 848334 link

Starred by 2 users
Status: Fixed
Owner:
dtapu...@chromium.org
Closed: Aug 29
Cc:
cbiesin...@chromium.org
robertma@chromium.org
foolip@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: ----
Type: ----



Sign in to add a comment

[WPT] external/wpt/fullscreen/api/document-exit-fullscreen-nested-in-iframe-manual.html is flaky

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, May 31 2018 
WPT import https://crrev.com/c/1080405 introduced new failures in external/wpt/fullscreen:

List of new failures:
[ Win10 ] external/wpt/fullscreen/api/document-exit-fullscreen-nested-in-iframe-manual.html [ Skip ]

This import contains upstream changes from 219ed4510789fff5d1efddced703bd0289348636 to 89dc77674112c00ac5b513b7cdce68a341019f85:
HTML: Test hidden attribute on table elements (#11264): https://github.com/web-platform-tests/wpt/commit/89dc77674112c00ac5b513b7cdce68a341019f85
Refactor and split up with `variant` all encoding tests: https://github.com/web-platform-tests/wpt/commit/d6c29bef8d4bcdfe4f689defca73360b07647d71
Test caption: https://github.com/web-platform-tests/wpt/commit/a4536a7a14b1619731356a4a6979b80ba6a7e49e
HTML: Test hidden attribute on table elements: https://github.com/web-platform-tests/wpt/commit/952020200ea86ffe879c84a6c9407b869d899549

Comment 1 by robertma@chromium.org, May 31 2018 

The test timed out on win10_blink_rel:

https://test-results.appspot.com/data/layout_results/win10_blink_rel/7418/layout-test-results/results.html

It could be a flake. Philip, can you take a look?

Comment 2 by robertma@chromium.org, May 31 2018

Labels: OS-Windows

Comment 3 by e...@chromium.org, May 31 2018

Cc: cbiesin...@chromium.org
Status: Available (was: Untriaged)

Comment 4 by robertma@chromium.org, Jun 1 2018 

 Issue 848526  has been merged into this issue.

Comment 5 by foolip@chromium.org, Jun 1 2018

Summary: [WPT] external/wpt/fullscreen/api/document-exit-fullscreen-nested-in-iframe-manual.html is flaky (was: [WPT] New failures introduced in external/wpt/fullscreen by import https://crrev.com/c/1080405)
Looks like this test is fairly flaky on many platforms:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Ffullscreen%2Fapi%2Fdocument-exit-fullscreen-nested-in-iframe-manual.html
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af3665cf4c073fc412c4a37a6ce05570a6222985

commit af3665cf4c073fc412c4a37a6ce05570a6222985
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Fri Jun 01 17:38:48 2018

Mark document-exit-fullscreen-nested-in-iframe-manual.html as flaky

Bug:  848334 
Change-Id: I796ab96eb63d035256a9666098d0fed4e778716f
Reviewed-on: https://chromium-review.googlesource.com/1082538
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563707}
[modify] https://crrev.com/af3665cf4c073fc412c4a37a6ce05570a6222985/third_party/WebKit/LayoutTests/TestExpectations

Comment 7 by dtapu...@chromium.org, Aug 27 

 Issue 700387  has been merged into this issue.

Comment 8 by dtapu...@chromium.org, Aug 28

Owner: dtapu...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d74005b9cdae4ed4d27848c4d0dad8c74005ef7b

commit d74005b9cdae4ed4d27848c4d0dad8c74005ef7b
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Aug 29 14:09:32 2018

Remove document-exit-fullscreen-nested-in-iframe-manual.html

It appears that this test doesn't show up as flaky test anymore so
remove the test expectation.

BUG= 848334 

Change-Id: I85e6d6cd7bcf700113fa53bd78dac2322c4869a2
Reviewed-on: https://chromium-review.googlesource.com/1194489
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587101}
[modify] https://crrev.com/d74005b9cdae4ed4d27848c4d0dad8c74005ef7b/third_party/WebKit/LayoutTests/TestExpectations

Comment 10 by dtapu...@chromium.org, Aug 29

Status: Fixed (was: Assigned)
►

Sign in to add a comment