SitePerProcessHitTestBrowserTest.RootConsumesScrollDuringOverscrollGesture Fails in Viz |
|||||
Issue description
OS: Linux
Test suite: content_browsertests
Test:-SitePerProcessHitTestBrowserTest.RootConsumesScrollDuringOverscrollGesture*
I'm working on a patch which provides a hit testing api, so that this test can be ran in Viz (--enable-features=VizDisplayCompositor)
However when this occurs the test uncovers an error in both /1 and /2 variants:
content/browser/site_per_process_hit_test_browsertest.cc:1070: Failure
Expected equality of these values:
rwhv_child->GetRenderWidgetHost()
Which is: 0x1d66a9117600
router->GetRenderWidgetHostAtPoint(rwhv_root, point_in_child, &dont_care)
Which is: 0x1d66a8f4e000
Stack trace:
#0 0x000000bd2a8c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x000000bd2469 testing::internal::AssertHelper::operator=()
#2 0x0000009f5a19 content::SitePerProcessHitTestBrowserTest_RootConsumesScrollDuringOverscrollGesture_Test::RunTestOnMainThread()
#3 0x000000cdc2ee content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#4 0x000000d74816 content::ShellBrowserMainParts::PreMainMessageLoopRun()
#5 0x7fd4cf669491 content::BrowserMainLoop::PreMainMessageLoopRun()
#6 0x7fd4cfb5adc5 content::StartupTaskRunner::RunAllTasksNow()
#7 0x7fd4cf667bec content::BrowserMainLoop::CreateStartupTasks()
#8 0x7fd4cf66c295 content::BrowserMainRunnerImpl::Initialize()
#9 0x7fd4cf66c1f7 content::BrowserMainRunnerImpl::Initialize()
#10 0x000000d73ffd ShellBrowserMain()
#11 0x000000d28c5d content::ShellMainDelegate::RunProcess()
#12 0x7fd4d01273a3 content::RunBrowserProcessMain()
#13 0x7fd4d01284a4 content::ContentMainRunnerImpl::Run()
#14 0x7fd4cd1ad6bf service_manager::Main()
#15 0x7fd4d0126294 content::ContentMain()
#16 0x000000cdbe52 content::BrowserTestBase::SetUp()
#17 0x000000cd0fc4 content::ContentBrowserTest::SetUp()
,
Jun 22 2018
,
Jun 22 2018
,
Jul 10
sunxd@, have you started on this? I have some cycles now so let me know if you want me to take this :)
,
Jul 11
Sorry no, it would be great if you can take on this as I do not have much knowledge about the underlying test.
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a26a8b8af90fde922e9eac9cec747d6160b5c9ef commit a26a8b8af90fde922e9eac9cec747d6160b5c9ef Author: Ria Jiang <riajiang@chromium.org> Date: Fri Jul 20 01:26:31 2018 Get page-scale-factor from RenderFrameMetadata in hit-testing tests. Some SitePerProcessHitTestBrowserTest are failing with feature VizDisplayCompositor turned on. This is because the current way of getting the page-scale-factor of the last frame doesn't work with VizDisplayCompositor - VizDisplayCompositor doesn't use RenderWidgetHostImpl::SubmitCompositorFrame so last_frame_metadata_ is never set. This CL updates those tests to use RenderFrameSubmissionObserver to get the last RenderFrameMetadata. Bug: 848325 , 848325 Change-Id: Ic20e6c4a591dbc7c3c499869910b4f342b99c3cb Reviewed-on: https://chromium-review.googlesource.com/1139088 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#576748} [modify] https://crrev.com/a26a8b8af90fde922e9eac9cec747d6160b5c9ef/content/browser/site_per_process_hit_test_browsertest.cc [modify] https://crrev.com/a26a8b8af90fde922e9eac9cec747d6160b5c9ef/testing/buildbot/filters/viz.content_browsertests.filter
,
Jul 20
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jonr...@chromium.org
, Jun 21 2018