New issue
Advanced search Search tips

Issue 848320 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Fix "undefined" with "Hardware Protected Video Decode" in Graphics Feature Status of the Chrome://gpu page

Project Member Reported by magchen@chromium.org, May 31 2018

Issue description

Chrome Version: (copy from chrome://version)
OS: All

What steps will reproduce the problem?
(1)go to Chrome://gpu 
(2)Check "Graphics Feature Status" 
(3)One item in the bullet list shows "undefined"

What is the expected result?
It should be "Hardware Protected Video Decode" : ....

What happens instead?
It shows "undefined".


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
Description: Show this description
Summary: Fix "undefined" with "Hardware Protected Video Decode" in Graphics Feature Status of the Chrome://gpu page (was: Fix "undefined" with "HW Protected Video" in Graphics Feature Status of the Chrome://gpu page)
Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25796e1d3bd16ba510bf2c8e4b3eb8b1d86dd0cf

commit 25796e1d3bd16ba510bf2c8e4b3eb8b1d86dd0cf
Author: Maggie Chen <magchen@chromium.org>
Date: Thu May 31 17:14:00 2018

Fix "undefined" in Graphics Feature Status of the Chrome://gpu page

Add 'Hardware Protected Video Decode' to the featureLabelMap in
info_view.js. So "Hardware Protected Video Decode" will be listed in the
Graphics Feature Status instead of "undefined"

Bug:  848320 
Change-Id: Ia53936dbad441cdc42fa527111f0546d5b627608
Reviewed-on: https://chromium-review.googlesource.com/1080993
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563289}
[modify] https://crrev.com/25796e1d3bd16ba510bf2c8e4b3eb8b1d86dd0cf/content/browser/resources/gpu/info_view.js

Comment 4 by zmo@chromium.org, May 31 2018

Labels: M-68 Merge-Request-68
Status: Fixed (was: Untriaged)
This is a one-liner fix.
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 1 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 1 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7759c30e7eec5c8e6f345e5ba96b2ee5abecc52

commit f7759c30e7eec5c8e6f345e5ba96b2ee5abecc52
Author: Maggie Chen <magchen@chromium.org>
Date: Fri Jun 01 17:39:12 2018

Fix "undefined" in Graphics Feature Status of the Chrome://gpu page

Add 'Hardware Protected Video Decode' to the featureLabelMap in
info_view.js. So "Hardware Protected Video Decode" will be listed in the
Graphics Feature Status instead of "undefined"

Bug:  848320 
Change-Id: Ia53936dbad441cdc42fa527111f0546d5b627608
Reviewed-on: https://chromium-review.googlesource.com/1080993
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563289}(cherry picked from commit 25796e1d3bd16ba510bf2c8e4b3eb8b1d86dd0cf)
Reviewed-on: https://chromium-review.googlesource.com/1081855
Cr-Commit-Position: refs/branch-heads/3440@{#90}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/f7759c30e7eec5c8e6f345e5ba96b2ee5abecc52/content/browser/resources/gpu/info_view.js

Cc: phanindra.mandapaka@chromium.org
Labels: TE-Verified-69.0.3450.0 TE-Verified-M69
Able to reproduce the issue on chrome version 69.0.3446.0 (build withtout fix)
Verified the fix on Ubuntu 17.10,Windows10 and Mac 10.13.3 using Chrome version #69.0.3450.0 as per the comment #0.
Attaching screecast for reference.
Observed that Chrome://gpu updated with ""Hardware Protected Video Decode.""
The fix is working as expected, adding Verified labels

Thanks...!
848320.mp4
1.9 MB View Download
Status: Verified (was: Fixed)

Sign in to add a comment