New issue
Advanced search Search tips

Issue 848317 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 678128



Sign in to add a comment

Strings/localization for Touch ID WebAuthn authenticator

Project Member Reported by martinkr@google.com, May 31 2018

Issue description

remove placeholders and get actual strings
 
Labels: Hotlist-WebAuthnUI
Labels: -Pri-3 Pri-1
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7

commit 2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7
Author: Martin Kreichgauer <martinkr@google.com>
Date: Mon Aug 13 18:02:31 2018

fido/mac: localize Touch ID prompt strings

This adds localization for the reason string fragments used in macOS
Touch ID prompts.

The prompts display a message starting with '"Google Chrome" is trying
to ' (controlled by macOS) followed by the reason fragment (controlled
by us). The user can confirm the prompt by providing their fingerprint,
or click cancel.

Bug:  848317 
Change-Id: Ibe67c197554cde0af431516d968479b0f416629e
Reviewed-on: https://chromium-review.googlesource.com/1166171
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582637}
[modify] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/chrome/chrome_repack_locales.gni
[modify] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/BUILD.gn
[modify] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/DEPS
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/fido_strings.grd
[modify] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/mac/fake_touch_id_context.h
[modify] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/mac/fake_touch_id_context.mm
[modify] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/mac/get_assertion_operation.mm
[modify] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/mac/make_credential_operation.mm
[modify] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/mac/operation_base.h
[modify] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/mac/touch_id_context.h
[modify] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/mac/touch_id_context.mm
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/BUILD.gn
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_am.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_ar.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_bg.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_bn.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_ca.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_cs.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_da.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_de.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_el.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_en-GB.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_es-419.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_es.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_et.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_fa.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_fi.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_fil.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_fr.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_gu.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_hi.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_hr.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_hu.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_id.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_it.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_iw.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_ja.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_kn.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_ko.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_lt.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_lv.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_ml.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_mr.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_ms.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_nl.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_no.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_pl.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_pt-BR.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_pt-PT.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_ro.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_ru.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_sk.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_sl.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_sr.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_sv.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_sw.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_ta.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_te.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_th.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_tr.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_uk.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_vi.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_zh-CN.xtb
[add] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/device/fido/strings/fido_strings_zh-TW.xtb
[modify] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/tools/check_grd_for_unused_strings.py
[modify] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/tools/gritsettings/resource_ids
[modify] https://crrev.com/2d30db4e8857765e932b6f28a0a97ac6f3e1e8d7/tools/gritsettings/translation_expectations.pyl

Status: Fixed (was: Started)

Sign in to add a comment