New issue
Advanced search Search tips

Issue 848300 link

Starred by 3 users
Status: Fixed
Owner:
bsep@chromium.org
Closed: Jun 2018
Cc:
pbos@chromium.org
ellyjo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

ToolbarButton (extension icon, avatar button) menus don't hide with 2nd click

Project Member Reported by meh...@chromium.org, May 31 2018 
Chrome Version: 69.0.3446.0
OS: macOS but probably OS=All

What steps will reproduce the problem?
(0) Enable MD-Refresh
(1) Install e.g. Adblock from https://chrome.google.com/webstore/detail/adblock/gighmmpiobklfepjocnamgkkbiglidom
(2) Click on the extension icon on the Toolbar, so that its menu appears
(3) Click again on the extension icon on the Toolbar, so that its menu disappears


What is the expected result?
The menu should hide.

What happens instead?
The menu doesn't hide.

A screencast is attached.

Thanks,
Mehmet
Extension_Icon_Menu.mov
889 KB View Download

Comment 1 by pbos@chromium.org, May 31 2018

Cc: bsep@chromium.org
Labels: -Proj-MdRefresh
Summary: Extension icon menu doesn't hide with 2nd click (was: [MdRefresh] Extension icon menu doesn't hide with 2nd click)
Doesn't seem to be related to MdRefresh on Windows at least. If it's related to MdRefresh on Mac please add the labels again.

On my end it seems to be racy, if you click the icon very quickly the menu hides, if you hold it the menu goes away but reappears when you release later. No idea if this is OS dependent.

I've no idea what fixing this would entail.

Comment 2 by pbos@chromium.org, May 31 2018

Cc: ellyjo...@chromium.org
+cc ellyjones@ in case this is interesting to MacViews for some reason.

Comment 3 by pbos@chromium.org, May 31 2018 

 Issue 848304  has been merged into this issue.

Comment 4 by pbos@chromium.org, May 31 2018

Summary: ToolbarButton (extension icon, avatar button) menus don't hide with 2nd click (was: Extension icon menu doesn't hide with 2nd click)
ToolbarActionView and AvatarToolbarButton both inherit from ToolbarButton which is a MenuButton. These are probably the same root cause at least.

Comment 5 by meh...@chromium.org, May 31 2018 

Thanks for your feedback. Yes I see this with the Extension Menu also on MacViews, but just like as you've described it in your c#1.

Comment 6 by meh...@chromium.org, May 31 2018 

This is the regression range at least for the extension menu under MDRefresh on macOS:

https://chromium.googlesource.com/chromium/src/+/8cd88c77b560468f1d41938f8d653fd0a22c4232

Comment 8 by meh...@chromium.org, Jun 11 2018 

Seems to be fixed for the Avatar button now - probably with  issue 849911 .

Would be nice, if it could be fixed for the Extension buttons as well :-)

Thanks in advance.

Comment 9 by pbos@chromium.org, Jun 11 2018 

Honestly it's kind of wonky. :(

Comment #4 of mine is wrong, none of these are MenuButtons so they don't handle click events like menu buttons do but rather ad-hoc. The extension buttons can't use the same behavior as the other ToolbarButtons as the extensions are draggable we can't trigger on-click.

Fixing this properly hopefully involves making these buttons MenuButtons or otherwise adopting the same logic somehow instead of trying to ad-hoc mimic it.

Comment 10 by meh...@chromium.org, Jun 13 2018 

Hi pbos@, in #566950 the issue with the second click is fixed for the extension buttons. Not sure but maybe fixed by the revert from https://bugs.chromium.org/p/chromium/issues/detail?id=822075#c16 ?

Comment 12 by bsep@chromium.org, Jun 13 2018

Cc: -bsep@chromium.org
Owner: bsep@chromium.org
Status: Fixed (was: Untriaged)
Yes, this is fixed with that revert. I just couldn't find this bug :)

Comment 13 by meh...@chromium.org, Jun 13 2018 

Okay. Thanks for your feedback, bsep@ :)
►

Sign in to add a comment