macviews: use round focus rings for round topchrome items |
||||
Issue descriptionThese items should have round focus rings: * The new tab button * The back/forward/reload button * The profile switcher * The app menu * The security chip The new tab button should not use the dashed focus ring it has right now.
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7682a8f7db28e76c21fbe5fb426dde16bfbaaddc commit 7682a8f7db28e76c21fbe5fb426dde16bfbaaddc Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu May 31 16:58:35 2018 macviews: add focus ring to refresh new tab button The refresh new tab button (the plus) should not use the default dashed focus painter. A rounded focus ring looks good here. Bug: 848299 Change-Id: I8a081886bab7e0613ba30f4b6bb704d548570277 Reviewed-on: https://chromium-review.googlesource.com/1080887 Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#563273} [modify] https://crrev.com/7682a8f7db28e76c21fbe5fb426dde16bfbaaddc/chrome/browser/ui/views/tabs/new_tab_button.cc [modify] https://crrev.com/7682a8f7db28e76c21fbe5fb426dde16bfbaaddc/chrome/browser/ui/views/tabs/new_tab_button.h
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c441be53b68a03b7b72ff112a0744038f5959e85 commit c441be53b68a03b7b72ff112a0744038f5959e85 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Jun 04 14:31:40 2018 macviews: use oval focus rings for ToolbarButtons Bug: 848299 Change-Id: I6921e27689b9f80d027e6f1984f9aa173d2f549a Reviewed-on: https://chromium-review.googlesource.com/1081049 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#564083} [modify] https://crrev.com/c441be53b68a03b7b72ff112a0744038f5959e85/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/c441be53b68a03b7b72ff112a0744038f5959e85/chrome/browser/ui/views/toolbar/toolbar_button.h [modify] https://crrev.com/c441be53b68a03b7b72ff112a0744038f5959e85/ui/views/controls/button/button.h [modify] https://crrev.com/c441be53b68a03b7b72ff112a0744038f5959e85/ui/views/controls/focus_ring.cc [modify] https://crrev.com/c441be53b68a03b7b72ff112a0744038f5959e85/ui/views/controls/focus_ring.h
,
Jun 5 2018
Tested the issue on latest chrome version 69.0.3450.0 using Mac 10.12.6 with steps mentioned below: 1) Launched chrome reported version and enabled 'Refresh' and 'Mac views' flags in chrome flags 2) Opened one secure site and pressed Tab button to switch the focus, observed round focus on 'New Tab button', 'Forward/Back/Reload button', 'Profile switches' and 'App Menu' but round focus is not seen on 'Secure Chip' @Elly Fong-Jones: Please find the attached screencast for your reference and help us in confirming the fix. Thanks!
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9cf0d0676d512c201d9c53017788bcaedeadc6d commit d9cf0d0676d512c201d9c53017788bcaedeadc6d Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Jun 07 16:09:27 2018 macviews: use rounded focus rings for omnibox buttons This change adds rounded focus rings to the location icon button and to page action buttons. Bug: 848299 Change-Id: I06b501b664315ad615d334fee23149854550bd06 Reviewed-on: https://chromium-review.googlesource.com/1080889 Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#565286} [modify] https://crrev.com/d9cf0d0676d512c201d9c53017788bcaedeadc6d/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0c4aeac1add95b255d9adaa583969b6dc88eb7c commit a0c4aeac1add95b255d9adaa583969b6dc88eb7c Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri Jun 08 17:43:06 2018 views: support focus rings on tab-close buttons This change: 1) Adds focus rings to the tab-close button 2) Moves the new tab button to last in the TabStrip's focus order if it is not in LEADING position so that the keyboard focus order within the TabStrip is correct Positioning the ring for the tab-close button requires some finesse: the tab close button has its margins adjusted, but the focus ring only needs to draw around the visible part of the button. Bug: 848299 Change-Id: I226683d3a8829f5a88e9bf102b4c8ba4ecfae459 Reviewed-on: https://chromium-review.googlesource.com/1091131 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#565673} [modify] https://crrev.com/a0c4aeac1add95b255d9adaa583969b6dc88eb7c/chrome/browser/ui/views/tabs/tab.cc [modify] https://crrev.com/a0c4aeac1add95b255d9adaa583969b6dc88eb7c/chrome/browser/ui/views/tabs/tab_close_button.cc [modify] https://crrev.com/a0c4aeac1add95b255d9adaa583969b6dc88eb7c/chrome/browser/ui/views/tabs/tab_close_button.h [modify] https://crrev.com/a0c4aeac1add95b255d9adaa583969b6dc88eb7c/chrome/browser/ui/views/tabs/tab_strip.cc
,
Jun 11 2018
,
Jul 16
Able to reproduce the issue on chrome reported version 69.0.3450.0(Build without fix) Verified the fix on Mac 10.12.6 on Chrome version #69.0.3493.0 as per the comment#0 Attaching screen cast for reference. Observed "The round focus on 'New Tab button', 'Forward/Back/Reload button', 'Profile switches', 'App Menu' and 'Secure Chip'" Hence, the fix is working as expected. Adding the verified label. Thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by ellyjo...@chromium.org
, May 31 201826.0 KB
26.0 KB View Download