This is a regression in M67 and doesn't seem to be related to the refactoring for the new Autofill dropdown.

Krishna, can you please confirm if this is a release blocker? Is it possible to bisect? Please reassign it to me or to the author of the CL that introduced the regression if possible.

Only a few CLs touched c/b/ui/views/autofill between those versions:
 - https://chromium.googlesource.com/chromium/src/+/b8775569edf869fd6e7912d9e4e7cbc9e70db636
 - https://chromium.googlesource.com/chromium/src/+/4c911878210d4b9b567f20db91bc7a90ffb4a3ce

But the problem can be somewhere else, since a11y events are still working on Windows.

We're already in Beta for Chrome OS 67.  Those CLs were introduced a while ago and would already be pushed beta.   

I'd like to remove the RBB and leave as RBS so we can proceed with a pending beta push.  Fair?

kbleicher@: it's a beta release blocker for M68. Not sure how to set labels to indicate it RBS for one MS and RBB for another MS.

Per #5, the labels don't support that differentiation.  Good to include in the text.  Thanks!

Removing beta blocker for now, will bring it back once we fix for M67.

Assigning to kbleicher@ (Chrome OS M67 TPM), ptal comment #2 and reassign if needed. Thank you.

Assigning back to  ftirelo@ that's working to bisect and help to identify owner(s)

I think that I found the culprit: https://chromium.googlesource.com/chromium/src/+/84d400ad83a8c81d29db85700573adcdeea34b1b

aleventhal@: Can you please confirm?

Last Canary without the issue:  67 .0.3362.0
First Canary with the issue:  67 .0.3363.0

Thanks songsuk@ for helping bisect and confirm the issue! She installed both canary versions and confirmed the issue was introduced by 67.0.3363.0.

Notes: Unfortunately, the bisect tool doesn't work for ChromeOS, and we needed bisect manually. In addition, there was a crash in the sign in page introduced in 67.0.3363.0, so at some point I needed to checkout to 67.0.3364.0 and revert and test each potential culprit (I was lucky it worked on the second one I tried).

Some annotations that may be useful for people debugging it:

1. Remove "chromeos" from your target list in .gclient in case it's there (it changed recently, and the regression was introduced before that).

2. Create a GN config for ChromeOS:

  $ gn args out/cros

in the editor, add:

  target_os = "chromeos"
  is_component_build = true
  is_debug = true
  use_goma = true

2. Go to a revision with the issue.

  $ git co 67.0.3364.0   # Unfortunately, there is a sign in page crash in 67.0.3363.0
  $ gclient sync
  $ gn gen out/cros 
  $ autoninja -C out/cros chrome && out/cros/chrome --login-manager

3. Follow the instructions to reproduce the error per comment #1. ChromeVOX will not read the suggestions.

4. Revert the culprit and test again. ChromeVOX will not read the suggestions.

  $ git revert 84d400ad83a8c81d29db85700573adcdeea34b1b
  $ autoninja -C out/cros chrome && out/cros/chrome --login-manager

Correction on #11: 

4. Revert the culprit and test again. ChromeVOX *will read* the suggestions.

 ftirelo@, have you been able to confirm the culprit, and will you / team be able to get a tested merge request in soon?

kbleicher@: Yes, confirmed. songsuk@ confirmed that it first happened on 67.0.3363.0, and I confirmed that:
 - checking out to 67.0.3364.0 -> broken
 - reverting the CL -> fixed

Per IM testing is ongoing; expect to have merge request in time for build (assuming no issues found)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccc90b0f9fe600a119c3a592df18c1b28655c3c1

commit ccc90b0f9fe600a119c3a592df18c1b28655c3c1
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Mon Jun 04 19:54:59 2018

Restore selection events for autofill popup menu

In a menu, ChromeVox expects selection events, not focus events. Other
screen readers can use either type events. Therefore, we should revert
to using selection events in the Autofill popup.

TBR=estade@chromium.org

Bug:  848297 
Change-Id: I8642a6b1889ae05972b71009a3f7df3f422ec02d
Reviewed-on: https://chromium-review.googlesource.com/1085273
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564196}
[modify] https://crrev.com/ccc90b0f9fe600a119c3a592df18c1b28655c3c1/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
[modify] https://crrev.com/ccc90b0f9fe600a119c3a592df18c1b28655c3c1/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc

This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Can you add details for testing results?   I'll approve the merge from there.  Thanks

I was only able to test with NVDA and JAWS to ensure this did not regress anything there. Fabio did the testing with ChromeVox.

The Chrome PFQ succeeded last night so I'm good with the merge request / approval given that this was tested in the simulated environment.  Please merge to M67 this morning so I can get a chrome / chrome os built with time for testing.  Thanks

Approving Merge for M67 Chrome OS

Reverting the M67 merge approval as testing seems to have failed.

This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Okay, after review with Aaron I'm going to re-approve; apologies for the noise of #23.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76e4e11cf69157d26404d382667d06f8c1e731b0

commit 76e4e11cf69157d26404d382667d06f8c1e731b0
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Tue Jun 05 17:50:13 2018

Restore selection events for autofill popup menu

In a menu, ChromeVox expects selection events, not focus events. Other
screen readers can use either type events. Therefore, we should revert
to using selection events in the Autofill popup.

TBR=aleventhal@chromium.org

(cherry picked from commit ccc90b0f9fe600a119c3a592df18c1b28655c3c1)

Bug:  848297 
Change-Id: I8642a6b1889ae05972b71009a3f7df3f422ec02d
Reviewed-on: https://chromium-review.googlesource.com/1085273
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#564196}
Reviewed-on: https://chromium-review.googlesource.com/1087411
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#750}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/76e4e11cf69157d26404d382667d06f8c1e731b0/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc

Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ebf63f9a02a5987438da393091a717595fd1dd1

commit 5ebf63f9a02a5987438da393091a717595fd1dd1
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Tue Jun 05 20:28:31 2018

Restore selection events for autofill popup menu

In a menu, ChromeVox expects selection events, not focus events. Other
screen readers can use either type events. Therefore, we should revert
to using selection events in the Autofill popup.

TBR=estade@chromium.org

Bug:  848297 
Change-Id: I8642a6b1889ae05972b71009a3f7df3f422ec02d
Reviewed-on: https://chromium-review.googlesource.com/1085273
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#564196}(cherry picked from commit ccc90b0f9fe600a119c3a592df18c1b28655c3c1)
Reviewed-on: https://chromium-review.googlesource.com/1087687
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#192}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/5ebf63f9a02a5987438da393091a717595fd1dd1/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
[modify] https://crrev.com/5ebf63f9a02a5987438da393091a717595fd1dd1/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc

Can we tag this as fixed to remove it from the RBS lists at push time?  You can tag it as verified after further review.  Thanks :-)

Verified the fix on Chrome 10575.55.0/ 67.0.3396.87 - Peppy, Paine
Chrome 68.0.3440.22/10718.19.0 - Minnie