New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848292 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Aug 6
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

57.4% regression in scheduler.tough_scheduling_cases at 562668:562744

Project Member Reported by sullivan@chromium.org, May 31 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, May 31 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=848292

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=14a85b5fef124163f0f0b592456a0d424c73a537f74e34106e50f85adc771666


Bot(s) for this bug's original alert(s):

android-nexus5X
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 31 2018

Cc: fsam...@chromium.org
Owner: fsam...@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14e4d016240000

Surface Sychronization: Clean-up DelegatedFrameHostAndroid by fsamuel@chromium.org
https://chromium.googlesource.com/chromium/src/+/dba483cee6a5f15e2e2d73df16968ab10b38a2bf
20.91 → 31.98 (+11.07)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Labels: OS-Android
Cc: pmeenan@chromium.org
 Issue 848775  has been merged into this issue.
 Issue 848776  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1a9e88d8e5e7cbe5945790e2a135125a756f97b

commit f1a9e88d8e5e7cbe5945790e2a135125a756f97b
Author: Fady Samuel <fsamuel@chromium.org>
Date: Mon Jul 16 20:28:24 2018

Surface Synchronization: Only defer commits if frame exists

Right now, with surface sync off on Android, we will defer commits
any time there's a size change, even if we've evicted the current
surface.

Change-Id: I7e1ae394e20eef2a46bca5ae9a8fc8a4cdf35e0b
Bug:  848292 ,  672962 
Reviewed-on: https://chromium-review.googlesource.com/1121098
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575405}
[modify] https://crrev.com/f1a9e88d8e5e7cbe5945790e2a135125a756f97b/ui/android/delegated_frame_host_android.cc

Cc: -pmeenan@chromium.org
Status: WontFix (was: Assigned)
I believe this should now be fixed but with all the shuffles in test names, I cannot verify, so I'm marking as WontFix. If it's still regressed we can reopen or a new bug will be filed.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90dea8d48077f7dad685dd0bb1d9ce60135039e6

commit 90dea8d48077f7dad685dd0bb1d9ce60135039e6
Author: Fady Samuel <fsamuel@chromium.org>
Date: Thu Aug 16 02:29:54 2018

Revert "Surface Synchronization: Only defer commits if frame exists"

This reverts commit f1a9e88d8e5e7cbe5945790e2a135125a756f97b.

Reason for revert: crbug.com/868605

Original change's description:
> Surface Synchronization: Only defer commits if frame exists
> 
> Right now, with surface sync off on Android, we will defer commits
> any time there's a size change, even if we've evicted the current
> surface.
> 
> Change-Id: I7e1ae394e20eef2a46bca5ae9a8fc8a4cdf35e0b
> Bug:  848292 ,  672962 
> Reviewed-on: https://chromium-review.googlesource.com/1121098
> Reviewed-by: Saman Sami <samans@chromium.org>
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Commit-Queue: Fady Samuel <fsamuel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575405}

TBR=fsamuel@chromium.org,khushalsagar@chromium.org,samans@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  848292 ,  672962 
Change-Id: Ie558844df649cea7f3560f61d7077907e73e20a9
Reviewed-on: https://chromium-review.googlesource.com/1176761
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583508}
[modify] https://crrev.com/90dea8d48077f7dad685dd0bb1d9ce60135039e6/ui/android/delegated_frame_host_android.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 20

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01f5bfbf492aa7d9ca153b394e5fb4d457c1fc57

commit 01f5bfbf492aa7d9ca153b394e5fb4d457c1fc57
Author: Fady Samuel <fsamuel@chromium.org>
Date: Mon Aug 20 22:04:22 2018

Revert "Surface Synchronization: Only defer commits if frame exists"

This reverts commit f1a9e88d8e5e7cbe5945790e2a135125a756f97b.

Reason for revert: crbug.com/868605

Original change's description:
> Surface Synchronization: Only defer commits if frame exists
> 
> Right now, with surface sync off on Android, we will defer commits
> any time there's a size change, even if we've evicted the current
> surface.
> 
> Change-Id: I7e1ae394e20eef2a46bca5ae9a8fc8a4cdf35e0b
> Bug:  848292 ,  672962 
> Reviewed-on: https://chromium-review.googlesource.com/1121098
> Reviewed-by: Saman Sami <samans@chromium.org>
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Commit-Queue: Fady Samuel <fsamuel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575405}

TBR=fsamuel@chromium.org,khushalsagar@chromium.org,samans@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  848292 ,  672962 
Change-Id: Ie558844df649cea7f3560f61d7077907e73e20a9
Reviewed-on: https://chromium-review.googlesource.com/1176761
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#583508}(cherry picked from commit 90dea8d48077f7dad685dd0bb1d9ce60135039e6)
Reviewed-on: https://chromium-review.googlesource.com/1182206
Cr-Commit-Position: refs/branch-heads/3497@{#726}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/01f5bfbf492aa7d9ca153b394e5fb4d457c1fc57/ui/android/delegated_frame_host_android.cc

Sign in to add a comment