New issue
Advanced search Search tips

Issue 848271 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-06
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 836817



Sign in to add a comment

Update fullscreen toolbar

Project Member Reported by pschaffner@chromium.org, May 31 2018

Issue description

Fullscreen toolbar height: 30pt, accounting for and sitting below status bar (if present ... which it isn't in Any x Compact)
 
Blocking: 836817
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10781354a082c98fa741b53665344b84b203ab01

commit 10781354a082c98fa741b53665344b84b203ab01
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Jun 01 10:20:52 2018

Increase toolbar height in fullscreen to 30pt

Bug:  848271 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie1fab9a63e1b7ca442d3dd7c938c28205128e434
Reviewed-on: https://chromium-review.googlesource.com/1082273
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563578}
[modify] https://crrev.com/10781354a082c98fa741b53665344b84b203ab01/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm

Status: Fixed (was: Assigned)
NextAction: 2018-06-06
The NextAction date has arrived: 2018-06-06

Sign in to add a comment