New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848270 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Picture-in-Picture: do not pause playback when exiting from API

Project Member Reported by mlamouri@chromium.org, May 31 2018

Issue description

Leaving PIP from the API shouldn't change the state of the video playback.
 
Is it the same as  Issue 847845 ?
Owner: fbeaufort@chromium.org
And You're right. My name is Dory :)
Cc: fbeaufort@chromium.org
 Issue 847845  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f68821d3be6513022c5b2c205bd122958321c546

commit f68821d3be6513022c5b2c205bd122958321c546
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Tue Jun 05 14:57:08 2018

[Picture-in-Picture] Do not pause playback when exiting from API.

This CL makes sure that PiP video is paused only when user interacts
with the PiP window. If it comes from the API, video should NOT pause.

Bug:  848270 ,  806249 
Change-Id: Id09dffce15ff4b99c24dd53696f5715d76937f9e
Reviewed-on: https://chromium-review.googlesource.com/1082274
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#564496}
[modify] https://crrev.com/f68821d3be6513022c5b2c205bd122958321c546/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/f68821d3be6513022c5b2c205bd122958321c546/chrome/browser/ui/browser.cc
[modify] https://crrev.com/f68821d3be6513022c5b2c205bd122958321c546/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/f68821d3be6513022c5b2c205bd122958321c546/chrome/test/data/media/picture-in-picture/window-size.html
[modify] https://crrev.com/f68821d3be6513022c5b2c205bd122958321c546/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
[modify] https://crrev.com/f68821d3be6513022c5b2c205bd122958321c546/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.h
[modify] https://crrev.com/f68821d3be6513022c5b2c205bd122958321c546/content/public/browser/picture_in_picture_window_controller.h

Status: Verified (was: Started)
Verified in Chrome 69.0.3451.0.

Do we want to merge it in M68?
No need to merge this :)

Sign in to add a comment