New issue
Advanced search Search tips

Issue 848265 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Make a WPT test for Service-Worker header

Project Member Reported by falken@chromium.org, May 31 2018

Issue description

ServiceWorkerVersionBrowserTest.ServiceWorkerScriptHeader checks that the Service-Worker header is present on requests for a SW script. It should just be a WPT test instead.
 

Comment 1 by falken@google.com, Jun 4 2018

Owner: bashi@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b671ab2f034490e40d11709578f53158ea5355d

commit 7b671ab2f034490e40d11709578f53158ea5355d
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Mon Jun 04 08:37:11 2018

Add a WPT for Service-Worker header

The spec requires that an HTTP request to fetch a service worker
script has 'Service-Worker: script' header[1].

[1] https://w3c.github.io/ServiceWorker/#update-algorithm

Bug:  848265 
Change-Id: I76c836fcf43d287bcac910c3655e5b127ad8555c
Reviewed-on: https://chromium-review.googlesource.com/1082253
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564023}
[add] https://crrev.com/7b671ab2f034490e40d11709578f53158ea5355d/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/service-worker-header.py
[add] https://crrev.com/7b671ab2f034490e40d11709578f53158ea5355d/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/service-worker-header.https.html

Comment 3 by bashi@chromium.org, Jun 4 2018

Status: Fixed (was: Started)

Sign in to add a comment