Overscrolling on ARC++ apps is broken. |
||
Issue descriptionArcImeService observes the bounds of VK window and sends it to Android container to move up views in Android side. In the recent change(crrev.com/c/1068277), we don't destroy KeyboardController instance until ash::Shell is destroyed, but the list of observers is cleared when DisableKeyboard() is called. Then after calling DiableKeyboard() once, ArcImeService can't observe change of virtual keyboard appearance anymore.
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b120be1195044c8be06578bdec47c93e5f3011f0 commit b120be1195044c8be06578bdec47c93e5f3011f0 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Fri Jun 01 00:12:22 2018 Don't clear the observer list in KeyboardController::DisableKeyboard(). It's hard for observers of KeyboardController to watch EnableKeyboard() calling and re-add themselves to the observer list. Bug: 848249 Test: keyboard_unittests Change-Id: I18cf2cb6c2099ed82b105a463093cac0cda8dfcf Reviewed-on: https://chromium-review.googlesource.com/1080670 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#563450} [modify] https://crrev.com/b120be1195044c8be06578bdec47c93e5f3011f0/ui/keyboard/keyboard_controller.cc [modify] https://crrev.com/b120be1195044c8be06578bdec47c93e5f3011f0/ui/keyboard/keyboard_controller_unittest.cc
,
Jun 1 2018
The issue should be fixed now. I'll make a follow up CL to clean up observer registering code in ArcImeService.
,
Jun 18 2018
I think this should be fixed now right?
,
Jun 18 2018
ah, yes. I forgot to close this issue. Thanks! |
||
►
Sign in to add a comment |
||
Comment 1 by shend@chromium.org
, May 31 2018