PersonalDataManagerTest....OnlyDeleteExpiredDisusedLocalCards fails on all platforms |
|||||||
Issue descriptionDisabling for now. Will fix it later today
,
May 31 2018
It was disabled here: https://chromium-review.googlesource.com/c/chromium/src/+/1080648 Removing sheriff label
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0b61f4f81b1f6c4b3098b8ab838c3abffa5137a commit a0b61f4f81b1f6c4b3098b8ab838c3abffa5137a Author: Hui(Andy) Wu <wuandy@chromium.org> Date: Thu May 31 20:02:00 2018 [Autofill] Fix a unittest failure due to dependency to current time. A unittest fails because it is checking how long has a credit card expired. Fixing it by always setting the expiry date to a date one month earlier than current time. Bug: 848246 Change-Id: I57d142ad49d8155241f5f04da2246fee9f54b2cb Reviewed-on: https://chromium-review.googlesource.com/1081229 Commit-Queue: Hui Wu <wuandy@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#563359} [modify] https://crrev.com/a0b61f4f81b1f6c4b3098b8ab838c3abffa5137a/components/autofill/core/browser/personal_data_manager_unittest.cc
,
Jun 1 2018
Issue 848227 has been merged into this issue.
,
Jun 1 2018
,
Jun 2 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb5ef51d5fcce78cdb8e3429d4858cce6ce1b10c commit bb5ef51d5fcce78cdb8e3429d4858cce6ce1b10c Author: sebsg <sebsg@chromium.org> Date: Mon Jun 04 13:47:58 2018 Merge-68 [AF] Fix a unittest failure due to dependency to current time. A unittest fails because it is checking how long has a credit card expired. Fixing it by always setting the expiry date to a date one month earlier than current time. TBR=wuandy@chromium.org (cherry picked from commit a0b61f4f81b1f6c4b3098b8ab838c3abffa5137a) Bug: 848246 Change-Id: I57d142ad49d8155241f5f04da2246fee9f54b2cb Reviewed-on: https://chromium-review.googlesource.com/1081229 Commit-Queue: Hui Wu <wuandy@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563359} Reviewed-on: https://chromium-review.googlesource.com/1085127 Cr-Commit-Position: refs/branch-heads/3440@{#132} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/bb5ef51d5fcce78cdb8e3429d4858cce6ce1b10c/components/autofill/core/browser/personal_data_manager_unittest.cc
,
Jun 4 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by se...@chromium.org
, May 31 2018Owner: wuandy@chromium.org
Andy, since it's your test, could you please take a look? I think it's due to these lines: test::SetCreditCardInfo(&credit_card3, "Clyde", "4111111111111111" /* Visa */, "04", "2017", "1"); credit_card3.set_use_date(now - base::TimeDelta::FromDays(400)); I think the fix will need to be merged to M68 too.