New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848231 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

The direct path component in the AEC3 linear filter is sometimes wrongly estimated

Project Member Reported by peah@chromium.org, May 31 2018

Issue description

The time domain representation of the linear filter in AEC3 has strong low-frequency components. This causes analyses of the filter, such as finding the direct path component of the filter, and the gain at the end of the filter difficult.
 
One direct effect of this is that the delay within the scope of the linear filter is sometimes wrongly estimated.


 
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/78ea818864c5b16b5568d19aa4b751a65817c67e

commit 78ea818864c5b16b5568d19aa4b751a65817c67e
Author: Per Åhgren <peah@webrtc.org>
Date: Thu Jun 07 13:35:40 2018

AEC3: Added filter preprocessing to avoid low frequency artefacts

This filter preprocess the time domain representation of the adaptive
linear filter to avoid low-frequency components causing issues in
the filter analysis.

Bug:  webrtc:9343 ,  chromium:848231 
Change-Id: I40494959f1b76242a7c9f2a2fc85c2ad4af9e164
Reviewed-on: https://webrtc-review.googlesource.com/79142
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23536}
[modify] https://crrev.com/78ea818864c5b16b5568d19aa4b751a65817c67e/modules/audio_processing/aec3/filter_analyzer.cc
[modify] https://crrev.com/78ea818864c5b16b5568d19aa4b751a65817c67e/modules/audio_processing/aec3/filter_analyzer.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3596e65961370cfb3618ee256d1b90dd636d09c1

commit 3596e65961370cfb3618ee256d1b90dd636d09c1
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jun 08 00:02:49 2018

Roll src/third_party/webrtc 81327d5..ed51a6e (12 commits)

https://webrtc.googlesource.com/src.git/+log/81327d5..ed51a6e


git log 81327d5..ed51a6e --date=short --no-merges --format='%ad %ae %s'
2018-06-07 gustaf@webrtc.org AEC3: Avoid static initializers
2018-06-07 peah@webrtc.org AEC3: Delay stabilization after a delay change
2018-06-07 peah@webrtc.org AEC3: Added filter preprocessing to avoid low frequency artefacts
2018-06-07 magjed@webrtc.org Android: Throw exception in CallSessionFileRotatingLogSink if dir is null
2018-06-07 gustaf@webrtc.org AEC3: Improved anti-aliasing filter for DSF 4
2018-06-07 mbonadei@webrtc.org Removing warning suppression flags from test/.
2018-06-07 mbonadei@webrtc.org Re-enabling SanitizerTest.MsanUninitialized.
2018-06-07 srte@webrtc.org Fixing issue where pacer budget increased in congestion.
2018-06-07 asapersson@webrtc.org Remove unused methods in VCMDecoderDataBase.
2018-06-07 nisse@webrtc.org Delete unused stats for preferred_bitrate.
2018-06-07 gustaf@webrtc.org AEC3: Move decimator filters to the new notation
2018-06-07 nisse@webrtc.org Delete RTP-specific values from the VideoCodecType enum.


Created with:
  gclient setdep -r src/third_party/webrtc@ed51a6e

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG= chromium:846615 , chromium:850451 , chromium:848231 ,chromium:b/106732994,chromium:846615,chromium:none,chromium:846615,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I5fa6c8ebdf457e84a74bc440a044f50ba4915e21
Reviewed-on: https://chromium-review.googlesource.com/1091287
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565471}
[modify] https://crrev.com/3596e65961370cfb3618ee256d1b90dd636d09c1/DEPS

Comment 4 by peah@chromium.org, Jun 11 2018

Cc: gustaf@chromium.org hlundin@chromium.org
Labels: Merge-Request-68
We would like to merge this to M68. It has been tested in Canary and works well. 

The feature is only active beneath a Finch flag and can therefore be turned off if it would go wrong. Furthermore, a kill-switch was added that allows specifically turning off the added functionality.

The CL we would like to merge is:
-https://webrtc-review.googlesource.com/79142


Project Member

Comment 5 by sheriffbot@chromium.org, Jun 11 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-68 Merge-Approved-68
Approving merge for M68. Branch:3440

Comment 7 by peah@chromium.org, Jun 13 2018

Labels: Merge-Merged
The merge is completed.
The merging CL was 
-https://webrtc-review.googlesource.com/c/src/+/83500

Comment 8 by peah@chromium.org, Jun 14 2018

Status: Fixed (was: Assigned)
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 15 2018

Cc: abdulsyed@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: abdulsyed@chromium.org
Pls merge you change to M68 branch 3440 ASAP so we can pick it up for this week Beta release. Merge has to happen latest by 1:00 PM PT tomorrow, Tuesday (06/19), so we can pick it up for Wednesday Beta release.




Labels: -Merge-Approved-68
The change was merged as of #7.

Sign in to add a comment