New issue
Advanced search Search tips

Issue 848227 link

Starred by 4 users

Issue metadata

Status: Duplicate
Merged: issue 848246
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 1
Type: Bug



Sign in to add a comment

PersonalDataManagerTest.DeleteDisusedCreditCards_OnlyDeleteExpiredDisusedLocalCards failing on multiple platforms

Project Member Reported by timvolod...@chromium.org, May 31 2018

Issue description

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Marshmallow%2064%20bit%20Tester/21911

[----------] Global test environment tear-down
[==========] 256 tests from 38 test cases ran. (7215 ms total)
[  PASSED  ] 255 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] PersonalDataManagerTest.DeleteDisusedCreditCards_OnlyDeleteExpiredDisusedLocalCards
[ RUN      ] PersonalDataManagerTest.DeleteDisusedCreditCards_OnlyDeleteExpiredDisusedLocalCards
../../components/autofill/core/browser/personal_data_manager_unittest.cc:4638: Failure
Expected equality of these values:
  5U
    Which is: 5
  personal_data_->GetCreditCards().size()
    Which is: 4
Stack trace:
../../base/test/histogram_tester.cc:171: Failure
Expected equality of these values:
  expected_count
    Which is: 1
  actual_count
    Which is: 0
Histogram "Autofill.CreditCardsDeletedForDisuse" does not have the right number of samples (1) in the expected bucket (1). It has (0).
Stack trace:
[  FAILED  ] PersonalDataManagerTest.DeleteDisusedCreditCards_OnlyDeleteExpiredDisusedLocalCards (229 ms)
[----------] 1 test from PersonalDataManagerTest (231 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (238 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] PersonalDataManagerTest.DeleteDisusedCreditCards_OnlyDeleteExpiredDisusedLocalCards
 
Cc: torne@chromium.org wuandy@chromium.org
seems autofill related
adding:wuandy@ (as the author of the test)
cc sheriff:torne@
Project Member

Comment 2 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bb6c73ed26b8750ad6e024bd4dd7a8650e8109b

commit 5bb6c73ed26b8750ad6e024bd4dd7a8650e8109b
Author: Tim Volodine <timvolodine@google.com>
Date: Thu May 31 12:00:30 2018

[Android] Disable failing DeleteDisusedCreditCards_OnlyDeleteExpiredDisusedLocalCards

Currently fails on a couple of bots see  crbug.com/848227 

BUG= 848227 
TBR=wuangy@chromium.org,torne@chromium.org
NOTRY=true

Change-Id: I2aabb3960b2ede069c2e7c218523a5a78c1da408
Reviewed-on: https://chromium-review.googlesource.com/1080549
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563198}
[modify] https://crrev.com/5bb6c73ed26b8750ad6e024bd4dd7a8650e8109b/components/autofill/core/browser/personal_data_manager_unittest.cc

Cc: sczs@chromium.org mahmadi@chromium.org vabr@chromium.org olivierrobin@chromium.org
 Issue 848233  has been merged into this issue.
Summary: KitKat phone tester, Marshmallow 64 bit tester, asan-clang-phone failing on PersonalDataManagerTest.DeleteDisusedCreditCards_OnlyDeleteExpiredDisusedLocalCards (was: KitKat phone tester and Marshmallow 64 bit tester failing on PersonalDataManagerTest.DeleteDisusedCreditCards_OnlyDeleteExpiredDisusedLocalCards)
Components: UI>Browser>Autofill
Labels: OS-iOS
Labels: -Restrict-View-Google -Pri-3 Test-Disabled OS-iOS Pri-1
Owner: vabr@chromium.org
Status: Assigned (was: Untriaged)
Summary: PersonalDataManagerTest.DeleteDisusedCreditCards_OnlyDeleteExpiredDisusedLocalCards failing on multiple platforms (was: KitKat phone tester, Marshmallow 64 bit tester, asan-clang-phone failing on PersonalDataManagerTest.DeleteDisusedCreditCards_OnlyDeleteExpiredDisusedLocalCards)
To vabr@ for triage.
Project Member

Comment 8 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b32ef49d4a7a8c24a37914129b5029a3f2f8707

commit 1b32ef49d4a7a8c24a37914129b5029a3f2f8707
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Thu May 31 13:43:07 2018

Disable failing DeleteDisusedCreditCards_OnlyDeleteExpiredDisusedLocalCards

Test is also failing on other platforms.
TBR=vabr@chromium.org,wuandy@chromium.org,torne@chromium.org

NOTRY=true

Bug:  848227 
Change-Id: Iff20294884d1c2556a24dc1447e929b457670656
Reviewed-on: https://chromium-review.googlesource.com/1080648
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563211}
[modify] https://crrev.com/1b32ef49d4a7a8c24a37914129b5029a3f2f8707/components/autofill/core/browser/personal_data_manager_unittest.cc

Cc: se...@chromium.org
sebsg@ FYI

Comment 10 by vabr@chromium.org, Jun 1 2018

Cc: -vabr@chromium.org
Components: UI>Browser>Autofill
Owner: ----
Status: Untriaged (was: Assigned)
I am not triaging credit card autofill bugs.
Removing myself as owner and adding the correct label instead.
Owner: ma...@chromium.org
Status: Assigned (was: Untriaged)
mathp@, are you a good person to triage this?
Owner: se...@chromium.org
I think it's been fixed yesterday
Mergedinto: 848246
Status: Duplicate (was: Assigned)
Indeed, merging into the other bug. Thanks for the report.

Sign in to add a comment