ArcBridgeService doesn't start due to 'Invalid initial handshake' error. |
|||||
Issue descriptionI found the following error message in logcat: 'ArcBridgeService: Invalid initial handshake.' The culprit seems to be crrev.com/c/1070882. It changes the first byte of the message from 32 to |base::NumberToString(base::RandUint64()).length()|
,
May 31 2018
Thank you for finding it. Assigned to rockot@, the CL's owner. CC+=Luis, ChromeOS sheriffs and ARC constables. This looks blocking Chrome PFQ. Shall we revert as a first step?
,
May 31 2018
+1 to revert. It also blocks developers.
,
May 31 2018
Created https://chromium-review.googlesource.com/c/chromium/src/+/1080006 as roll-forward. This might reduce the total amount of churn.
,
May 31 2018
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/289fe393b405bbfd5669a4bb67167ebe14e33ca3 commit 289fe393b405bbfd5669a4bb67167ebe14e33ca3 Author: Luis Hector Chavez <lhchavez@google.com> Date: Thu May 31 13:46:27 2018 arc: Use a 32-byte handshake This change uses mojo::edk::GenerateRandomToken() to generate the token, since it produces a 32-byte string. BUG= 848214 TEST=ARC starts again Change-Id: Ie468718edc1b8f43b66dc8edd1863a71a1c5597b Reviewed-on: https://chromium-review.googlesource.com/1080006 Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#563212} [modify] https://crrev.com/289fe393b405bbfd5669a4bb67167ebe14e33ca3/components/arc/arc_session_impl.cc
,
May 31 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by yhanada@chromium.org
, May 31 2018