New issue
Advanced search Search tips

Issue 848171 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on: View detail
issue 848173
issue 848175
issue 849055



Sign in to add a comment

Simplify various ways of starting navigations in Blink

Project Member Reported by dcheng@chromium.org, May 31 2018

Issue description

This is an umbrella bug for cleaning up various issues with starting navigations in Blink.
 

Comment 1 by dcheng@chromium.org, May 31 2018

Blockedon: 848173

Comment 2 by dcheng@chromium.org, May 31 2018

Blockedon: 848175
Also see https://github.com/whatwg/html/issues/3730: it looks like browsers don't agree on some of the specced behaviors today.
Blockedon: 849055
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/641ce2876c69b1d467ec908a9ce861f6d8cb6a4e

commit 641ce2876c69b1d467ec908a9ce861f6d8cb6a4e
Author: Daniel Cheng <dcheng@chromium.org>
Date: Sun Jun 03 23:15:42 2018

Rename scheduled version of Frame::Navigate to Frame::ScheduleNavigation.

Also add a disclaimer that it's really only mostly scheduled.

Bug: 848171
Change-Id: I370c2f47f3118f49fe47e8d72347d13b3a09956a
Reviewed-on: https://chromium-review.googlesource.com/1084064
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563980}
[modify] https://crrev.com/641ce2876c69b1d467ec908a9ce861f6d8cb6a4e/third_party/blink/renderer/core/frame/frame.h
[modify] https://crrev.com/641ce2876c69b1d467ec908a9ce861f6d8cb6a4e/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/641ce2876c69b1d467ec908a9ce861f6d8cb6a4e/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/641ce2876c69b1d467ec908a9ce861f6d8cb6a4e/third_party/blink/renderer/core/frame/local_frame.h
[modify] https://crrev.com/641ce2876c69b1d467ec908a9ce861f6d8cb6a4e/third_party/blink/renderer/core/frame/location.cc
[modify] https://crrev.com/641ce2876c69b1d467ec908a9ce861f6d8cb6a4e/third_party/blink/renderer/core/frame/remote_frame.cc
[modify] https://crrev.com/641ce2876c69b1d467ec908a9ce861f6d8cb6a4e/third_party/blink/renderer/core/frame/remote_frame.h
[modify] https://crrev.com/641ce2876c69b1d467ec908a9ce861f6d8cb6a4e/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/641ce2876c69b1d467ec908a9ce861f6d8cb6a4e/third_party/blink/renderer/core/loader/appcache/application_cache_host.cc
[modify] https://crrev.com/641ce2876c69b1d467ec908a9ce861f6d8cb6a4e/third_party/blink/renderer/core/page/create_window.cc

Sign in to add a comment