New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 848163 link

Starred by 1 user
Status: Fixed
Owner:
dgozman@chromium.org
Closed: May 2018
Cc:
█ manoranj...@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Random source code is displayed instead of desired text, in print preview.

Reported by avsha...@etouch.net, May 31 2018 
Chrome Version : 69.0.3446.0 (Official Build) 9850f1f2cffb7b4e0b4ea26fd6fb94048a911cd5-refs/branch-heads/3446@{#1} (64 Bit)
OS : Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.5), Linux 14.04 LTS

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://version page.
2. Select any text on the page, right click on selected text and choose "Print" option from context menu.
3. Observe the contents in print preview.

Actual Result : Random source code is displayed instead of desired text in print preview.

Expected Result : Selected text should be displayed properly in print preview.

This is a regression issue, broken in M-69 and will soon update remaining info.
Good Build : 69.0.3441.0 (Revision : 562091)
Bad Build : 69.0.3442.0 (Revision : 562138)
Actual_Result.mp4
1.1 MB View Download
Expected_Result.mp4
349 KB View Download

Comment 1 by avsha...@etouch.net, May 31 2018

Labels: hasbisect-per-revision RegressedIn-69 Target-69 FoundIn-69
Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue, broken in M-69 and below is the bisect info:
Good Build : 69.0.3441.0 (Revision : 562091)
Bad Build : 69.0.3442.0 (Revision : 562138)

Change log URL :
https://chromium.googlesource.com/chromium/src/+log/d00a9da08feb014e33bbe73e5692cbbd4331ed93..6cbfa371b381bc82a14262d52f761f071905d4bb

Suspect : https://chromium.googlesource.com/chromium/src/+/6cbfa371b381bc82a14262d52f761f071905d4bb

@Dmitry : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : This issue can be reproduced on internal as well as any web-page.

Comment 2 by rbasuvula@chromium.org, May 31 2018

Cc: manoranj...@chromium.org
Labels: ReleaseBlock-Beta
Adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!
Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ae0ece42a7c8beeaafbb68f4a5b4f7982d7a918

commit 6ae0ece42a7c8beeaafbb68f4a5b4f7982d7a918
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu May 31 22:46:12 2018

Fix PrintPreview of selected text

We erroneously escape the selection markup before calling
LoadHTMLString, which does escape it again. This results in
rendering raw html instead of the content represented by html.

This was recently regressed by loading methods refactoring.

Bug:  848163 
Test: PrintRenderFrameHelperPreviewTest.PrintPreviewForSelectedText2
Change-Id: I7cc8e54d3eb139d63118bad312fe88e735d8552b
Reviewed-on: https://chromium-review.googlesource.com/1081205
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563412}
[modify] https://crrev.com/6ae0ece42a7c8beeaafbb68f4a5b4f7982d7a918/components/printing/renderer/print_render_frame_helper.cc
[modify] https://crrev.com/6ae0ece42a7c8beeaafbb68f4a5b4f7982d7a918/components/printing/test/print_render_frame_helper_browsertest.cc

Comment 4 by dgozman@chromium.org, May 31 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment