[ozone] Bounds are not restored on browser restart. |
|||
Issue descriptionChrome Version: 66.0.3359.181 OS: Linux What steps will reproduce the problem? (Precondition) Chrome should be compiled with ozone/wayland configuration, 'use_ozone = true' and 'ozone_platform_wayland = true'. (1) Launch chrome with '--ozone-platform=wayland --in-process-gpu --window-size=1500,1000', as window resizing is not supported yet. (2) Close chrome and relaunch chrome with '--ozone-platform=wayland --in-process-gpu' What is the expected result? At the second step, normal behavior is that window is opened with same size as the size at the first step. What happens instead? It's always opened with 640,840.
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe commit 137b83a431e1b3f7eb88ad2781126b14c2f1e6fe Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Fri Aug 10 03:53:42 2018 Add implementation for GetRestoredBounds for DesktopWindowTreeHostPlatform This CL introduces SetRestoredBoundsInPixels/GetRestoredBoundsInPixels in PlatformWindow to communicate with DesktopWindowTreeHostPlatform and makes DesktopWindowTreeHostPlatform use PlatformWindow:: GetRestoredBoundsInPixels() to get restored bounds. When WaylandWindow is created, HandleSurfaceConfigure() is always called without any state setting and |state_| is normal at first. In order to know the right time when the state is changed, this patch also updates the initial value for |state_| of WaylandWindow to 'PLATFORM_WINDOW_STATE_NORMAL'. With this, it clears |restored_bounds_| correctly. --ozone-platform=wayland --in-process-gpu, see crbug.com/848131 for more details. Test: ozone_unittests and manual testing with ./out/ozone/chrome Bug: 848131 , 578890 Change-Id: Ifc27e60e24865a2237a0a49d5dc0f1452702c716 Reviewed-on: https://chromium-review.googlesource.com/1080354 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#582041} [modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/ozone/platform/drm/host/drm_window_host.cc [modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/ozone/platform/drm/host/drm_window_host.h [modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/ozone/platform/scenic/scenic_window.cc [modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/ozone/platform/scenic/scenic_window.h [modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/ozone/platform/wayland/wayland_window.cc [modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/ozone/platform/wayland/wayland_window.h [modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/ozone/platform/wayland/wayland_window_unittest.cc [modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/platform_window/platform_window.h [modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/platform_window/stub/stub_window.cc [modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/platform_window/stub/stub_window.h [modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/platform_window/win/win_window.cc [modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/platform_window/win/win_window.h [modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/platform_window/x11/x11_window_base.cc [modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/platform_window/x11/x11_window_base.h [modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc [modify] https://crrev.com/137b83a431e1b3f7eb88ad2781126b14c2f1e6fe/ui/views/widget/desktop_aura/desktop_window_tree_host_platform.h
,
Aug 17
,
Aug 17
|
|||
►
Sign in to add a comment |
|||
Comment 1 by je_julie.kim@chromium.org
, May 31 2018