UI Review asked that we have Crostini setup flow match OOBE's spec. @elizabethchiu, could you please share the spec and re-assign to nverne? Thanks!
You can refer to the spec here: https://drive.google.com/open?id=1Nknmi_0w1VDt9vGKqbLANOOP_IDf-dYS&authuser=elizabethchiu@google.com
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a84b52b43cb533b66dab56ec85a91ee1ba721e0d commit a84b52b43cb533b66dab56ec85a91ee1ba721e0d Author: Nicholas Verne <nverne@chromium.org> Date: Sun Jul 01 22:55:37 2018 Simulate OOBE dialog for Crostini installer Bug: 848118 Change-Id: I887dbfa3d44cd708a42cdf1fcc955e43ada7a759 Reviewed-on: https://chromium-review.googlesource.com/1114408 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#571798} [modify] https://crrev.com/a84b52b43cb533b66dab56ec85a91ee1ba721e0d/ash/public/cpp/ash_typography.cc [modify] https://crrev.com/a84b52b43cb533b66dab56ec85a91ee1ba721e0d/ash/public/cpp/ash_typography.h [modify] https://crrev.com/a84b52b43cb533b66dab56ec85a91ee1ba721e0d/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/a84b52b43cb533b66dab56ec85a91ee1ba721e0d/chrome/app/theme/chrome_unscaled_resources.grd [add] https://crrev.com/a84b52b43cb533b66dab56ec85a91ee1ba721e0d/chrome/app/theme/crostini/linux_illustration_2x.png [modify] https://crrev.com/a84b52b43cb533b66dab56ec85a91ee1ba721e0d/chrome/browser/ui/views/crostini/crostini_installer_view.cc [modify] https://crrev.com/a84b52b43cb533b66dab56ec85a91ee1ba721e0d/chrome/browser/ui/views/crostini/crostini_installer_view.h [modify] https://crrev.com/a84b52b43cb533b66dab56ec85a91ee1ba721e0d/chrome/browser/ui/views/crostini/crostini_installer_view_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4f8554778fd2a3aa1192d2d0ad81f371d3c2bfb commit c4f8554778fd2a3aa1192d2d0ad81f371d3c2bfb Author: Nicholas Verne <nverne@chromium.org> Date: Tue Jul 03 01:10:41 2018 CrostiniInstallerView:: Change magic numbers to meaningful names. Addresses comments from tapted after https://chromium-review.googlesource.com/c/chromium/src/+/1114408 was submitted. Bug: 848118 Change-Id: I66059b005de6ede632f81ec8fa6c9c103a892051 Reviewed-on: https://chromium-review.googlesource.com/1121937 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#572065} [modify] https://crrev.com/c4f8554778fd2a3aa1192d2d0ad81f371d3c2bfb/chrome/browser/ui/views/crostini/crostini_installer_view.cc [modify] https://crrev.com/c4f8554778fd2a3aa1192d2d0ad81f371d3c2bfb/chrome/browser/ui/views/crostini/crostini_installer_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/efc54545bfbf3faa42f874156b037f5e2888471f commit efc54545bfbf3faa42f874156b037f5e2888471f Author: Nicholas Verne <nverne@chromium.org> Date: Wed Jul 04 08:36:29 2018 Crostini install dialog is visually stable. Prior to this change, the lower illustration would change position when label strings changed size or the progress bar became visible. This is prevented by creating two container views, the lower of which is "bottom aligned", and in which the illustration is the only child view. Bug: 848118 Change-Id: I17ff9309152482ea718ed1eb13bf65d823a79bcf Reviewed-on: https://chromium-review.googlesource.com/1125597 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#572512} [modify] https://crrev.com/efc54545bfbf3faa42f874156b037f5e2888471f/chrome/browser/ui/views/crostini/crostini_installer_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fabf70800f58b859f8ab03826e4c3994ec9d7ff1 commit fabf70800f58b859f8ab03826e4c3994ec9d7ff1 Author: Nicholas Verne <nverne@chromium.org> Date: Fri Jul 06 05:03:57 2018 Crostini installer Learn More link There is now a "Learn More" link to a Help Center article from the installer. The link is placed close beneath the preceding label, as per the spec. Bug: 848118 Change-Id: I9bc3cad12b9c916683b0ca105de2400d1a99fd8b Reviewed-on: https://chromium-review.googlesource.com/1126747 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#572898} [modify] https://crrev.com/fabf70800f58b859f8ab03826e4c3994ec9d7ff1/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/fabf70800f58b859f8ab03826e4c3994ec9d7ff1/chrome/browser/ui/views/crostini/crostini_installer_view.cc [modify] https://crrev.com/fabf70800f58b859f8ab03826e4c3994ec9d7ff1/chrome/browser/ui/views/crostini/crostini_installer_view.h [modify] https://crrev.com/fabf70800f58b859f8ab03826e4c3994ec9d7ff1/chrome/common/url_constants.cc [modify] https://crrev.com/fabf70800f58b859f8ab03826e4c3994ec9d7ff1/chrome/common/url_constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5adc1de421e13cb871f50ed27d194a6ed1d5fb4 commit f5adc1de421e13cb871f50ed27d194a6ed1d5fb4 Author: Nicholas Verne <nverne@chromium.org> Date: Thu Jul 12 04:19:01 2018 Linux install dialog now has the word (Beta) Bug: 848118 Change-Id: Ib19c766d00084771d58f648076901eb6c4e25533 Reviewed-on: https://chromium-review.googlesource.com/1133605 Reviewed-by: Renée Wright <rjwright@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#574483} [modify] https://crrev.com/f5adc1de421e13cb871f50ed27d194a6ed1d5fb4/chrome/app/chromeos_strings.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c4273307835932eb40ac4a1965cdce4c70ea474 commit 6c4273307835932eb40ac4a1965cdce4c70ea474 Author: Nicholas Verne <nverne@chromium.org> Date: Thu Jul 19 22:30:26 2018 Adds a new linux illustration for installer dialog. Bug: 848118 Change-Id: I8d5103757913b24fe4fe85e6e6fe9bd1c093aa1e Reviewed-on: https://chromium-review.googlesource.com/1143098 Reviewed-by: Timothy Loh <timloh@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#576667} [modify] https://crrev.com/6c4273307835932eb40ac4a1965cdce4c70ea474/chrome/app/theme/crostini/linux_illustration_2x.png [modify] https://crrev.com/6c4273307835932eb40ac4a1965cdce4c70ea474/chrome/browser/ui/views/crostini/crostini_installer_view.cc
@nverne is this done?
Comment 1 by elizabethchiu@chromium.org
, May 31 2018