New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848107 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Picture-in-Picture: entering PIP on a playing video after closing the window starts paused

Project Member Reported by mlamouri@chromium.org, May 31 2018

Issue description

STR:
 1. https://www.html5rocks.com/en/tutorials/video/basics/
 2. Play video
 3. Enter PIP
 4. Observe PIP video starts playing
 5. Close PIP window
 6. Observe video now paused
 7. Play video
 8. Enter PIP

Expected result: same as #4
Actual result: PIP window has paused video
 
I have a fix for this but git cl upload is annoying. Will upload tomorrow.
Project Member

Comment 2 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d621375a0db89a30269952ba00deb8e29291ada8

commit d621375a0db89a30269952ba00deb8e29291ada8
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Thu May 31 23:36:04 2018

Picture-in-Picture: Close() when the window is already closed should be a no-op.

Bug:  848107 
Change-Id: I8ca426ee3393a40071c564c6e58564167f6df935
Reviewed-on: https://chromium-review.googlesource.com/1080464
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563431}
[modify] https://crrev.com/d621375a0db89a30269952ba00deb8e29291ada8/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/d621375a0db89a30269952ba00deb8e29291ada8/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc

Labels: -M-68 M-69
Status: Fixed (was: Started)

Sign in to add a comment