New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 848102 link

Starred by 2 users
Status: Fixed
Owner:
mlamouri@chromium.org
Closed: Jun 2018
Cc:
█ apaci...@chromium.org
fbeaufort@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Picture-in-Picture: interstitial and text track container should be more friendly

Project Member Reported by mlamouri@chromium.org, May 31 2018 
STR:
 1. Go to https://www.html5rocks.com/en/tutorials/video/basics/
 2. Play video
 3. see text tracks on the video
 4. go in pip

(has to be in debug mode with DCHECK)

Expected result: works
Actual result: crash
Project Member

Comment 1 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94a84374b998abd69b845d44d82f1595cf314102

commit 94a84374b998abd69b845d44d82f1595cf314102
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Thu May 31 16:36:57 2018

HTMLMediaElement: don't ignore interstitials when creating track container.

The text track container creates itself at a very specific position in
the shadow root children. If it doesn't find itself there, it will
create another instance of itself. It means that in a release build, it
will create many instances. On a debug build, it will hit some DCHECKs.

Bug:  848102 
Change-Id: I6a76f80358d5dd35f3eb57fa1fb66c3b7ebd0032
Reviewed-on: https://chromium-review.googlesource.com/1080232
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563271}
[modify] https://crrev.com/94a84374b998abd69b845d44d82f1595cf314102/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/94a84374b998abd69b845d44d82f1595cf314102/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/94a84374b998abd69b845d44d82f1595cf314102/third_party/blink/renderer/core/html/media/html_media_element.h
[add] https://crrev.com/94a84374b998abd69b845d44d82f1595cf314102/third_party/blink/renderer/core/html/media/html_video_element_test.cc

Comment 2 by mlamouri@chromium.org, Jun 22 2018

Status: Fixed (was: Started)
►

Sign in to add a comment