New issue
Advanced search Search tips

Issue 848092 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 1
Type: Bug
Proj-XR



Sign in to add a comment

VRDisplayInfo updates aren't handled correctly

Project Member Reported by billorr@chromium.org, May 30 2018

Issue description

VRDeviceBase::SetVRDisplayInfo has a bug.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b333bdee49ecdfa271c634b5d5e074340bcd47a1

commit b333bdee49ecdfa271c634b5d5e074340bcd47a1
Author: Bill Orr <billorr@chromium.org>
Date: Thu May 31 02:44:11 2018

Fix bug in SetVRDisplayInfo

BUG= 848092 

Change-Id: Icd1ff5e9929f6bed9c7ff657dbcc8a75b39feb35
Reviewed-on: https://chromium-review.googlesource.com/1079806
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563132}
[modify] https://crrev.com/b333bdee49ecdfa271c634b5d5e074340bcd47a1/device/vr/vr_device_base.cc

Labels: Merge-Request-68
Requesting merge for 68 - this will otherwise potentially cause a crash of the browser in some cases.
Status: Started (was: Untriaged)
Labels: -Pri-3 M-68 Pri-1
Labels: OS-Android OS-Windows
This will crash any time the VRDisplayInfo changes.  This will happen consistently on Windows with openvr (behind a flag), and may happen on android.
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 1 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 1 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b21a032f55304deab9f159de6b71d1bab1d39cc1

commit b21a032f55304deab9f159de6b71d1bab1d39cc1
Author: Bill Orr <billorr@chromium.org>
Date: Fri Jun 01 21:46:13 2018

Fix bug in SetVRDisplayInfo

BUG= 848092 

Change-Id: Icd1ff5e9929f6bed9c7ff657dbcc8a75b39feb35
Reviewed-on: https://chromium-review.googlesource.com/1079806
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563132}(cherry picked from commit b333bdee49ecdfa271c634b5d5e074340bcd47a1)
Reviewed-on: https://chromium-review.googlesource.com/1083511
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#101}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/b21a032f55304deab9f159de6b71d1bab1d39cc1/device/vr/vr_device_base.cc

Status: Fixed (was: Started)
Components: Internals>XR
Components: Blink>WebXR

Sign in to add a comment