network-settings-config has been the default since M-66. We should eliminate disable-network-settings-config and deprecate NetworkConfigView and related code. This will eliminate one of the few remaining non WebUI dialogs in Chrome OS.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69 commit 4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Jun 19 02:09:56 2018 Eliminate disable-network-settings-config and networkSettingsConfig This CL eliminates the deprecated --disable-network-settings-config flag and the networkSettingsConfig JS property. The NetworkConfigView and related code will be eliminated in a followup. For comment-only change to ash/public/interfaces/system_tray.mojom: TBR=tsepez@chromium.org Bug: 848090 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I63bd4c79fc3041c1e6b25769fd2cc755664f4247 Reviewed-on: https://chromium-review.googlesource.com/1103057 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#568298} [modify] https://crrev.com/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69/ash/public/interfaces/system_tray.mojom [modify] https://crrev.com/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69/ash/system/network/DEPS [modify] https://crrev.com/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69/ash/system/network/network_list.cc [modify] https://crrev.com/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69/ash/system/network/vpn_list_view.cc [modify] https://crrev.com/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69/chrome/browser/about_flags.cc [modify] https://crrev.com/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69/chrome/browser/flag_descriptions.h [modify] https://crrev.com/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69/chrome/browser/resources/settings/internet_page/internet_detail_page.js [modify] https://crrev.com/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69/chrome/browser/resources/settings/internet_page/internet_page.js [modify] https://crrev.com/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69/chrome/browser/resources/settings/internet_page/internet_page_browser_proxy.js [modify] https://crrev.com/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69/chrome/browser/resources/settings/internet_page/internet_subpage.js [modify] https://crrev.com/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69/chrome/browser/ui/ash/system_tray_client.cc [modify] https://crrev.com/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc [modify] https://crrev.com/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69/chrome/browser/ui/webui/settings/chromeos/internet_handler.cc [modify] https://crrev.com/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69/chrome/browser/ui/webui/settings/chromeos/internet_handler.h [modify] https://crrev.com/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69/chromeos/chromeos_switches.cc [modify] https://crrev.com/4cdf1a71e6d4f8367ecebdad3d6f40c0f8f86d69/chromeos/chromeos_switches.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dc53e6e08ae825fe988719af09ee03040779b66 commit 9dc53e6e08ae825fe988719af09ee03040779b66 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Jun 19 03:47:30 2018 Eliminate deprecated Views based network config code. This CL eliminates: * disable-network-settings-config * networkSettingsConfig * NetworkConfigView and related unused classes This also cleans up some stale comments and related interfaces. Bug: 848090 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id79b835f72b79694d7013cf19a17d553622f844b Reviewed-on: https://chromium-review.googlesource.com/1102912 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#568327} [modify] https://crrev.com/9dc53e6e08ae825fe988719af09ee03040779b66/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/9dc53e6e08ae825fe988719af09ee03040779b66/chrome/app/generated_resources.grd [modify] https://crrev.com/9dc53e6e08ae825fe988719af09ee03040779b66/chrome/app/settings_strings.grdp [modify] https://crrev.com/9dc53e6e08ae825fe988719af09ee03040779b66/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/9dc53e6e08ae825fe988719af09ee03040779b66/chrome/browser/chromeos/chrome_browser_main_chromeos.cc [delete] https://crrev.com/54b9145d7212cbe062e41bac0cec01d47fba33b4/chrome/browser/chromeos/options/cert_library.cc [delete] https://crrev.com/54b9145d7212cbe062e41bac0cec01d47fba33b4/chrome/browser/chromeos/options/cert_library.h [delete] https://crrev.com/54b9145d7212cbe062e41bac0cec01d47fba33b4/chrome/browser/chromeos/options/network_config_view.cc [delete] https://crrev.com/54b9145d7212cbe062e41bac0cec01d47fba33b4/chrome/browser/chromeos/options/network_config_view.h [delete] https://crrev.com/54b9145d7212cbe062e41bac0cec01d47fba33b4/chrome/browser/chromeos/options/network_config_view_browsertest.cc [delete] https://crrev.com/54b9145d7212cbe062e41bac0cec01d47fba33b4/chrome/browser/chromeos/options/network_property_ui_data.cc [delete] https://crrev.com/54b9145d7212cbe062e41bac0cec01d47fba33b4/chrome/browser/chromeos/options/network_property_ui_data.h [delete] https://crrev.com/54b9145d7212cbe062e41bac0cec01d47fba33b4/chrome/browser/chromeos/options/network_property_ui_data_unittest.cc [delete] https://crrev.com/54b9145d7212cbe062e41bac0cec01d47fba33b4/chrome/browser/chromeos/options/vpn_config_view.cc [delete] https://crrev.com/54b9145d7212cbe062e41bac0cec01d47fba33b4/chrome/browser/chromeos/options/vpn_config_view.h [delete] https://crrev.com/54b9145d7212cbe062e41bac0cec01d47fba33b4/chrome/browser/chromeos/options/wifi_config_view.cc [delete] https://crrev.com/54b9145d7212cbe062e41bac0cec01d47fba33b4/chrome/browser/chromeos/options/wifi_config_view.h [delete] https://crrev.com/54b9145d7212cbe062e41bac0cec01d47fba33b4/chrome/browser/chromeos/options/wimax_config_view.cc [delete] https://crrev.com/54b9145d7212cbe062e41bac0cec01d47fba33b4/chrome/browser/chromeos/options/wimax_config_view.h [delete] https://crrev.com/54b9145d7212cbe062e41bac0cec01d47fba33b4/chrome/browser/chromeos/ui/mobile_config_ui.cc [delete] https://crrev.com/54b9145d7212cbe062e41bac0cec01d47fba33b4/chrome/browser/chromeos/ui/mobile_config_ui.h [rename] https://crrev.com/9dc53e6e08ae825fe988719af09ee03040779b66/chrome/browser/chromeos/ui/passphrase_textfield.cc [rename] https://crrev.com/9dc53e6e08ae825fe988719af09ee03040779b66/chrome/browser/chromeos/ui/passphrase_textfield.h [modify] https://crrev.com/9dc53e6e08ae825fe988719af09ee03040779b66/chrome/browser/chromeos/ui/request_pin_view.cc [modify] https://crrev.com/9dc53e6e08ae825fe988719af09ee03040779b66/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc [modify] https://crrev.com/9dc53e6e08ae825fe988719af09ee03040779b66/chrome/browser/ui/webui/chromeos/network_ui.cc [modify] https://crrev.com/9dc53e6e08ae825fe988719af09ee03040779b66/chrome/browser/ui/webui/chromeos/system_web_dialog_delegate.cc [modify] https://crrev.com/9dc53e6e08ae825fe988719af09ee03040779b66/chrome/test/BUILD.gn [modify] https://crrev.com/9dc53e6e08ae825fe988719af09ee03040779b66/chromeos/network/onc/onc_utils.cc [modify] https://crrev.com/9dc53e6e08ae825fe988719af09ee03040779b66/chromeos/network/onc/onc_utils.h
Hooray!!! Only 3 years in the making...
Comment 1 by bugdroid1@chromium.org
, Jun 19 2018