New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 848082 link

Starred by 2 users
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: May 2018
Cc:
█ nnita@chromium.org
█ kkashamsetty@chromium.org
█ abdulsyed@chromium.org
█ yunlian@chromium.org
█ raraghavendra@chromium.org
█ phoenixshen@chromium.org
vapier@chromium.org
█ xiaoyinh@chromium.org
jwer...@chromium.org
█ kkan...@chromium.org
allenwebb@chromium.org
rohi...@chromium.org
bhthompson@google.com
█ bhthompson@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

R68 Branch is failing ImageTest TestImportedSymbolsAreAvailable libmojo_core_arc32.so

Project Member Reported by bhthompson@google.com, May 30 2018 
Ever since the R68 branch we are failing:

======================================================================
FAIL: TestImportedSymbolsAreAvailable (chromite.cros.test.image_test.SymbolsTest)
Ensure all ELF files' imported symbols are available in ROOT-A.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/host/source/chromite/cros/test/image_test.py", line 379, in TestImportedSymbolsAreAvailable
    self.assertFalse(failures, '\n'.join(failures))
AssertionError: File dir-ROOT-A/opt/google/chrome/libmojo_core_arc64.so contains unsatisfied symbols: set(['gettid', '__strlcpy_chk', '__android_log_write', '__sF', 'android_set_abort_message', '__errno'])
File dir-ROOT-A/opt/google/chrome/libmojo_core_arc32.so contains unsatisfied symbols: set(['gettid', '__assert2', '__android_log_write', '__sF', 'pthread_cond_timedwait_monotonic_np', '__errno'])
----------------------------------------------------------------------

For example https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromeos_release%2Fbob-release_release-R68-10718.B%2F5%2F%2B%2Frecipes%2Fsteps%2FImageTest%2F0%2Fstdout


Maybe related to https://bugs.chromium.org/p/chromium/issues/detail?id=846393 ?

Comment 1 by roc...@chromium.org, May 30 2018 

Couple of things:

a) the CL which added these files in chromite's copy step has been reverted
b) i would like to reland it, so is there any way i can stop this test from being run on these libraries? i assume they are never going to work with whatever chromeos toolchain is being used to test them.

Comment 2 by bhthompson@google.com, May 31 2018

Cc: vapier@chromium.org
If the CL was reverted, how is the branch still failing?

As to the test ignoring this file I am not sure, this sounds like something vapier@ may have thoughts on...

Comment 3 by vapier@chromium.org, May 31 2018 

the chromite CL was reverted in master & R68 branch, but was chromium deps rolled ?  looking at the file, it doesn't seem like it:
  https://chromium.googlesource.com/chromium/src/+/68.0.3440.10/DEPS

  # Build tools for Chrome OS. Note: This depends on third_party/pyelftools.
  'src/third_party/chromite': {
      'url': Var('chromium_git') + '/chromiumos/chromite.git' + '@' + '04b73c195727bb3bc8e77a9c48b0a2cb6680ac0d',
      'condition': 'checkout_linux',
  },

commit 04b73c195727bb3bc8e77a9c48b0a2cb6680ac0d includes CL:1066085 but not the CL:1075987 revert.  we should roll that to 5c5c9b6bb66ee923b98e0278d18fe15559b9eb88 (current release-R68 branch in chromite).

Comment 4 by bhthompson@google.com, May 31 2018

Cc: abdulsyed@chromium.org
Labels: Merge-Request-68
+abdulsyed as this is going into the 68 branch.

I think the CL at https://chromium-review.googlesource.com/c/chromium/src/+/1081293 should do it then, if there are no objections I would like to land this today for the next Chrome uprev to hopefully make 68 green for CrOS.

Comment 5 by abdulsyed@google.com, May 31 2018

Labels: -Merge-Request-68 Merge-Approved-68
Approving merge M68 branch:3440

Comment 6 by bhthompson@google.com, May 31 2018

Status: Fixed (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, May 31 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1408f3ca3320963e4167d17e22d5eb347f037918

commit 1408f3ca3320963e4167d17e22d5eb347f037918
Author: Bernie Thompson <bhthompson@google.com>
Date: Thu May 31 21:14:45 2018

Roll chromite in DEPS to 5c5c9b6bb

BUG= chromium:848082 
TEST=None

Change-Id: I7202c78124b77c1124f35c9516f427b9b638428e
Reviewed-on: https://chromium-review.googlesource.com/1081293
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#67}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/1408f3ca3320963e4167d17e22d5eb347f037918/DEPS

Comment 8 by bhthompson@google.com, Jun 1 2018

Cc: allenwebb@chromium.org rohi...@chromium.org nnita@chromium.org bhthompson@chromium.org jwer...@chromium.org kkan...@chromium.org kkashamsetty@chromium.org raraghavendra@chromium.org phoenixshen@chromium.org
 Issue 845113  has been merged into this issue.
►

Sign in to add a comment