content/browser/renderer_host/pepper/ uses net::TCPClientSocket and net::SSLClientSocket. It needs to be ported to using network service's mojo sockets (tls_socket.mojom and tcp_socket.mojom)
Think I'll take this one.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4e3e4a1d8949d712cb36d2c4c54264598a0ae1b commit c4e3e4a1d8949d712cb36d2c4c54264598a0ae1b Author: Matt Menke <mmenke@chromium.org> Date: Wed Aug 15 17:37:37 2018 Mojo UDPSockets: Add methods to set send and receive buffer sizes. Previously, these could only be set on construction, but the Pepper Mojo API lets consumers change these at runtime. Bug: 848078 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia75aeeda26e3ea09ba3b2647ab42b97161a6bae9 Reviewed-on: https://chromium-review.googlesource.com/1173341 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: Xiangjun Zhang <xjz@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#583303} [modify] https://crrev.com/c4e3e4a1d8949d712cb36d2c4c54264598a0ae1b/components/mirroring/service/fake_network_service.h [modify] https://crrev.com/c4e3e4a1d8949d712cb36d2c4c54264598a0ae1b/services/network/public/mojom/udp_socket.mojom [modify] https://crrev.com/c4e3e4a1d8949d712cb36d2c4c54264598a0ae1b/services/network/udp_socket.cc [modify] https://crrev.com/c4e3e4a1d8949d712cb36d2c4c54264598a0ae1b/services/network/udp_socket.h [modify] https://crrev.com/c4e3e4a1d8949d712cb36d2c4c54264598a0ae1b/services/network/udp_socket_test_util.cc [modify] https://crrev.com/c4e3e4a1d8949d712cb36d2c4c54264598a0ae1b/services/network/udp_socket_test_util.h [modify] https://crrev.com/c4e3e4a1d8949d712cb36d2c4c54264598a0ae1b/services/network/udp_socket_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc2b634dbe8b987c9946689b6d8c2388cd5466ea commit cc2b634dbe8b987c9946689b6d8c2388cd5466ea Author: Matt Menke <mmenke@chromium.org> Date: Wed Aug 22 16:33:43 2018 Make PepperUdpSocketMessageFilter use NetworkService UDP API. This CL moves all of the logic over to the UI thread, to keep things relatively simple and minimize thread hops, since that's where core network service objects live. It also fixes a pre-existing bug in the PPAPI UDP code, where read errors that occur when there's no pending read are converted into 0-byte read successes. Bug: 848078 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id6d23c26c1ac085211dfcfe23502a307fc29a284 Reviewed-on: https://chromium-review.googlesource.com/1171568 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#585057} [modify] https://crrev.com/cc2b634dbe8b987c9946689b6d8c2388cd5466ea/chrome/test/ppapi/ppapi_browsertest.cc [modify] https://crrev.com/cc2b634dbe8b987c9946689b6d8c2388cd5466ea/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc [modify] https://crrev.com/cc2b634dbe8b987c9946689b6d8c2388cd5466ea/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h [modify] https://crrev.com/cc2b634dbe8b987c9946689b6d8c2388cd5466ea/content/public/test/ppapi_test_utils.cc [modify] https://crrev.com/cc2b634dbe8b987c9946689b6d8c2388cd5466ea/content/public/test/ppapi_test_utils.h [modify] https://crrev.com/cc2b634dbe8b987c9946689b6d8c2388cd5466ea/ppapi/host/resource_message_filter.cc [modify] https://crrev.com/cc2b634dbe8b987c9946689b6d8c2388cd5466ea/ppapi/host/resource_message_filter.h [modify] https://crrev.com/cc2b634dbe8b987c9946689b6d8c2388cd5466ea/ppapi/proxy/udp_socket_filter.cc [modify] https://crrev.com/cc2b634dbe8b987c9946689b6d8c2388cd5466ea/ppapi/tests/test_udp_socket.cc [modify] https://crrev.com/cc2b634dbe8b987c9946689b6d8c2388cd5466ea/ppapi/tests/test_udp_socket.h [modify] https://crrev.com/cc2b634dbe8b987c9946689b6d8c2388cd5466ea/tools/traffic_annotation/summary/annotations.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ea4abbfded911cb15cc62f93519564983f41faf commit 3ea4abbfded911cb15cc62f93519564983f41faf Author: Jonathan Ross <jonross@chromium.org> Date: Wed Aug 22 19:22:39 2018 Revert "Make PepperUdpSocketMessageFilter use NetworkService UDP API." This reverts commit cc2b634dbe8b987c9946689b6d8c2388cd5466ea. Reason for revert: Multiple PPAPI tests have begun failing on different OSes after this patch lands. See crbug.com/876824 Original change's description: > Make PepperUdpSocketMessageFilter use NetworkService UDP API. > > This CL moves all of the logic over to the UI thread, to keep things > relatively simple and minimize thread hops, since that's where core > network service objects live. > > It also fixes a pre-existing bug in the PPAPI UDP code, where read > errors that occur when there's no pending read are converted into > 0-byte read successes. > > Bug: 848078 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Id6d23c26c1ac085211dfcfe23502a307fc29a284 > Reviewed-on: https://chromium-review.googlesource.com/1171568 > Commit-Queue: Matt Menke <mmenke@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Reviewed-by: Helen Li <xunjieli@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585057} TBR=bbudge@chromium.org,jam@chromium.org,mmenke@chromium.org,xunjieli@chromium.org,rhalavati@chromium.org Change-Id: I68b625673615275c102a95aac7df7583a2f7c97d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 848078 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1185682 Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#585196} [modify] https://crrev.com/3ea4abbfded911cb15cc62f93519564983f41faf/chrome/test/ppapi/ppapi_browsertest.cc [modify] https://crrev.com/3ea4abbfded911cb15cc62f93519564983f41faf/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc [modify] https://crrev.com/3ea4abbfded911cb15cc62f93519564983f41faf/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h [modify] https://crrev.com/3ea4abbfded911cb15cc62f93519564983f41faf/content/public/test/ppapi_test_utils.cc [modify] https://crrev.com/3ea4abbfded911cb15cc62f93519564983f41faf/content/public/test/ppapi_test_utils.h [modify] https://crrev.com/3ea4abbfded911cb15cc62f93519564983f41faf/ppapi/host/resource_message_filter.cc [modify] https://crrev.com/3ea4abbfded911cb15cc62f93519564983f41faf/ppapi/host/resource_message_filter.h [modify] https://crrev.com/3ea4abbfded911cb15cc62f93519564983f41faf/ppapi/proxy/udp_socket_filter.cc [modify] https://crrev.com/3ea4abbfded911cb15cc62f93519564983f41faf/ppapi/tests/test_udp_socket.cc [modify] https://crrev.com/3ea4abbfded911cb15cc62f93519564983f41faf/ppapi/tests/test_udp_socket.h [modify] https://crrev.com/3ea4abbfded911cb15cc62f93519564983f41faf/tools/traffic_annotation/summary/annotations.xml
This might not be needed for Canary.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/497cb60f1b4b24963d23a16f0ccd94158352563c commit 497cb60f1b4b24963d23a16f0ccd94158352563c Author: Matt Menke <mmenke@chromium.org> Date: Fri Aug 24 22:08:21 2018 Add broadcast to network::mojom::UDPSocketOptions. It turns out that on OSX, broadcast must be set on a UDP socket before binding a socket when reusing an address that already has a broadcast socket bound to it. Otherwise, the bind() call will fail. Bug: 848078 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I41f2bb6085a9be1dc42c18483a85766d4b3d46ac Reviewed-on: https://chromium-review.googlesource.com/1188617 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#586016} [modify] https://crrev.com/497cb60f1b4b24963d23a16f0ccd94158352563c/services/network/public/mojom/udp_socket.mojom [modify] https://crrev.com/497cb60f1b4b24963d23a16f0ccd94158352563c/services/network/udp_socket.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80c224c08e567070336c4762f8a56d405c134929 commit 80c224c08e567070336c4762f8a56d405c134929 Author: Matt Menke <mmenke@chromium.org> Date: Mon Aug 27 23:44:45 2018 Make PepperUdpSocketMessageFilter use NetworkService UDP API. This CL moves all of the logic over to the UI thread, to keep things relatively simple and minimize thread hops, since that's where core network service objects live. It also fixes a pre-existing bug in the PPAPI UDP code, where read errors that occur when there's no pending read are converted into 0-byte read successes. This is a reland of https://chromium-review.googlesource.com/1171568, which was reverted due to tests failing on OSX when broadcast was set only after calling Bind, due to the Bind call failing. The new CL uses a new UDPSocketOption to allow broadcast before calling Bind on the underlying socket. TBR=jam@chromium.org, rhalvati@chromium.org Bug: 848078 , 876824 Change-Id: I0e31a357eb4b80bb78bae32f2a3ea3ce331256ec Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1190407 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#586497} [modify] https://crrev.com/80c224c08e567070336c4762f8a56d405c134929/chrome/test/ppapi/ppapi_browsertest.cc [modify] https://crrev.com/80c224c08e567070336c4762f8a56d405c134929/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc [modify] https://crrev.com/80c224c08e567070336c4762f8a56d405c134929/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h [modify] https://crrev.com/80c224c08e567070336c4762f8a56d405c134929/content/public/test/ppapi_test_utils.cc [modify] https://crrev.com/80c224c08e567070336c4762f8a56d405c134929/content/public/test/ppapi_test_utils.h [modify] https://crrev.com/80c224c08e567070336c4762f8a56d405c134929/ppapi/host/resource_message_filter.cc [modify] https://crrev.com/80c224c08e567070336c4762f8a56d405c134929/ppapi/host/resource_message_filter.h [modify] https://crrev.com/80c224c08e567070336c4762f8a56d405c134929/ppapi/proxy/udp_socket_filter.cc [modify] https://crrev.com/80c224c08e567070336c4762f8a56d405c134929/ppapi/tests/test_udp_socket.cc [modify] https://crrev.com/80c224c08e567070336c4762f8a56d405c134929/ppapi/tests/test_udp_socket.h [modify] https://crrev.com/80c224c08e567070336c4762f8a56d405c134929/tools/traffic_annotation/summary/annotations.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a886f31ed796f5e053765a53be5403b1518aa157 commit a886f31ed796f5e053765a53be5403b1518aa157 Author: Matt Menke <mmenke@chromium.org> Date: Fri Aug 31 18:17:42 2018 Add some more PPAPI TCP tests. In particular, add some tests for various errors and state transitions, and make sure reading from a closed socket returns net::OK on the first read. This CL also splits up the PPAPI TcpSocket browser test into multiple tests to decrease the chance of the tests timing out. Bug: 848078 Change-Id: I308cfa0ac60db63ada4a41dce8d93e68393600ff Reviewed-on: https://chromium-review.googlesource.com/1197924 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#588092} [modify] https://crrev.com/a886f31ed796f5e053765a53be5403b1518aa157/chrome/test/ppapi/ppapi_browsertest.cc [modify] https://crrev.com/a886f31ed796f5e053765a53be5403b1518aa157/ppapi/tests/test_tcp_socket.cc [modify] https://crrev.com/a886f31ed796f5e053765a53be5403b1518aa157/ppapi/tests/test_tcp_socket.h [modify] https://crrev.com/a886f31ed796f5e053765a53be5403b1518aa157/ppapi/tests/test_utils.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79e8e426a348aaecfb817065f217383c5d348606 commit 79e8e426a348aaecfb817065f217383c5d348606 Author: calamity <calamity@chromium.org> Date: Mon Sep 03 05:52:09 2018 Revert "Add some more PPAPI TCP tests." This reverts commit a886f31ed796f5e053765a53be5403b1518aa157. Reason for revert: Causing failures on Mac starting at https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28803 Other examples: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/4934 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15151 Original change's description: > Add some more PPAPI TCP tests. > > In particular, add some tests for various errors and state transitions, > and make sure reading from a closed socket returns net::OK on the first > read. > > This CL also splits up the PPAPI TcpSocket browser test into multiple > tests to decrease the chance of the tests timing out. > > Bug: 848078 > Change-Id: I308cfa0ac60db63ada4a41dce8d93e68393600ff > Reviewed-on: https://chromium-review.googlesource.com/1197924 > Commit-Queue: Matt Menke <mmenke@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588092} TBR=bbudge@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 848078 Change-Id: I3bdecc1e754da5d14cf184b5e285a6db3ec21362 Reviewed-on: https://chromium-review.googlesource.com/1201629 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#588333} [modify] https://crrev.com/79e8e426a348aaecfb817065f217383c5d348606/chrome/test/ppapi/ppapi_browsertest.cc [modify] https://crrev.com/79e8e426a348aaecfb817065f217383c5d348606/ppapi/tests/test_tcp_socket.cc [modify] https://crrev.com/79e8e426a348aaecfb817065f217383c5d348606/ppapi/tests/test_tcp_socket.h [modify] https://crrev.com/79e8e426a348aaecfb817065f217383c5d348606/ppapi/tests/test_utils.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62b56c6304a5985eeaefed9817870d9e323714cc commit 62b56c6304a5985eeaefed9817870d9e323714cc Author: Matt Menke <mmenke@chromium.org> Date: Tue Sep 04 19:25:51 2018 Reland: Add some more PPAPI TCP tests. The original CL was reverted because OSX times out connection attempts to bound but not listening sockets, unlike other platforms. The original CL apparently only passed the bots because the browser_test target wasn't running on the OSX bots for some reason. Original description: In particular, add some tests for various errors and state transitions, and make sure reading from a closed socket returns net::OK on the first read. This CL also splits up the PPAPI TcpSocket browser test into multiple tests to decrease the chance of the tests timing out. Bug: 848078 Change-Id: I7c9e1a10e29213058a624750d867355231db5ede Reviewed-on: https://chromium-review.googlesource.com/1202242 Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#588611} [modify] https://crrev.com/62b56c6304a5985eeaefed9817870d9e323714cc/chrome/test/ppapi/ppapi_browsertest.cc [modify] https://crrev.com/62b56c6304a5985eeaefed9817870d9e323714cc/ppapi/tests/test_tcp_socket.cc [modify] https://crrev.com/62b56c6304a5985eeaefed9817870d9e323714cc/ppapi/tests/test_tcp_socket.h [modify] https://crrev.com/62b56c6304a5985eeaefed9817870d9e323714cc/ppapi/tests/test_utils.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6849ef9feac6fb730661c777c360d869f38db71 commit b6849ef9feac6fb730661c777c360d869f38db71 Author: Matt Menke <mmenke@chromium.org> Date: Tue Sep 04 23:08:46 2018 Disalbe TCPBoundSocketTest.ListenError It's flaking on Cast. Will probably remove it tomorrow. TBR=morlovich@chromium.org NOTRY=true Bug: 848078 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I055d8aad65f795e385afc3ee50e0e80a395dacf3 Reviewed-on: https://chromium-review.googlesource.com/1205532 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#588685} [modify] https://crrev.com/b6849ef9feac6fb730661c777c360d869f38db71/services/network/tcp_bound_socket_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b52e5772bea1dd76f60fea8d1275d028b253a88a commit b52e5772bea1dd76f60fea8d1275d028b253a88a Author: Matt Menke <mmenke@chromium.org> Date: Wed Sep 19 19:25:38 2018 Add TCPConnectedSocket methods to configure buffer sizes. Also add a TCPConnectedSocketOptions structure to sent options on socket construction, as it makes state management and error handling in consumers simpler if they want to set multiple options when creating a socket. BUG= 848078 TBR=mfoltz@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2177b907b2a1d75212e27505f8366c608457e2b8 Reviewed-on: https://chromium-review.googlesource.com/1204852 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#592515} [modify] https://crrev.com/b52e5772bea1dd76f60fea8d1275d028b253a88a/components/cast_channel/cast_socket.cc [modify] https://crrev.com/b52e5772bea1dd76f60fea8d1275d028b253a88a/extensions/browser/api/socket/tcp_socket.cc [modify] https://crrev.com/b52e5772bea1dd76f60fea8d1275d028b253a88a/net/socket/socket_test_util.cc [modify] https://crrev.com/b52e5772bea1dd76f60fea8d1275d028b253a88a/net/socket/socket_test_util.h [modify] https://crrev.com/b52e5772bea1dd76f60fea8d1275d028b253a88a/services/network/network_context.cc [modify] https://crrev.com/b52e5772bea1dd76f60fea8d1275d028b253a88a/services/network/network_context.h [modify] https://crrev.com/b52e5772bea1dd76f60fea8d1275d028b253a88a/services/network/public/cpp/server/http_server_unittest.cc [modify] https://crrev.com/b52e5772bea1dd76f60fea8d1275d028b253a88a/services/network/public/mojom/network_context.mojom [modify] https://crrev.com/b52e5772bea1dd76f60fea8d1275d028b253a88a/services/network/public/mojom/tcp_socket.mojom [modify] https://crrev.com/b52e5772bea1dd76f60fea8d1275d028b253a88a/services/network/socket_factory.cc [modify] https://crrev.com/b52e5772bea1dd76f60fea8d1275d028b253a88a/services/network/socket_factory.h [modify] https://crrev.com/b52e5772bea1dd76f60fea8d1275d028b253a88a/services/network/tcp_connected_socket.cc [modify] https://crrev.com/b52e5772bea1dd76f60fea8d1275d028b253a88a/services/network/tcp_connected_socket.h [modify] https://crrev.com/b52e5772bea1dd76f60fea8d1275d028b253a88a/services/network/tcp_socket_unittest.cc [modify] https://crrev.com/b52e5772bea1dd76f60fea8d1275d028b253a88a/services/network/test/test_network_context.h [modify] https://crrev.com/b52e5772bea1dd76f60fea8d1275d028b253a88a/services/network/tls_client_socket_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8fb81b9947f4a67c8d3ca4058181106215ad9c7 commit f8fb81b9947f4a67c8d3ca4058181106215ad9c7 Author: Matt Menke <mmenke@chromium.org> Date: Sat Sep 22 00:57:05 2018 Add TCPConnectedSocketOptions support to TCPBoundSocket. TCPBoundSocket now calls into TCPConnectedSocket's connect option, so that they can share connection establishment and socket configuration code. This increases code reuse and reduces code disting to TCPBoundSocket, which is also handy, as it's harder to test than TCPConnectedSocket. Also makes TCPBoundSocket take an AddressList instead of an IPEndPoint. Since it's now using TCPConnectedSocket's connect code, might as well reuse its ability to take a list of addresses to try. Bug: 848078 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I94059f08f649833db89676bde50ec8b11fbbb9b6 Reviewed-on: https://chromium-review.googlesource.com/1231740 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#593398} [modify] https://crrev.com/f8fb81b9947f4a67c8d3ca4058181106215ad9c7/net/socket/tcp_client_socket.cc [modify] https://crrev.com/f8fb81b9947f4a67c8d3ca4058181106215ad9c7/net/socket/tcp_client_socket.h [modify] https://crrev.com/f8fb81b9947f4a67c8d3ca4058181106215ad9c7/net/socket/tcp_socket_posix.h [modify] https://crrev.com/f8fb81b9947f4a67c8d3ca4058181106215ad9c7/net/socket/tcp_socket_win.h [modify] https://crrev.com/f8fb81b9947f4a67c8d3ca4058181106215ad9c7/services/network/public/mojom/tcp_socket.mojom [modify] https://crrev.com/f8fb81b9947f4a67c8d3ca4058181106215ad9c7/services/network/tcp_bound_socket.cc [modify] https://crrev.com/f8fb81b9947f4a67c8d3ca4058181106215ad9c7/services/network/tcp_bound_socket.h [modify] https://crrev.com/f8fb81b9947f4a67c8d3ca4058181106215ad9c7/services/network/tcp_bound_socket_unittest.cc [modify] https://crrev.com/f8fb81b9947f4a67c8d3ca4058181106215ad9c7/services/network/tcp_connected_socket.cc [modify] https://crrev.com/f8fb81b9947f4a67c8d3ca4058181106215ad9c7/services/network/tcp_connected_socket.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6854c9f99de417accc5135f3b3c40fdc209cfd6 commit c6854c9f99de417accc5135f3b3c40fdc209cfd6 Author: Matt Menke <mmenke@chromium.org> Date: Sat Sep 22 02:21:01 2018 Add support for UpgradeToTLS to TCPBoundSockets. Previously it would just fail. Also fix a bug in the ERR_NOT_IMPLEMENTED failure when trying to upgrade accepted client sockets to TLS. Add tests for both cases. Bug: 848078 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia908a7da077a14c69ae990afe19339dfa440b9a5 Reviewed-on: https://chromium-review.googlesource.com/1234226 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#593415} [modify] https://crrev.com/c6854c9f99de417accc5135f3b3c40fdc209cfd6/services/network/socket_factory.h [modify] https://crrev.com/c6854c9f99de417accc5135f3b3c40fdc209cfd6/services/network/tcp_bound_socket.cc [modify] https://crrev.com/c6854c9f99de417accc5135f3b3c40fdc209cfd6/services/network/tcp_bound_socket_unittest.cc [modify] https://crrev.com/c6854c9f99de417accc5135f3b3c40fdc209cfd6/services/network/tcp_connected_socket.cc [modify] https://crrev.com/c6854c9f99de417accc5135f3b3c40fdc209cfd6/services/network/tcp_socket_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc9d2c8e7d8e9e97d062ddc9492e30e038acef14 commit bc9d2c8e7d8e9e97d062ddc9492e30e038acef14 Author: Matt Menke <mmenke@chromium.org> Date: Sat Sep 22 02:39:51 2018 Add field to TLSClientSocketOptions to request SSLInfo. The only previous way to get it was to disable cert verification. Bug: 848078 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic14d5273a803cb53e92bbc370a16f045c86bdcca Reviewed-on: https://chromium-review.googlesource.com/1235173 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#593419} [modify] https://crrev.com/bc9d2c8e7d8e9e97d062ddc9492e30e038acef14/services/network/public/mojom/tls_socket.mojom [modify] https://crrev.com/bc9d2c8e7d8e9e97d062ddc9492e30e038acef14/services/network/tls_client_socket_unittest.cc [modify] https://crrev.com/bc9d2c8e7d8e9e97d062ddc9492e30e038acef14/services/network/tls_socket_factory.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2503741250103698c5b9ec1f52535a47c191ec45 commit 2503741250103698c5b9ec1f52535a47c191ec45 Author: Matt Menke <mmenke@chromium.org> Date: Mon Oct 08 21:40:54 2018 Migrate Pepper TCP message filters to network service APIs. The pepper TCP message filters were legacy in-process network APIs. This CL updates them to use the network service. It does affect the APIs in a number of subtle ways: * Sockets upgraded to TLS now do full cert verification (including certificate transparency) * Sockets created by listening can't be upgraded to TLS (Which is an unusual thing to support, since the old API to upgrade them used client-side SSL handshakes, instead of acting like a server). * If a Listen() call fails, all future calls on the socket will fail. Previously, the consumer could call Listen() again, and it might succeed, or even call Connect() on the socket (Which would be weird). There may be others as well. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I42eef492471dc79d00ac0b543d34c0527089e1ea Bug: 848078 Reviewed-on: https://chromium-review.googlesource.com/c/1194943 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#597689} [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/chrome/test/ppapi/ppapi_browsertest.cc [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/content/browser/BUILD.gn [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/content/browser/renderer_host/pepper/browser_ppapi_host_impl.h [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.h [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.h [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h [delete] https://crrev.com/9a301b003c3c9e8019ba379ff084cfb785fa89bd/content/browser/renderer_host/pepper/ssl_context_helper.cc [delete] https://crrev.com/9a301b003c3c9e8019ba379ff084cfb785fa89bd/content/browser/renderer_host/pepper/ssl_context_helper.h [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/content/public/test/ppapi_test_utils.cc [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/content/public/test/ppapi_test_utils.h [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/ppapi/shared_impl/ppb_tcp_socket_shared.cc [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/ppapi/tests/test_tcp_server_socket_private.cc [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/ppapi/tests/test_tcp_server_socket_private.h [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/ppapi/tests/test_tcp_socket.cc [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/ppapi/tests/test_tcp_socket.h [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/ppapi/tests/test_tcp_socket_private.cc [modify] https://crrev.com/2503741250103698c5b9ec1f52535a47c191ec45/ppapi/tests/test_tcp_socket_private.h
Comment 1 by dxie@chromium.org
, Jun 8 2018