New issue
Advanced search Search tips

Issue 848073 link

Starred by 5 users
Status: Fixed
Owner:
jam@chromium.org
Closed: Aug 23
Cc:
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 721401



Sign in to add a comment

Migrate components/cast_channel/cast_socket.h to mojo sockets

Project Member Reported by xunji...@chromium.org, May 30 2018 
components/cast_channel/cast_socket.h currently creates net::TCPClientSocket and net::SSLClientSocket. As a part of network servicification, CastSocket needs to be migrated to network service's mojo sockets (tls_socket.mojom and tcp_socket.mojom).

CastSocket currently stubs out cert verification and does their own authentication after ssl handshake. This can be problematic and is currently unsupported in network service, and we need to figure out a solution.

Comment 1 by dxie@chromium.org, Jun 8 2018

Labels: OS-Chrome OS-Windows OS-Mac OS-Linux

Comment 2 by dxie@google.com, Jun 27 2018

Labels: Proj-Servicification-network-url

Comment 3 by dxie@chromium.org, Aug 14

Labels: -Proj-Servicification-network-url

Comment 4 by jam@chromium.org, Aug 14

Owner: jam@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac

commit ebbb0df2323e2f3f0ffe801b7eb37e61437654ac
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Aug 23 19:11:32 2018

Convert Cast code to use Network Service Mojo APIs.

Bug:  848073 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I60408ab991595b0057d017e53a4746794343c0b8
Reviewed-on: https://chromium-review.googlesource.com/1182949
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585571}
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/chrome/browser/extensions/chrome_extensions_browser_client.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/chrome/browser/extensions/chrome_extensions_browser_client.h
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/chrome/browser/media/router/discovery/mdns/cast_media_sink_service_impl.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/chrome/browser/media/router/discovery/mdns/cast_media_sink_service_impl_unittest.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/components/cast_channel/BUILD.gn
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/components/cast_channel/DEPS
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/components/cast_channel/cast_message_handler.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/components/cast_channel/cast_message_handler_unittest.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/components/cast_channel/cast_socket.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/components/cast_channel/cast_socket.h
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/components/cast_channel/cast_socket_service.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/components/cast_channel/cast_socket_service.h
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/components/cast_channel/cast_socket_service_unittest.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/components/cast_channel/cast_socket_unittest.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/components/cast_channel/cast_test_util.h
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/components/cast_channel/cast_transport.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/components/cast_channel/cast_transport.h
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/components/cast_channel/cast_transport_unittest.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/components/cast_channel/keep_alive_delegate.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/components/cast_channel/keep_alive_delegate_unittest.cc
[add] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/components/cast_channel/mojo_data_pump.cc
[add] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/components/cast_channel/mojo_data_pump.h
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/extensions/browser/api/cast_channel/cast_channel_api.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/extensions/browser/api/cast_channel/cast_channel_apitest.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/extensions/browser/api/socket/tcp_socket.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/extensions/browser/api/socket/tcp_socket.h
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/extensions/browser/extensions_browser_client.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/extensions/browser/extensions_browser_client.h
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/net/socket/socket_test_util.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/net/socket/socket_test_util.h
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/services/network/public/mojom/tcp_socket.mojom
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/services/network/public/mojom/tls_socket.mojom
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/services/network/socket_factory.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/services/network/socket_factory.h
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/services/network/tcp_connected_socket.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/services/network/tcp_socket_unittest.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/services/network/tls_client_socket.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/services/network/tls_client_socket.h
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/services/network/tls_client_socket_unittest.cc
[modify] https://crrev.com/ebbb0df2323e2f3f0ffe801b7eb37e61437654ac/tools/traffic_annotation/summary/annotations.xml

Comment 6 by jam@chromium.org, Aug 23

Status: Fixed (was: Assigned)
►

Sign in to add a comment