New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 848055 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

WebUI: cups add printer dialog javascript runtime error

Project Member Reported by scottchen@chromium.org, May 30 2018

Issue description

I think an element was removed but its corresponding JS and CSS code referring to the element was not removed with it.
 
Screenshot from 2018-05-30 15-08-41.png
10.1 KB View Download

Comment 2 by dpa...@chromium.org, May 30 2018

Components: -UI>Browser>WebUI UI>Settings

Comment 3 by dpa...@chromium.org, May 30 2018

Labels: OS-Chrome

Comment 4 by x...@chromium.org, May 30 2018

Cc: weifangsun@chromium.org x...@chromium.org
Owner: baileyberro@chromium.org
I think it's caused by this CL https://chromium-review.googlesource.com/c/chromium/src/+/1060341.
Status: Started (was: Assigned)
Looks like that CL would have caused it- I'll take a look
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1789600ee46dd47e09fa43867cd2af19dfb97a09

commit 1789600ee46dd47e09fa43867cd2af19dfb97a09
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Jun 13 00:14:07 2018

Remove reference to non-existant div in Printers settings

This change removes the reference in onAddPrinterTap_ to
addPrinterErrorMessage which was removed in https://crrev.com/c/1060341.

Bug:  chromium:848055 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5084eac9896331c71c58a9cac2851d1ce14f56ec
Reviewed-on: https://chromium-review.googlesource.com/1089207
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566639}
[modify] https://crrev.com/1789600ee46dd47e09fa43867cd2af19dfb97a09/chrome/browser/resources/settings/printing_page/cups_printers.html
[modify] https://crrev.com/1789600ee46dd47e09fa43867cd2af19dfb97a09/chrome/browser/resources/settings/printing_page/cups_printers.js

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1789600ee46dd47e09fa43867cd2af19dfb97a09

commit 1789600ee46dd47e09fa43867cd2af19dfb97a09
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Jun 13 00:14:07 2018

Remove reference to non-existant div in Printers settings

This change removes the reference in onAddPrinterTap_ to
addPrinterErrorMessage which was removed in https://crrev.com/c/1060341.

Bug:  chromium:848055 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5084eac9896331c71c58a9cac2851d1ce14f56ec
Reviewed-on: https://chromium-review.googlesource.com/1089207
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566639}
[modify] https://crrev.com/1789600ee46dd47e09fa43867cd2af19dfb97a09/chrome/browser/resources/settings/printing_page/cups_printers.html
[modify] https://crrev.com/1789600ee46dd47e09fa43867cd2af19dfb97a09/chrome/browser/resources/settings/printing_page/cups_printers.js

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1789600ee46dd47e09fa43867cd2af19dfb97a09

commit 1789600ee46dd47e09fa43867cd2af19dfb97a09
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Jun 13 00:14:07 2018

Remove reference to non-existant div in Printers settings

This change removes the reference in onAddPrinterTap_ to
addPrinterErrorMessage which was removed in https://crrev.com/c/1060341.

Bug:  chromium:848055 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5084eac9896331c71c58a9cac2851d1ce14f56ec
Reviewed-on: https://chromium-review.googlesource.com/1089207
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566639}
[modify] https://crrev.com/1789600ee46dd47e09fa43867cd2af19dfb97a09/chrome/browser/resources/settings/printing_page/cups_printers.html
[modify] https://crrev.com/1789600ee46dd47e09fa43867cd2af19dfb97a09/chrome/browser/resources/settings/printing_page/cups_printers.js

Labels: smb-native
Status: Fixed (was: Started)
fixed a while ago, never closed bug

Sign in to add a comment