interactive_ui_tests SadTabViewInteractiveUITest.ReloadMultipleSadTabs fails in official builds |
||||
Issue descriptionThis is the only failing test on our ToTWin official bots: https://ci.chromium.org/buildbot/chromium.clang/ToTWin/1591 https://ci.chromium.org/buildbot/chromium.clang/ToTWin64/1556 https://ci.chromium.org/buildbot/chromium.clang/CrWinClangLLD/660 The test logs look like this: [ RUN ] SadTabViewInteractiveUITest.ReloadMultipleSadTabs [7720:7256:0530/140757.173:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062 [7720:8804:0530/140757.188:WARNING:chrome_browser_main_win.cc(630)] Command line too long ... [7720:8804:0530/140757.325:WARNING:sad_tab.cc(276)] Tab Killed: http://127.0.0.1:58602/ [7720:8804:0530/140757.605:WARNING:sad_tab.cc(276)] Tab Killed: http://127.0.0.1:58602/ [7720:1516:0530/140757.727:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico ../../chrome/browser/ui/views/sad_tab_view_interactive_uitest.cc(220): error: Value of: web_contents->IsCrashed() Actual: true Expected: false Stack trace: Backtrace: testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x000000013F1EAF93+87] testing::internal::AssertHelper::operator= [0x000000013F1EAB38+78] SadTabViewInteractiveUITest_ReloadMultipleSadTabs_Test::RunTestOnMainThread [0x000000013F18CFCD+1687] content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x0000000140B07647+477] ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x00000001417B47FD+4697] ChromeBrowserMainParts::PreMainMessageLoopRun [0x00000001417B34A0+182] content::BrowserMainLoop::PreMainMessageLoopRun [0x000000013FAD9497+85] content::StartupTaskRunner::RunAllTasksNow [0x000000013FDE1070+28] content::BrowserMainLoop::CreateStartupTasks [0x000000013FAD7F70+736] content::BrowserMainRunnerImpl::Initialize [0x000000013FADB80F+129] content::BrowserMain [0x000000013FAD5E6D+201] content::RunBrowserProcessMain [0x0000000140AE29BF+139] content::ContentMainRunnerImpl::Run [0x0000000140AE325C+364] service_manager::Main [0x0000000140FFE111+1773] content::ContentMain [0x0000000140AE28D9+65] content::BrowserTestBase::SetUp [0x0000000140B07361+1757] InProcessBrowserTest::SetUp [0x0000000140AFC7A6+434] [7720:8804:0530/140759.022:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [7720:8804:0530/140759.022:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [ FAILED ] SadTabViewInteractiveUITest.ReloadMultipleSadTabs, where TypeParam = and GetParam() = (1883 ms) It looks like Nico enabled these tests here: https://chromium-review.googlesource.com/c/chromium/src/+/1076594 I think we should disable this specific test on Win+Official for now.
,
Aug 14
Unassigning and marking for triage.
,
Nov 19
**UI Mass triage** Seems it's a valid bug.Adding more appropriate label.
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec52747a5abc25a862843edca761104b3c319764 commit ec52747a5abc25a862843edca761104b3c319764 Author: Gabriel Charette <gab@chromium.org> Date: Mon Jan 14 16:16:49 2019 [ui_controls] Unflake Send*NotifyWhenDone() on Windows ui_controls::Send*NotifyWhenDone() can be flaky when invoked after ui_controls::Send*() as the former can decide to notify based on observing a yet-to-be-processed event from the latter (or even a yet-to-be-processed event emitted by unrelated code) and thus notify too early, resuming and testing conditions that have yet to be met. Solution: defer the notification if the system queue has pending events of the same type awaiting dispatch. Note: mouse move can be repeated indefinitely during a drag, as such we consider a mouse move complete when it hits the target regardless of remaining mouse move messages in the queue. @ BUG OWNERS : This might unflake many currently disabled tests. I've CC'ed interactive_ui_tests + Windows bugs, please try to re-enable your test after this CL if you think it might be related. Bug: 892228 , 640996, 897801,893078,876224,875443,873110,852786,850343,848049,846695,840369,798492,756338,751031,665296,651906,499858,468660,419468,238347,131612,106489,97777,92467 Change-Id: I548856a3948ff71a145435799b4ba3e689561f14 Reviewed-on: https://chromium-review.googlesource.com/c/1392178 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#622470} [modify] https://crrev.com/ec52747a5abc25a862843edca761104b3c319764/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc [modify] https://crrev.com/ec52747a5abc25a862843edca761104b3c319764/ui/base/test/ui_controls_internal_win.cc
,
Jan 14
Will try to re-enable in https://chromium-review.googlesource.com/c/chromium/src/+/1409487
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5a992b3037824107e0189e0d911dd3d93bfdd8d commit e5a992b3037824107e0189e0d911dd3d93bfdd8d Author: Gabriel Charette <gab@chromium.org> Date: Mon Jan 14 19:22:31 2019 Attempt to re-enable SadTabViewInteractiveUITest.ReloadMultipleSadTabs https://crrev.com/622470 is expected to have deflaked many interactive_ui_tests, this one having been flaky only in official builds is highly indicative of a race condition; let's give it a shot. R=pkasting@chromium.org Bug: 848049 Change-Id: I7017edf1f11810be351c12bce647ec0ff4638d75 Reviewed-on: https://chromium-review.googlesource.com/c/1409487 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#622546} [modify] https://crrev.com/e5a992b3037824107e0189e0d911dd3d93bfdd8d/chrome/browser/ui/views/sad_tab_view_interactive_uitest.cc
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bd27cf64264b645d6793b3380be18921c87e217 commit 9bd27cf64264b645d6793b3380be18921c87e217 Author: Gabriel Charette <gab@chromium.org> Date: Tue Jan 15 17:04:03 2019 Revert "Attempt to re-enable SadTabViewInteractiveUITest.ReloadMultipleSadTabs" This reverts commit e5a992b3037824107e0189e0d911dd3d93bfdd8d. Reason for revert: test still flaky, same log as OP on bug. Original change's description: > Attempt to re-enable SadTabViewInteractiveUITest.ReloadMultipleSadTabs > > https://crrev.com/622470 is expected to have deflaked many > interactive_ui_tests, this one having been flaky only in official > builds is highly indicative of a race condition; let's give it a shot. > > R=pkasting@chromium.org > > Bug: 848049 > Change-Id: I7017edf1f11810be351c12bce647ec0ff4638d75 > Reviewed-on: https://chromium-review.googlesource.com/c/1409487 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622546} TBR=pkasting@chromium.org,gab@chromium.org Change-Id: I89f4052daf46065c3a4532d52b8c97a6c41c3f26 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 848049 Reviewed-on: https://chromium-review.googlesource.com/c/1411610 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#622870} [modify] https://crrev.com/9bd27cf64264b645d6793b3380be18921c87e217/chrome/browser/ui/views/sad_tab_view_interactive_uitest.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, May 30 2018