New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 848047 link

Starred by 3 users
Status: Fixed
Merged: issue 747952
Owner:
aee@chromium.org
Closed: Jun 2018
Cc:
█ scottchen@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

WebUI: cr-dialog bottom line not always disappearing when scrolled to the bottom.

Project Member Reported by dpa...@chromium.org, May 30 2018 
Repro steps:
1) go to chrome://settings/clearBrowserData
2) Zoom in to 110%
3) Click "advanced" on the CBD dialog.
4) Scroll to the bottom.

Expected (see attachment): The bottom border in the dialog's body should disappear.
Actual: It does not disappear. Note that 100% or 125% zoom behave correctly, which might indicate some rounding error logic with IntersectionObserver.

Also note that adding a 1px bottom border on the dialog's body fixes the issue, which suggests that this was working before r559738, which removed bottom padding on dialog's body.
bottom_scroll_line_present.png
41.7 KB View Download

Comment 1 by dpa...@chromium.org, May 30 2018 

Clarification: The attachment is the actual behavior, not the expected.

Comment 2 Deleted

Comment 3 by dpa...@chromium.org, May 30 2018

Status: Available (was: Duplicate)

Comment 4 by aee@chromium.org, May 30 2018

Cc: -aee@chromium.org
Owner: aee@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9af89fafb16e5b140cd3465039f3d223a07bd85b

commit 9af89fafb16e5b140cd3465039f3d223a07bd85b
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri Jun 01 22:26:16 2018

WebUI: check for intersection with 1px extra margin in case of vertical scroll height rounding errors

Bug:  848047 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ida08ec2b467f98db68a0c2f57348097ed954b36c
Reviewed-on: https://chromium-review.googlesource.com/1081164
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563835}
[modify] https://crrev.com/9af89fafb16e5b140cd3465039f3d223a07bd85b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js

Comment 6 by aee@chromium.org, Jun 1 2018

Status: Fixed (was: Started)
►

Sign in to add a comment