Do something more aggressive with histogram names containing slashes |
|||
Issue descriptionWe currently check that master, bot, and benchmark names do not contain slashes, for histogram uploads. We also sanitize story names, primarily because Telemetry used to do this. We do not currently do any kind of checking or sanitization for histogram names that contain slashes. I think we should either: 1. Sanitize in /add_histograms, or 2. Disallow constructing histograms that have slashes in the name at the Histogram level. Ben, thoughts on which of these two we might prefer?
,
May 30 2018
Sounds great, thanks for your input. I'll get started on that fix. I think, as in other cases where we have library functionality that guarantees well-formedness of HistogramSet JSON, we might also like to sanity check this on the dashboard side.
,
May 30 2018
(Should we make a Speed>TBM2 label, or just use Speed>Telemetry even though TBM2 can be used outside of telemetry?)
,
May 30 2018
Ben Henry, do you have thoughts on a label like Speed>TBM2? I think conceptually, we think of the histogram and metrics systems as distinct from Telemetry and the dashboard. We generally refer to these under the umbrella of "TBM2", and we have a "TBMv2" label on GitHub that we've used for these kinds of bugs in the past.
,
May 30 2018
s/label/component :)
,
May 31 2018
Typically components are team+product descriptive, not technology descriptive. When someone is looking up where to file a bug they have and it's not Speed>Memory, Speed>Loading, etc, will they know to file it at Speed>TBM2 or Speed>TBMv2? Who else will be using these? How will you triage? For the most part, I want to support what works for your team and your users.
,
Nov 12
|
|||
►
Sign in to add a comment |
|||
Comment 1 by benjhayden@chromium.org
, May 30 2018