New issue
Advanced search Search tips

Issue 848018 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Chromevox default action does not trigger PIN keyboard buttons

Project Member Reported by jdufault@chromium.org, May 30 2018

Issue description

Chromevox default action does not trigger PIN keyboard buttons
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e5a163fb6e971b970ca1b62219f5ccdc5f47823

commit 7e5a163fb6e971b970ca1b62219f5ccdc5f47823
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Jun 05 20:39:09 2018

Make chromevox default action simulation go through OnEvent.

A child class (ie, LoginPinView) may override OnEvent and not OnMouseEvent. The
default OnEvent implementation dispatches to OnMouseEvent so existing uses
should remain the same, at the cost of an additional function call.

Bug:  848018 
Change-Id: I20ce712ceadeeda8738eb83d450d9390daedf949
Reviewed-on: https://chromium-review.googlesource.com/1079890
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564649}
[modify] https://crrev.com/7e5a163fb6e971b970ca1b62219f5ccdc5f47823/ui/views/view.cc

Status: Fixed (was: Started)

Sign in to add a comment