New issue
Advanced search Search tips

Issue 847993 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug

Blocking:
issue 847985



Sign in to add a comment

Introduce AuthenticatorRequestClientDelegate

Project Member Reported by engedy@chromium.org, May 30 2018

Issue description

AuthenticatorRequestClientDelegate will serve as the main avenue of communication between the AuthenticatorImpl in //content and the embedder (e.g. //chrome).

It will be used used to:
 -- retrieve contextual information from the embedder required for servicing a WebAuthn request, e.g. whether direct/individual attestation is allowed or whether a frame has focus.

 -- transmit information back and forth that will faciliate showing browser UI during the time of a WebAuthn request.
 

Comment 1 by engedy@chromium.org, May 30 2018

Blocking: 847985
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7ff7098f0d31bf1afbd3d8119dce389165751d9

commit a7ff7098f0d31bf1afbd3d8119dce389165751d9
Author: Balazs Engedy <engedy@chromium.org>
Date: Mon Jun 04 18:14:47 2018

Introduce AuthenticatorRequestClientDelegate.

AuthenticatorRequestClientDelegate will serve as the primary way of
communication between the AuthenticatorImpl in //content and the
embedder (e.g. //chrome).

It will be used to:

 -- Retrieve contextual information from the embedder required for
    servicing a WebAuthn request. For now, this comprises whether
    direct/individual attestation is allowed, and whether the calling
    frame has focus.

 -- In follow-up CLs, to transmit information back and forth needed
    for showing browser UI during the time of a WebAuthn request,
    e.g. to send the embedder the list of discovered devices.

Bug:  847993 
Change-Id: Ied529aadcc44fbcb5ac2da64743d08e3ddcbba1b
Reviewed-on: https://chromium-review.googlesource.com/1013981
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564153}
[modify] https://crrev.com/a7ff7098f0d31bf1afbd3d8119dce389165751d9/chrome/browser/BUILD.gn
[modify] https://crrev.com/a7ff7098f0d31bf1afbd3d8119dce389165751d9/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/a7ff7098f0d31bf1afbd3d8119dce389165751d9/chrome/browser/chrome_content_browser_client.h
[add] https://crrev.com/a7ff7098f0d31bf1afbd3d8119dce389165751d9/chrome/browser/webauthn/OWNERS
[add] https://crrev.com/a7ff7098f0d31bf1afbd3d8119dce389165751d9/chrome/browser/webauthn/chrome_authenticator_request_delegate.cc
[add] https://crrev.com/a7ff7098f0d31bf1afbd3d8119dce389165751d9/chrome/browser/webauthn/chrome_authenticator_request_delegate.h
[modify] https://crrev.com/a7ff7098f0d31bf1afbd3d8119dce389165751d9/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/a7ff7098f0d31bf1afbd3d8119dce389165751d9/content/browser/webauth/authenticator_impl.h
[modify] https://crrev.com/a7ff7098f0d31bf1afbd3d8119dce389165751d9/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/a7ff7098f0d31bf1afbd3d8119dce389165751d9/content/public/browser/BUILD.gn
[add] https://crrev.com/a7ff7098f0d31bf1afbd3d8119dce389165751d9/content/public/browser/authenticator_request_client_delegate.cc
[add] https://crrev.com/a7ff7098f0d31bf1afbd3d8119dce389165751d9/content/public/browser/authenticator_request_client_delegate.h
[modify] https://crrev.com/a7ff7098f0d31bf1afbd3d8119dce389165751d9/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/a7ff7098f0d31bf1afbd3d8119dce389165751d9/content/public/browser/content_browser_client.h

Labels: Hotlist-WebAuthnUI
Status: Fixed (was: Started)

Sign in to add a comment