New issue
Advanced search Search tips

Issue 847992 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Sign in to add a comment

Have non-ash use WindowService while ash is still in process (SingleProcessMash)

Project Member Reported by sky@chromium.org, May 30 2018

Issue description

Currently ChromeOS exclusively uses NativeWidgetAura. For mash/OopAsh the browser side needs to use DesktopNativeWidgetAura. There is a fair amount of changes going into code that is based on NativeWidgetAura in the browser side for ChromeOS (BrowserFrameAsh and related classes). To date we have a separate Mus class (based on DesktopNativeWidgetAura). This means changes need to be replicated in two places, and as a result the two are hugely out of sink. We need to figure out a way to have only one class that is used going forward.

I see two possibilities here:
1. Figure out how to create a DesktopWindowTreeHost that is backed by an aura::Window.
2. Have the browser side use the WindowService for any windows it creates.

1 would likely require significant changes to aura and related classes. It would also likely entail duplicating a fair amount of logic we already have in the WindowService. This work would be throw away once we have oopash.

For these reasons we should investigate 2. It will likely mean we need to a 'context' any where an aura::Window is created (so that WindowPortMus can be created).
 

Comment 1 by sky@chromium.org, May 30 2018

Cc: sadrul@chromium.org

Comment 2 by sky@chromium.org, May 30 2018

Blockedon: 836449
Components: -UI>Shell
Blockedon: 854704 853989
Blockedon: 780160
Blockedon: 837684
Blockedon: 856375
Blockedon: 848022
Summary: Have non-ash use WindowService while ash is still in process (was: Have browser use WindowService while ash is still in process)
Updating summary slightly to make this clearer.
Blockedon: 866942
Blockedon: 866628
Blockedon: 866947
Blockedon: -853989
Blockedon: 867074
Blockedon: 867150
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99df3b2694dd3dab4860e9f20ee5a6235d9746c4

commit 99df3b2694dd3dab4860e9f20ee5a6235d9746c4
Author: Scott Violet <sky@chromium.org>
Date: Wed Aug 08 15:31:13 2018

aura: makes each Window be associated with an Env

This is to avoid using Env::GetInstance(), so that there can be multiple
Envs created at once.

BUG=847992
TEST=covered by tests

Change-Id: I2e2604c8f8a356ca9cc6771ed050ef8431e7b840
Reviewed-on: https://chromium-review.googlesource.com/1165861
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581568}
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/env.cc
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/env_input_state_controller.cc
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/env_input_state_controller.h
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/event_injector.cc
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/local/window_port_local.cc
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/mus/window_tree_host_mus.cc
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/test/event_generator_delegate_aura.cc
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/test/test_screen.cc
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/test/test_windows.cc
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/test/test_windows.h
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/test/ui_controls_factory_aurax11.cc
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/test/ui_controls_factory_ozone.cc
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/window.cc
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/window.h
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/window_event_dispatcher.cc
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/window_event_dispatcher.h
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/window_tree_host.cc
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/window_tree_host.h
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/window_tree_host_platform.cc
[modify] https://crrev.com/99df3b2694dd3dab4860e9f20ee5a6235d9746c4/ui/aura/window_tree_host_platform.h

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9feb99aabc8b58121c23b6edc7c024d5385cc4b7

commit 9feb99aabc8b58121c23b6edc7c024d5385cc4b7
Author: Scott Violet <sky@chromium.org>
Date: Wed Aug 08 17:40:53 2018

wm/views: makes objects using Env take Env

This allows for multiple Envs at the same time. Additionally:
. NativeWidgetPrivate::CreateNativeWidget: now takes InitParams
. NativeWidgetPrivate::IsMouseButtonDown() is now an member function.

BUG=847992
TEST=covered by tests

Change-Id: Ic35b274c0a927a7c602809a7e611383b5d3dd3e2
Reviewed-on: https://chromium-review.googlesource.com/1166148
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581621}
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/aura/window.h
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/views/controls/native/native_view_host_aura.cc
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/views/controls/native/native_view_host_aura.h
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/views/controls/native/native_view_host_aura_unittest.cc
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/views/widget/desktop_aura/desktop_native_widget_aura.h
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/views/widget/native_widget.h
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/views/widget/native_widget_aura.cc
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/views/widget/native_widget_aura.h
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/views/widget/native_widget_mac.h
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/views/widget/native_widget_mac.mm
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/views/widget/native_widget_private.h
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/views/widget/widget.cc
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/wm/core/compound_event_filter.cc
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/wm/core/easy_resize_window_targeter.cc
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/wm/core/shadow_controller.cc
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/wm/core/shadow_controller.h
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/wm/core/window_modality_controller.cc
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/wm/core/window_modality_controller.h
[modify] https://crrev.com/9feb99aabc8b58121c23b6edc7c024d5385cc4b7/ui/wm/core/wm_state.h

Blockedon: 872365
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04308f3df2ca0d062114eb938691e59137660775

commit 04308f3df2ca0d062114eb938691e59137660775
Author: Scott Violet <sky@chromium.org>
Date: Wed Aug 08 22:00:33 2018

window-service: makes objects using Env take Env (or get from WindowService)

This allows for multiple Envs at the same time.

BUG=847992
TEST=covered by tests

Change-Id: I20dda0f7e3fde50027c9c867562718e49152d238
Reviewed-on: https://chromium-review.googlesource.com/1167654
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581701}
[modify] https://crrev.com/04308f3df2ca0d062114eb938691e59137660775/services/ui/ws2/client_root.cc
[modify] https://crrev.com/04308f3df2ca0d062114eb938691e59137660775/services/ui/ws2/injected_event_handler.cc
[modify] https://crrev.com/04308f3df2ca0d062114eb938691e59137660775/services/ui/ws2/pointer_watcher.cc
[modify] https://crrev.com/04308f3df2ca0d062114eb938691e59137660775/services/ui/ws2/server_window.cc
[modify] https://crrev.com/04308f3df2ca0d062114eb938691e59137660775/services/ui/ws2/user_activity_monitor.cc
[modify] https://crrev.com/04308f3df2ca0d062114eb938691e59137660775/services/ui/ws2/user_activity_monitor.h
[modify] https://crrev.com/04308f3df2ca0d062114eb938691e59137660775/services/ui/ws2/user_activity_monitor_unittest.cc
[modify] https://crrev.com/04308f3df2ca0d062114eb938691e59137660775/services/ui/ws2/window_service.cc
[modify] https://crrev.com/04308f3df2ca0d062114eb938691e59137660775/services/ui/ws2/window_service.h
[modify] https://crrev.com/04308f3df2ca0d062114eb938691e59137660775/services/ui/ws2/window_tree.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93a3a4b3d32211b674e56b0968f850905fb9238d

commit 93a3a4b3d32211b674e56b0968f850905fb9238d
Author: Scott Violet <sky@chromium.org>
Date: Wed Aug 08 23:02:30 2018

Revert "window-service: makes objects using Env take Env (or get from WindowService)"

This reverts commit 04308f3df2ca0d062114eb938691e59137660775.

Reason for revert: Patch earlier in the chain caused failures on msan bot.

Original change's description:
> window-service: makes objects using Env take Env (or get from WindowService)
> 
> This allows for multiple Envs at the same time.
> 
> BUG=847992
> TEST=covered by tests
> 
> Change-Id: I20dda0f7e3fde50027c9c867562718e49152d238
> Reviewed-on: https://chromium-review.googlesource.com/1167654
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581701}

TBR=sky@chromium.org,msw@chromium.org

Change-Id: If149ac9dc90f0ef6cec5e59f744cd0c3189d01e6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847992
Reviewed-on: https://chromium-review.googlesource.com/1168402
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581715}
[modify] https://crrev.com/93a3a4b3d32211b674e56b0968f850905fb9238d/services/ui/ws2/client_root.cc
[modify] https://crrev.com/93a3a4b3d32211b674e56b0968f850905fb9238d/services/ui/ws2/injected_event_handler.cc
[modify] https://crrev.com/93a3a4b3d32211b674e56b0968f850905fb9238d/services/ui/ws2/pointer_watcher.cc
[modify] https://crrev.com/93a3a4b3d32211b674e56b0968f850905fb9238d/services/ui/ws2/server_window.cc
[modify] https://crrev.com/93a3a4b3d32211b674e56b0968f850905fb9238d/services/ui/ws2/user_activity_monitor.cc
[modify] https://crrev.com/93a3a4b3d32211b674e56b0968f850905fb9238d/services/ui/ws2/user_activity_monitor.h
[modify] https://crrev.com/93a3a4b3d32211b674e56b0968f850905fb9238d/services/ui/ws2/user_activity_monitor_unittest.cc
[modify] https://crrev.com/93a3a4b3d32211b674e56b0968f850905fb9238d/services/ui/ws2/window_service.cc
[modify] https://crrev.com/93a3a4b3d32211b674e56b0968f850905fb9238d/services/ui/ws2/window_service.h
[modify] https://crrev.com/93a3a4b3d32211b674e56b0968f850905fb9238d/services/ui/ws2/window_tree.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07aab203cab863a00744ef6598091dde9741ba17

commit 07aab203cab863a00744ef6598091dde9741ba17
Author: Scott Violet <sky@chromium.org>
Date: Wed Aug 08 23:04:31 2018

Revert "wm/views: makes objects using Env take Env"

This reverts commit 9feb99aabc8b58121c23b6edc7c024d5385cc4b7.

Reason for revert: a patch earlier in the chain caused msan failures.

Original change's description:
> wm/views: makes objects using Env take Env
> 
> This allows for multiple Envs at the same time. Additionally:
> . NativeWidgetPrivate::CreateNativeWidget: now takes InitParams
> . NativeWidgetPrivate::IsMouseButtonDown() is now an member function.
> 
> BUG=847992
> TEST=covered by tests
> 
> Change-Id: Ic35b274c0a927a7c602809a7e611383b5d3dd3e2
> Reviewed-on: https://chromium-review.googlesource.com/1166148
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581621}

TBR=sky@chromium.org,msw@chromium.org

Change-Id: I9410bf471a71d07b32f49a139b7afa9ced0f3fea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847992
Reviewed-on: https://chromium-review.googlesource.com/1168403
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581716}
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/aura/window.h
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/views/controls/native/native_view_host_aura.cc
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/views/controls/native/native_view_host_aura.h
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/views/controls/native/native_view_host_aura_unittest.cc
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/views/widget/desktop_aura/desktop_native_widget_aura.h
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/views/widget/native_widget.h
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/views/widget/native_widget_aura.cc
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/views/widget/native_widget_aura.h
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/views/widget/native_widget_mac.h
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/views/widget/native_widget_mac.mm
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/views/widget/native_widget_private.h
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/views/widget/widget.cc
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/wm/core/compound_event_filter.cc
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/wm/core/easy_resize_window_targeter.cc
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/wm/core/shadow_controller.cc
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/wm/core/shadow_controller.h
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/wm/core/window_modality_controller.cc
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/wm/core/window_modality_controller.h
[modify] https://crrev.com/07aab203cab863a00744ef6598091dde9741ba17/ui/wm/core/wm_state.h

Project Member

Comment 22 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c179496f2b0ebc20360350c65aff0c4941c57e26

commit c179496f2b0ebc20360350c65aff0c4941c57e26
Author: Scott Violet <sky@chromium.org>
Date: Wed Aug 08 23:05:51 2018

Revert "aura: makes each Window be associated with an Env"

This reverts commit 99df3b2694dd3dab4860e9f20ee5a6235d9746c4.

Reason for revert: Caused failures on msan bot.

Original change's description:
> aura: makes each Window be associated with an Env
> 
> This is to avoid using Env::GetInstance(), so that there can be multiple
> Envs created at once.
> 
> BUG=847992
> TEST=covered by tests
> 
> Change-Id: I2e2604c8f8a356ca9cc6771ed050ef8431e7b840
> Reviewed-on: https://chromium-review.googlesource.com/1165861
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581568}

TBR=sky@chromium.org,msw@chromium.org

Change-Id: I50fb5f0d27011219ed2569b1035a78e01b9b3de9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847992
Reviewed-on: https://chromium-review.googlesource.com/1168323
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581718}
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/env.cc
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/env_input_state_controller.cc
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/env_input_state_controller.h
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/event_injector.cc
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/local/window_port_local.cc
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/mus/window_tree_host_mus.cc
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/test/event_generator_delegate_aura.cc
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/test/test_screen.cc
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/test/test_windows.cc
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/test/test_windows.h
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/test/ui_controls_factory_aurax11.cc
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/test/ui_controls_factory_ozone.cc
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/window.cc
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/window.h
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/window_event_dispatcher.cc
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/window_event_dispatcher.h
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/window_tree_host.cc
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/window_tree_host.h
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/window_tree_host_platform.cc
[modify] https://crrev.com/c179496f2b0ebc20360350c65aff0c4941c57e26/ui/aura/window_tree_host_platform.h

Project Member

Comment 23 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72a83a6c2276e5afcec4f87f2edad760a4809a20

commit 72a83a6c2276e5afcec4f87f2edad760a4809a20
Author: Scott Violet <sky@chromium.org>
Date: Thu Aug 09 04:52:32 2018

views: changes test to not use equality

This test was assuming a newly created Window got a pointer value different
than one recently destroyed. For whatever reason my recent patch made it more
likely (on the msan bot) that the newly created pointer got the same value as
the one destroyed, leading to failure.

I'm converting the test to verify the window is destroyed using a WindowTracker.

BUG=847992
TEST=covered by tests

Change-Id: I4f9f64ad59ae15b0314619a93935d7e85bb6d8e7
Reviewed-on: https://chromium-review.googlesource.com/1168466
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581788}
[modify] https://crrev.com/72a83a6c2276e5afcec4f87f2edad760a4809a20/ui/views/mus/remote_view/remote_view_provider_unittest.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3882e0ffa9cba6dd8b608d31f082d7a56a362cad

commit 3882e0ffa9cba6dd8b608d31f082d7a56a362cad
Author: Scott Violet <sky@chromium.org>
Date: Thu Aug 09 05:05:18 2018

Revert "views: changes test to not use equality"

This reverts commit 72a83a6c2276e5afcec4f87f2edad760a4809a20.

Reason for revert: The text failure was fixed at https://chromium-review.googlesource.com/c/chromium/src/+/1168466 . The failure was a side effect of my change and a lingering issue, so reverting the revert.

Original change's description:
> views: changes test to not use equality
> 
> This test was assuming a newly created Window got a pointer value different
> than one recently destroyed. For whatever reason my recent patch made it more
> likely (on the msan bot) that the newly created pointer got the same value as
> the one destroyed, leading to failure.
> 
> I'm converting the test to verify the window is destroyed using a WindowTracker.
> 
> BUG=847992
> TEST=covered by tests
> 
> Change-Id: I4f9f64ad59ae15b0314619a93935d7e85bb6d8e7
> Reviewed-on: https://chromium-review.googlesource.com/1168466
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581788}

TBR=sky@chromium.org,msw@chromium.org

Change-Id: I902ae7e85e8a40e5d682a332b2a7171eb233c300
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847992
Reviewed-on: https://chromium-review.googlesource.com/1168762
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581791}
[modify] https://crrev.com/3882e0ffa9cba6dd8b608d31f082d7a56a362cad/ui/views/mus/remote_view/remote_view_provider_unittest.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f63136f8c4f7d0246552b4383d24ff39f9d22d64

commit f63136f8c4f7d0246552b4383d24ff39f9d22d64
Author: Scott Violet <sky@chromium.org>
Date: Thu Aug 09 05:07:19 2018

Reland "views: changes test to not use equality"

This reverts commit 3882e0ffa9cba6dd8b608d31f082d7a56a362cad.

Reason for revert: *SIGH* reverted wrong revert, relanding.

Original change's description:
> Revert "views: changes test to not use equality"
> 
> This reverts commit 72a83a6c2276e5afcec4f87f2edad760a4809a20.
> 
> Reason for revert: The text failure was fixed at https://chromium-review.googlesource.com/c/chromium/src/+/1168466 . The failure was a side effect of my change and a lingering issue, so reverting the revert.
> 
> Original change's description:
> > views: changes test to not use equality
> > 
> > This test was assuming a newly created Window got a pointer value different
> > than one recently destroyed. For whatever reason my recent patch made it more
> > likely (on the msan bot) that the newly created pointer got the same value as
> > the one destroyed, leading to failure.
> > 
> > I'm converting the test to verify the window is destroyed using a WindowTracker.
> > 
> > BUG=847992
> > TEST=covered by tests
> > 
> > Change-Id: I4f9f64ad59ae15b0314619a93935d7e85bb6d8e7
> > Reviewed-on: https://chromium-review.googlesource.com/1168466
> > Reviewed-by: Michael Wasserman <msw@chromium.org>
> > Commit-Queue: Scott Violet <sky@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581788}
> 
> TBR=sky@chromium.org,msw@chromium.org
> 
> Change-Id: I902ae7e85e8a40e5d682a332b2a7171eb233c300
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 847992
> Reviewed-on: https://chromium-review.googlesource.com/1168762
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581791}

TBR=sky@chromium.org,msw@chromium.org

Change-Id: I3f26795a5a5959ad38949cc451591f34539f2141
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847992
Reviewed-on: https://chromium-review.googlesource.com/1168763
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581792}
[modify] https://crrev.com/f63136f8c4f7d0246552b4383d24ff39f9d22d64/ui/views/mus/remote_view/remote_view_provider_unittest.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/365291668a120bbac0b5bf216504145b4de1c2ad

commit 365291668a120bbac0b5bf216504145b4de1c2ad
Author: Scott Violet <sky@chromium.org>
Date: Thu Aug 09 05:09:32 2018

Reland "aura: makes each Window be associated with an Env"

This reverts commit c179496f2b0ebc20360350c65aff0c4941c57e26.

Reason for revert: The test failure was fixed at https://chromium-review.googlesource.com/c/chromium/src/+/1168466 . The failure was a lingering issue and not caused by patch (but triggered by my patch), so reverting the revert.

Original change's description:
> Revert "aura: makes each Window be associated with an Env"
> 
> This reverts commit 99df3b2694dd3dab4860e9f20ee5a6235d9746c4.
> 
> Reason for revert: Caused failures on msan bot.
> 
> Original change's description:
> > aura: makes each Window be associated with an Env
> > 
> > This is to avoid using Env::GetInstance(), so that there can be multiple
> > Envs created at once.
> > 
> > BUG=847992
> > TEST=covered by tests
> > 
> > Change-Id: I2e2604c8f8a356ca9cc6771ed050ef8431e7b840
> > Reviewed-on: https://chromium-review.googlesource.com/1165861
> > Commit-Queue: Scott Violet <sky@chromium.org>
> > Reviewed-by: Michael Wasserman <msw@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581568}
> 
> TBR=sky@chromium.org,msw@chromium.org
> 
> Change-Id: I50fb5f0d27011219ed2569b1035a78e01b9b3de9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 847992
> Reviewed-on: https://chromium-review.googlesource.com/1168323
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581718}

TBR=sky@chromium.org,msw@chromium.org

Change-Id: I83e61d6ca9de8dcd023757f03bb18f0abf09790e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847992
Reviewed-on: https://chromium-review.googlesource.com/1168565
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581796}
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/env.cc
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/env_input_state_controller.cc
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/env_input_state_controller.h
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/event_injector.cc
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/local/window_port_local.cc
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/mus/window_tree_host_mus.cc
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/test/event_generator_delegate_aura.cc
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/test/test_screen.cc
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/test/test_windows.cc
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/test/test_windows.h
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/test/ui_controls_factory_aurax11.cc
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/test/ui_controls_factory_ozone.cc
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/window.cc
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/window.h
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/window_event_dispatcher.cc
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/window_event_dispatcher.h
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/window_tree_host.cc
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/window_tree_host.h
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/window_tree_host_platform.cc
[modify] https://crrev.com/365291668a120bbac0b5bf216504145b4de1c2ad/ui/aura/window_tree_host_platform.h

Project Member

Comment 27 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca

commit b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca
Author: Scott Violet <sky@chromium.org>
Date: Thu Aug 09 05:10:29 2018

Reland "wm/views: makes objects using Env take Env"

This reverts commit 07aab203cab863a00744ef6598091dde9741ba17.

Reason for revert: msan issue was fixed and landed (and wasn't triggered by this patch). Reverting the revert to reland.

Original change's description:
> Revert "wm/views: makes objects using Env take Env"
> 
> This reverts commit 9feb99aabc8b58121c23b6edc7c024d5385cc4b7.
> 
> Reason for revert: a patch earlier in the chain caused msan failures.
> 
> Original change's description:
> > wm/views: makes objects using Env take Env
> > 
> > This allows for multiple Envs at the same time. Additionally:
> > . NativeWidgetPrivate::CreateNativeWidget: now takes InitParams
> > . NativeWidgetPrivate::IsMouseButtonDown() is now an member function.
> > 
> > BUG=847992
> > TEST=covered by tests
> > 
> > Change-Id: Ic35b274c0a927a7c602809a7e611383b5d3dd3e2
> > Reviewed-on: https://chromium-review.googlesource.com/1166148
> > Commit-Queue: Scott Violet <sky@chromium.org>
> > Reviewed-by: Michael Wasserman <msw@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581621}
> 
> TBR=sky@chromium.org,msw@chromium.org
> 
> Change-Id: I9410bf471a71d07b32f49a139b7afa9ced0f3fea
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 847992
> Reviewed-on: https://chromium-review.googlesource.com/1168403
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581716}

TBR=sky@chromium.org,msw@chromium.org

Change-Id: I1fcd75fb66d00693dfc2e0b78e871848a335319a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847992
Reviewed-on: https://chromium-review.googlesource.com/1168566
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581797}
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/aura/window.h
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/views/controls/native/native_view_host_aura.cc
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/views/controls/native/native_view_host_aura.h
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/views/controls/native/native_view_host_aura_unittest.cc
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/views/widget/desktop_aura/desktop_native_widget_aura.h
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/views/widget/native_widget.h
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/views/widget/native_widget_aura.cc
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/views/widget/native_widget_aura.h
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/views/widget/native_widget_mac.h
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/views/widget/native_widget_mac.mm
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/views/widget/native_widget_private.h
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/views/widget/widget.cc
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/wm/core/compound_event_filter.cc
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/wm/core/easy_resize_window_targeter.cc
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/wm/core/shadow_controller.cc
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/wm/core/shadow_controller.h
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/wm/core/window_modality_controller.cc
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/wm/core/window_modality_controller.h
[modify] https://crrev.com/b283bc8a7e975fc51d7ce993ba9027d5e6bd69ca/ui/wm/core/wm_state.h

Project Member

Comment 28 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d87c9b19c62dc1722b85a0df53cf5f76c0a5da14

commit d87c9b19c62dc1722b85a0df53cf5f76c0a5da14
Author: Scott Violet <sky@chromium.org>
Date: Thu Aug 09 05:12:45 2018

Reland "window-service: makes objects using Env take Env (or get from WindowService)"

This reverts commit 93a3a4b3d32211b674e56b0968f850905fb9238d.

Reason for revert: msan issue was fixed and landed (and wasn't triggered by this patch). Reverting the revert to reland.

Original change's description:
> Revert "window-service: makes objects using Env take Env (or get from WindowService)"
> 
> This reverts commit 04308f3df2ca0d062114eb938691e59137660775.
> 
> Reason for revert: Patch earlier in the chain caused failures on msan bot.
> 
> Original change's description:
> > window-service: makes objects using Env take Env (or get from WindowService)
> > 
> > This allows for multiple Envs at the same time.
> > 
> > BUG=847992
> > TEST=covered by tests
> > 
> > Change-Id: I20dda0f7e3fde50027c9c867562718e49152d238
> > Reviewed-on: https://chromium-review.googlesource.com/1167654
> > Reviewed-by: Michael Wasserman <msw@chromium.org>
> > Commit-Queue: Scott Violet <sky@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581701}
> 
> TBR=sky@chromium.org,msw@chromium.org
> 
> Change-Id: If149ac9dc90f0ef6cec5e59f744cd0c3189d01e6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 847992
> Reviewed-on: https://chromium-review.googlesource.com/1168402
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581715}

TBR=sky@chromium.org,msw@chromium.org

Change-Id: Id10e4d33b7cf619b4e14f1ed4c8f604cd2c96591
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847992
Reviewed-on: https://chromium-review.googlesource.com/1168326
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581798}
[modify] https://crrev.com/d87c9b19c62dc1722b85a0df53cf5f76c0a5da14/services/ui/ws2/client_root.cc
[modify] https://crrev.com/d87c9b19c62dc1722b85a0df53cf5f76c0a5da14/services/ui/ws2/injected_event_handler.cc
[modify] https://crrev.com/d87c9b19c62dc1722b85a0df53cf5f76c0a5da14/services/ui/ws2/pointer_watcher.cc
[modify] https://crrev.com/d87c9b19c62dc1722b85a0df53cf5f76c0a5da14/services/ui/ws2/server_window.cc
[modify] https://crrev.com/d87c9b19c62dc1722b85a0df53cf5f76c0a5da14/services/ui/ws2/user_activity_monitor.cc
[modify] https://crrev.com/d87c9b19c62dc1722b85a0df53cf5f76c0a5da14/services/ui/ws2/user_activity_monitor.h
[modify] https://crrev.com/d87c9b19c62dc1722b85a0df53cf5f76c0a5da14/services/ui/ws2/user_activity_monitor_unittest.cc
[modify] https://crrev.com/d87c9b19c62dc1722b85a0df53cf5f76c0a5da14/services/ui/ws2/window_service.cc
[modify] https://crrev.com/d87c9b19c62dc1722b85a0df53cf5f76c0a5da14/services/ui/ws2/window_service.h
[modify] https://crrev.com/d87c9b19c62dc1722b85a0df53cf5f76c0a5da14/services/ui/ws2/window_tree.cc

Can you update the bug description to have a link to your ddoc? That will make it easier for reviewers for CLs that mention this bug.
Summary: Have non-ash use WindowService while ash is still in process (SingleProcessMash) (was: Have non-ash use WindowService while ash is still in process)
Design doc is here: https://docs.google.com/document/d/11ha_KioDdXe4iZS2AML1foKnCJlNKm7Q1hFr6VW8dV4/edit .
Project Member

Comment 31 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13de50d7deff3e0f2d0682a05441656c81f6a8eb

commit 13de50d7deff3e0f2d0682a05441656c81f6a8eb
Author: Scott Violet <sky@chromium.org>
Date: Fri Aug 10 20:07:11 2018

exo: pass in Envs when creating aura::Windows

As part of the mash work we're going to have multiple aura::Envs at the same
time. Code that may run in Ash now gets the Env from aura::Window, rather than
using Env's static GetInstance(). This patch converts exo to remember the
Env so that it can get the right one.

BUG=847992
TEST=covered by tests

Change-Id: I5fd1c6120868b3847ccd68a063039eec5b54a3b6
Reviewed-on: https://chromium-review.googlesource.com/1169590
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582303}
[modify] https://crrev.com/13de50d7deff3e0f2d0682a05441656c81f6a8eb/ash/keyboard/arc/arc_input_method_surface_manager_unittest.cc
[modify] https://crrev.com/13de50d7deff3e0f2d0682a05441656c81f6a8eb/ash/system/message_center/arc/arc_notification_content_view_unittest.cc
[modify] https://crrev.com/13de50d7deff3e0f2d0682a05441656c81f6a8eb/ash/wayland/wayland_server_controller.cc
[modify] https://crrev.com/13de50d7deff3e0f2d0682a05441656c81f6a8eb/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
[modify] https://crrev.com/13de50d7deff3e0f2d0682a05441656c81f6a8eb/components/exo/buffer.cc
[modify] https://crrev.com/13de50d7deff3e0f2d0682a05441656c81f6a8eb/components/exo/shell_surface.cc
[modify] https://crrev.com/13de50d7deff3e0f2d0682a05441656c81f6a8eb/components/exo/surface.cc
[modify] https://crrev.com/13de50d7deff3e0f2d0682a05441656c81f6a8eb/components/exo/surface_tree_host.cc
[modify] https://crrev.com/13de50d7deff3e0f2d0682a05441656c81f6a8eb/components/exo/surface_unittest.cc
[modify] https://crrev.com/13de50d7deff3e0f2d0682a05441656c81f6a8eb/components/exo/test/exo_test_base.cc
[modify] https://crrev.com/13de50d7deff3e0f2d0682a05441656c81f6a8eb/components/exo/test/exo_test_helper.cc
[modify] https://crrev.com/13de50d7deff3e0f2d0682a05441656c81f6a8eb/components/exo/wayland/clients/test/wayland_client_test.cc
[modify] https://crrev.com/13de50d7deff3e0f2d0682a05441656c81f6a8eb/components/exo/wm_helper.cc
[modify] https://crrev.com/13de50d7deff3e0f2d0682a05441656c81f6a8eb/components/exo/wm_helper.h

Project Member

Comment 32 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/786483cac1c90efd081159a9843e96aee5d32cbf

commit 786483cac1c90efd081159a9843e96aee5d32cbf
Author: Scott Violet <sky@chromium.org>
Date: Fri Aug 10 20:47:29 2018

ash: enforce that all Widgets have a context/parent when created

This will be important for SingleProcessMash as the context/parent is
needed to properly create the NativeWidgetDelegate. In particular
NativeWidgetAura's constructor takes an Env that comes from either the
context or parent. We need to ensure code in Ash sets that properly so that
the right Env is used.

BUG=847992
TEST=covered by tests

Change-Id: I2876ac862e00c4f03a7c328230db372f5d74a005
Reviewed-on: https://chromium-review.googlesource.com/1171204
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582322}
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/assistant/ui/assistant_container_view.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/components/shortcut_viewer/DEPS
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/components/shortcut_viewer/shortcut_viewer_application.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/components/shortcut_viewer/views/keyboard_shortcut_view.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/components/shortcut_viewer/views/keyboard_shortcut_view.h
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/components/shortcut_viewer/views/keyboard_shortcut_view_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/display/shared_display_edge_indicator.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/drag_drop/drag_drop_controller_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/drag_drop/drag_drop_interactive_uitest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/drag_drop/drag_image_view.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/extended_desktop_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/focus_cycler_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/frame/caption_buttons/frame_size_button_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/keyboard/arc/arc_input_method_surface_manager_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/message_center/message_center_view_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/message_center/message_list_view_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/shell_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/test/ash_test_helper_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/test/ash_test_views_delegate.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/test/ash_test_views_delegate.h
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/wm/immersive_fullscreen_controller_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/wm/lock_layout_manager_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/wm/overview/cleanup_animation_observer_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/wm/splitview/split_view_controller_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/wm/test_child_modal_parent.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/wm/test_child_modal_parent.h
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/wm/window_modality_controller_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/chrome/browser/ui/ash/ksv/DEPS
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_util.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
[modify] https://crrev.com/786483cac1c90efd081159a9843e96aee5d32cbf/chrome/test/base/browser_with_test_window_test.cc

Project Member

Comment 33 by bugdroid1@chromium.org, Aug 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b092ae622b9ab3856d64d3eca543e4ecb243be77

commit b092ae622b9ab3856d64d3eca543e4ecb243be77
Author: Scott Violet <sky@chromium.org>
Date: Sat Aug 11 01:14:35 2018

chromeos: add SingleProcessMash mode

This makes Ash create an Env if passed SingleProcessMash. In addition this
makes all window creation go through a factory that ensures the right env is
supplied.

See https://docs.google.com/document/d/11ha_KioDdXe4iZS2AML1foKnCJlNKm7Q1hFr6VW8dV4/edit
for more details.

This also adds the feature to ui/base.

BUG=847992
TEST=covered by tests

Change-Id: Ica3c433627222f0e076dddaf19b1ab09168cebeb
Reviewed-on: https://chromium-review.googlesource.com/1168282
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582411}
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/BUILD.gn
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/README.md
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/app_launch_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/ash_service_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/components/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/display/cursor_window_controller.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/display/display_util.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/display/mirror_window_controller.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/display/mouse_cursor_event_filter_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/display/root_window_transformers_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/display/screen_ash.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/display/screen_position_controller_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/display/unified_mouse_warp_controller_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/drag_drop/drag_drop_tracker.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/events/event_rewriter_controller.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/extended_desktop_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/frame/detached_title_area_renderer.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/frame/header_view.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/host/DEPS
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/host/ash_window_tree_host.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/host/ash_window_tree_host_platform.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/keyboard/arc/arc_input_method_surface_manager_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/keyboard/test_keyboard_ui.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/magnifier/docked_magnifier_controller.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/magnifier/magnification_controller_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/metrics/desktop_task_switch_metric_recorder_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/public/cpp/frame_border_hit_test.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/root_window_controller.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/shell.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/shell.h
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/shell_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/system/message_center/arc/arc_notification_content_view_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/system/message_center/arc/arc_notification_view_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/system/message_center/arc/mock_arc_notification_surface.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/system/message_center/arc/mock_arc_notification_surface.h
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/system/night_light/night_light_controller.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/test/ash_test_base.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/test/ash_test_helper.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/test/ash_test_suite.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/test/ui_controls_factory_ash.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/utility/screenshot_controller_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wayland/wayland_server_controller.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wayland/wayland_server_controller.h
[add] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/window_factory.cc
[add] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/window_factory.h
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/window_user_data_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/ash_focus_rules_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/cursor_manager_chromeos.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/drag_window_controller.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/drag_window_resizer_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/immersive_fullscreen_controller_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/native_cursor_manager_ash_classic.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/non_client_frame_controller.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/stacking_controller_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/system_gesture_event_filter_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/system_modal_container_layout_manager_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/top_level_window_factory.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/toplevel_window_event_handler.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/toplevel_window_event_handler_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/video_detector.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/window_dimmer.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/window_dimmer_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/workspace/workspace_event_handler_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/wm/workspace_controller_unittest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ash/ws/window_service_owner.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/chrome/browser/ui/ash/ksv/DEPS
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_util.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/components/exo/test/exo_test_base.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/components/exo/wayland/clients/test/wayland_client_test.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ui/aura/env.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ui/aura/env.h
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ui/aura/test/test_windows.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ui/aura/test/test_windows.h
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ui/aura/window.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ui/aura/window.h
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ui/aura/window_tree_host_platform.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ui/base/ui_base_features.cc
[modify] https://crrev.com/b092ae622b9ab3856d64d3eca543e4ecb243be77/ui/base/ui_base_features.h

Project Member

Comment 34 by bugdroid1@chromium.org, Aug 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39e00c42d85fedf2a20f7ee4889a7f101def4975

commit 39e00c42d85fedf2a20f7ee4889a7f101def4975
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Sat Aug 11 03:38:31 2018

Revert "chromeos: add SingleProcessMash mode"

This reverts commit b092ae622b9ab3856d64d3eca543e4ecb243be77.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 582411 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2IwOTJhZTYyMmI5YWIzODU2ZDY0ZDNlY2E1NDNlNGVjYjI0M2JlNzcM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/7241

Sample Failed Step: ash_content_unittests

Original change's description:
> chromeos: add SingleProcessMash mode
> 
> This makes Ash create an Env if passed SingleProcessMash. In addition this
> makes all window creation go through a factory that ensures the right env is
> supplied.
> 
> See https://docs.google.com/document/d/11ha_KioDdXe4iZS2AML1foKnCJlNKm7Q1hFr6VW8dV4/edit
> for more details.
> 
> This also adds the feature to ui/base.
> 
> BUG=847992
> TEST=covered by tests
> 
> Change-Id: Ica3c433627222f0e076dddaf19b1ab09168cebeb
> Reviewed-on: https://chromium-review.googlesource.com/1168282
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582411}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=847992

Change-Id: I9e2e3c0d92dc7b51f08fa35a2dfacd5ca8af57f2
Reviewed-on: https://chromium-review.googlesource.com/1171706
Cr-Commit-Position: refs/heads/master@{#582427}
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/BUILD.gn
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/README.md
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/app_launch_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/ash_service_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/components/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/display/cursor_window_controller.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/display/display_util.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/display/mirror_window_controller.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/display/mouse_cursor_event_filter_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/display/root_window_transformers_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/display/screen_ash.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/display/screen_position_controller_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/display/unified_mouse_warp_controller_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/drag_drop/drag_drop_tracker.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/events/event_rewriter_controller.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/extended_desktop_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/frame/detached_title_area_renderer.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/frame/header_view.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/host/DEPS
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/host/ash_window_tree_host.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/host/ash_window_tree_host_platform.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/keyboard/arc/arc_input_method_surface_manager_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/keyboard/test_keyboard_ui.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/magnifier/docked_magnifier_controller.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/magnifier/magnification_controller_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/metrics/desktop_task_switch_metric_recorder_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/public/cpp/frame_border_hit_test.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/root_window_controller.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/shell.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/shell.h
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/shell_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/system/message_center/arc/arc_notification_content_view_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/system/message_center/arc/arc_notification_view_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/system/message_center/arc/mock_arc_notification_surface.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/system/message_center/arc/mock_arc_notification_surface.h
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/system/night_light/night_light_controller.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/test/ash_test_base.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/test/ash_test_helper.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/test/ash_test_suite.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/test/ui_controls_factory_ash.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/utility/screenshot_controller_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wayland/wayland_server_controller.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wayland/wayland_server_controller.h
[delete] https://crrev.com/490c27babbe440762253c71c8ddc2438d3814d0e/ash/window_factory.cc
[delete] https://crrev.com/490c27babbe440762253c71c8ddc2438d3814d0e/ash/window_factory.h
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/window_user_data_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/ash_focus_rules_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/cursor_manager_chromeos.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/drag_window_controller.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/drag_window_resizer_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/immersive_fullscreen_controller_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/native_cursor_manager_ash_classic.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/non_client_frame_controller.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/stacking_controller_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/system_gesture_event_filter_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/system_modal_container_layout_manager_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/top_level_window_factory.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/toplevel_window_event_handler.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/toplevel_window_event_handler_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/video_detector.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/window_dimmer.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/window_dimmer_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/workspace/workspace_event_handler_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/wm/workspace_controller_unittest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ash/ws/window_service_owner.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/chrome/browser/ui/ash/ksv/DEPS
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_util.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/components/exo/test/exo_test_base.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/components/exo/wayland/clients/test/wayland_client_test.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ui/aura/env.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ui/aura/env.h
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ui/aura/test/test_windows.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ui/aura/test/test_windows.h
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ui/aura/window.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ui/aura/window.h
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ui/aura/window_tree_host_platform.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ui/base/ui_base_features.cc
[modify] https://crrev.com/39e00c42d85fedf2a20f7ee4889a7f101def4975/ui/base/ui_base_features.h

Project Member

Comment 35 by bugdroid1@chromium.org, Aug 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac410622018078a68a7677a5ae89c2f51afafa92

commit ac410622018078a68a7677a5ae89c2f51afafa92
Author: Scott Violet <sky@chromium.org>
Date: Sat Aug 11 18:33:22 2018

reland: chromeos: add SingleProcessMash mode

This makes Ash create an Env if passed SingleProcessMash. In addition this
makes all window creation go through a factory that ensures the right env is
supplied.

See https://docs.google.com/document/d/11ha_KioDdXe4iZS2AML1foKnCJlNKm7Q1hFr6VW8dV4/edit
for more details.

This also adds the feature to ui/base.

BUG=847992
TEST=covered by tests
TBR=jamescook@chromium.org

Change-Id: I446ba2dd7a05702cfca41a0e0d657d6606cc28e5
Reviewed-on: https://chromium-review.googlesource.com/1172054
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582454}
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/BUILD.gn
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/README.md
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/app_launch_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/ash_service_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/components/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/content/display/screen_orientation_controller_chromeos_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/display/cursor_window_controller.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/display/display_util.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/display/mirror_window_controller.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/display/mouse_cursor_event_filter_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/display/root_window_transformers_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/display/screen_ash.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/display/screen_position_controller_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/display/unified_mouse_warp_controller_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/drag_drop/drag_drop_tracker.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/events/event_rewriter_controller.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/extended_desktop_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/frame/detached_title_area_renderer.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/frame/header_view.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/host/DEPS
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/host/ash_window_tree_host.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/host/ash_window_tree_host_platform.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/keyboard/arc/arc_input_method_surface_manager_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/keyboard/test_keyboard_ui.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/magnifier/docked_magnifier_controller.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/magnifier/magnification_controller_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/metrics/desktop_task_switch_metric_recorder_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/public/cpp/frame_border_hit_test.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/root_window_controller.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/shell.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/shell.h
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/shell_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/system/message_center/arc/arc_notification_content_view_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/system/message_center/arc/arc_notification_surface_impl.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/system/message_center/arc/arc_notification_view_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/system/message_center/arc/mock_arc_notification_surface.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/system/message_center/arc/mock_arc_notification_surface.h
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/system/night_light/night_light_controller.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/test/ash_test_base.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/test/ash_test_base.h
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/test/ash_test_helper.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/test/ash_test_helper.h
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/test/ash_test_suite.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/test/ui_controls_factory_ash.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/utility/screenshot_controller_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wayland/wayland_server_controller.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wayland/wayland_server_controller.h
[add] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/window_factory.cc
[add] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/window_factory.h
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/window_user_data_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/ash_focus_rules_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/cursor_manager_chromeos.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/default_window_resizer_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/drag_window_controller.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/drag_window_resizer_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/immersive_fullscreen_controller_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/native_cursor_manager_ash_classic.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/non_client_frame_controller.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/stacking_controller_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/system_gesture_event_filter_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/system_modal_container_layout_manager_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/top_level_window_factory.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/toplevel_window_event_handler.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/toplevel_window_event_handler_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/video_detector.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/window_dimmer.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/window_dimmer_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/workspace/workspace_event_handler_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/wm/workspace_controller_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ash/ws/window_service_owner.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/chrome/browser/chromeos/accessibility/select_to_speak_event_handler_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/chrome/browser/ui/ash/ksv/DEPS
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_util.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/chrome/test/base/browser_with_test_window_test.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/components/exo/test/exo_test_base.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/components/exo/wayland/clients/test/wayland_client_test.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ui/aura/env.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ui/aura/env.h
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ui/aura/test/test_windows.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ui/aura/test/test_windows.h
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ui/aura/window.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ui/aura/window.h
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ui/aura/window_tree_host_platform.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ui/base/ui_base_features.cc
[modify] https://crrev.com/ac410622018078a68a7677a5ae89c2f51afafa92/ui/base/ui_base_features.h

Project Member

Comment 36 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cbb180270ad4a3962876519ff9693fdfcbf88d2

commit 1cbb180270ad4a3962876519ff9693fdfcbf88d2
Author: Scott Violet <sky@chromium.org>
Date: Mon Aug 13 21:00:29 2018

chromeos: removes a conditional that is always true

Env should always be created here, and always have a mode of LOCAL.

BUG=847992
TEST=covered by tests

Change-Id: I27789a9633eff910b9a950fbd44c4ece967f02c9
Reviewed-on: https://chromium-review.googlesource.com/1173328
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582700}
[modify] https://crrev.com/1cbb180270ad4a3962876519ff9693fdfcbf88d2/ash/app_list/views/app_list_view_unittest.cc

Project Member

Comment 37 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13cb35b18dc3b2adddeed2bf8e823cc7ee7cc5d9

commit 13cb35b18dc3b2adddeed2bf8e823cc7ee7cc5d9
Author: Scott Violet <sky@chromium.org>
Date: Tue Aug 14 15:40:46 2018

chromeos: get SingleProcessMash working

BUG=847992
TEST=covered by tests

Change-Id: I94ea9b06426f100520c019759c2d10e477fbede3
Reviewed-on: https://chromium-review.googlesource.com/1173354
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582921}
[modify] https://crrev.com/13cb35b18dc3b2adddeed2bf8e823cc7ee7cc5d9/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/13cb35b18dc3b2adddeed2bf8e823cc7ee7cc5d9/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.h
[modify] https://crrev.com/13cb35b18dc3b2adddeed2bf8e823cc7ee7cc5d9/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[modify] https://crrev.com/13cb35b18dc3b2adddeed2bf8e823cc7ee7cc5d9/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h
[modify] https://crrev.com/13cb35b18dc3b2adddeed2bf8e823cc7ee7cc5d9/chrome/browser/ui/views/frame/browser_frame_mash.cc
[modify] https://crrev.com/13cb35b18dc3b2adddeed2bf8e823cc7ee7cc5d9/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/13cb35b18dc3b2adddeed2bf8e823cc7ee7cc5d9/chrome/browser/ui/views/frame/native_browser_frame_factory_chromeos.cc
[modify] https://crrev.com/13cb35b18dc3b2adddeed2bf8e823cc7ee7cc5d9/content/browser/browser_main_loop.cc
[modify] https://crrev.com/13cb35b18dc3b2adddeed2bf8e823cc7ee7cc5d9/ui/base/ui_base_features.cc
[modify] https://crrev.com/13cb35b18dc3b2adddeed2bf8e823cc7ee7cc5d9/ui/base/ui_base_features.h
[modify] https://crrev.com/13cb35b18dc3b2adddeed2bf8e823cc7ee7cc5d9/ui/views/mus/mus_client.cc
[modify] https://crrev.com/13cb35b18dc3b2adddeed2bf8e823cc7ee7cc5d9/ui/views/mus/mus_client.h
[modify] https://crrev.com/13cb35b18dc3b2adddeed2bf8e823cc7ee7cc5d9/ui/views/mus/screen_mus.cc
[modify] https://crrev.com/13cb35b18dc3b2adddeed2bf8e823cc7ee7cc5d9/ui/views/mus/screen_mus.h

Project Member

Comment 38 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41b5497b95c2bc02d527aa4154d4f531e45a0303

commit 41b5497b95c2bc02d527aa4154d4f531e45a0303
Author: Scott Violet <sky@chromium.org>
Date: Wed Aug 15 04:14:35 2018

chromeos: gets more ash_unittests working with single-process mash

The OverviewButtonTrayTests need to set the keyboard devices *after*
AshTestBase::SetUp() is called. This is is important in single-process mash
as Ash is the one creating the Env that the keyboard devices us. In
non-single-process-mash AshTestSuite is creating the Env these tests use.

The case ShellTest2.DontCrashWhenWindowDeleted is exercising is different
enough for single-process mash that I created a separate test.

Adding NOPRESUBMIT=true as this bot passed the trybots, and we're ok with
this test including Env::GetInstance().

NOPRESUBMIT=true

BUG=847992
TEST=test only changes

Change-Id: I0543db96ca9aa910340360d8da3e6aafcda34d7f
Reviewed-on: https://chromium-review.googlesource.com/1174978
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583161}
[modify] https://crrev.com/41b5497b95c2bc02d527aa4154d4f531e45a0303/ash/shell_unittest.cc
[modify] https://crrev.com/41b5497b95c2bc02d527aa4154d4f531e45a0303/ash/system/overview/overview_button_tray_unittest.cc

Project Member

Comment 39 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4bef8119c4af33a847311174ef651d01c61318f

commit d4bef8119c4af33a847311174ef651d01c61318f
Author: Scott Violet <sky@chromium.org>
Date: Wed Aug 15 04:18:09 2018

aura: explicitly delete WindowPort in destructor

This way the WindowPort can reach back into the Window during destruction.

BUG=847992
TEST=covered by tests

Change-Id: I70df1c9512086f9e834ab76fa430c94f5723f34d
Reviewed-on: https://chromium-review.googlesource.com/1175133
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583163}
[modify] https://crrev.com/d4bef8119c4af33a847311174ef651d01c61318f/ui/aura/window.cc

Project Member

Comment 40 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec44b29ba0c9638037b209bee50da6793fa2c1f2

commit ec44b29ba0c9638037b209bee50da6793fa2c1f2
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Wed Aug 15 08:43:27 2018

Revert "chromeos: gets more ash_unittests working with single-process mash"

This reverts commit 41b5497b95c2bc02d527aa4154d4f531e45a0303.

Reason for revert: Caused ash_content_unittests failure on linux-chromeos-dbg - https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7312

Original change's description:
> chromeos: gets more ash_unittests working with single-process mash
> 
> The OverviewButtonTrayTests need to set the keyboard devices *after*
> AshTestBase::SetUp() is called. This is is important in single-process mash
> as Ash is the one creating the Env that the keyboard devices us. In
> non-single-process-mash AshTestSuite is creating the Env these tests use.
> 
> The case ShellTest2.DontCrashWhenWindowDeleted is exercising is different
> enough for single-process mash that I created a separate test.
> 
> Adding NOPRESUBMIT=true as this bot passed the trybots, and we're ok with
> this test including Env::GetInstance().
> 
> NOPRESUBMIT=true
> 
> BUG=847992
> TEST=test only changes
> 
> Change-Id: I0543db96ca9aa910340360d8da3e6aafcda34d7f
> Reviewed-on: https://chromium-review.googlesource.com/1174978
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583161}

TBR=jamescook@chromium.org,sky@chromium.org

Change-Id: Ib23d73ef909ac7fe2c9821d7ca8203228bd7fb4a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847992
Reviewed-on: https://chromium-review.googlesource.com/1174493
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583197}
[modify] https://crrev.com/ec44b29ba0c9638037b209bee50da6793fa2c1f2/ash/shell_unittest.cc
[modify] https://crrev.com/ec44b29ba0c9638037b209bee50da6793fa2c1f2/ash/system/overview/overview_button_tray_unittest.cc

Project Member

Comment 41 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd06095126c399079dde1743adf21462c05a471e

commit cd06095126c399079dde1743adf21462c05a471e
Author: Scott Violet <sky@chromium.org>
Date: Wed Aug 15 15:55:32 2018

reland: chromeos: gets more ash_unittests working with single-process mash

The OverviewButtonTrayTests need to set the keyboard devices *after*
AshTestBase::SetUp() is called. This is is important in single-process mash
as Ash is the one creating the Env that the keyboard devices us. In
non-single-process-mash AshTestSuite is creating the Env these tests use.

The case ShellTest2.DontCrashWhenWindowDeleted is exercising is different
enough for single-process mash that I created a separate test.

Adding NOPRESUBMIT=true as this bot passed the trybots, and we're ok with
this test including Env::GetInstance().

NOPRESUBMIT=true

BUG=847992
TEST=test only changes
TBR=jamescook@chromium.org

Change-Id: I46fbfa9c78e8b28ac459b9863e34f3761a077c9a
Reviewed-on: https://chromium-review.googlesource.com/1175848
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583262}
[modify] https://crrev.com/cd06095126c399079dde1743adf21462c05a471e/ash/shell_unittest.cc
[modify] https://crrev.com/cd06095126c399079dde1743adf21462c05a471e/ash/system/overview/overview_button_tray_unittest.cc

Project Member

Comment 42 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d8df637c9983d05dd341dd4b57216f63fb59cf8

commit 4d8df637c9983d05dd341dd4b57216f63fb59cf8
Author: Scott Violet <sky@chromium.org>
Date: Wed Aug 15 17:18:59 2018

aura: makes ~WindowPortLocal get Env from window

Rather than Env::GetInstance(). This ensures the right instance is used.

BUG=847992
TEST=covered by tests

Change-Id: I9b75458c1e4d21402ef2e58833c57ff9a289b7a0
Reviewed-on: https://chromium-review.googlesource.com/1176062
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583296}
[modify] https://crrev.com/4d8df637c9983d05dd341dd4b57216f63fb59cf8/ui/aura/local/window_port_local.cc

Project Member

Comment 43 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5d4478fd7a470139c5fbb33001b057d30ec6fb2

commit e5d4478fd7a470139c5fbb33001b057d30ec6fb2
Author: Scott Violet <sky@chromium.org>
Date: Wed Aug 15 22:06:28 2018

chromeos: update ImmersiveFullscreenControllerTestApi

for single-process-ash. Specifically to get the Env from the Widget not
the static.

BUG=847992
TEST=covered by tests

Change-Id: I508f5cbd6dabaecea00cedd05f1702db37df9a2c
Reviewed-on: https://chromium-review.googlesource.com/1176375
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583413}
[modify] https://crrev.com/e5d4478fd7a470139c5fbb33001b057d30ec6fb2/ash/public/cpp/immersive/immersive_fullscreen_controller_test_api.cc

Project Member

Comment 44 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8aab791f3d331cf426a99fb72bb8445b711c61a

commit e8aab791f3d331cf426a99fb72bb8445b711c61a
Author: Scott Violet <sky@chromium.org>
Date: Mon Aug 20 18:26:45 2018

chromeos: use Env from Widget in TabStripDragController

This ensures the right Env is obtained.

BUG=847992
TEST=none

Change-Id: I5119cc7187c27fc6b5a38911777c974f12e3c093
Reviewed-on: https://chromium-review.googlesource.com/1181536
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584505}
[modify] https://crrev.com/e8aab791f3d331cf426a99fb72bb8445b711c61a/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/e8aab791f3d331cf426a99fb72bb8445b711c61a/chrome/browser/ui/views/tabs/tab_drag_controller.h

Blockedon: 878914

Sign in to add a comment